Skip to content

Commit 3dbcf39

Browse files
d-csclaude
andcommitted
chore(run-ops split): strip test-enumeration labels from pr07 comments and test names
Review hygiene only: remove the NEW-1 label, Test X: name prefixes, and [TEST-NEWSEED] comment label. No product logic or test behavior changed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent bf8f7c8 commit 3dbcf39

5 files changed

Lines changed: 8 additions & 8 deletions

apps/webapp/app/v3/services/executeTasksWaitingForDeploy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export class ExecuteTasksWaitingForDeployService extends BaseService {
7171
return;
7272
}
7373

74-
// NEW-1 defense-in-depth: the open-predicate findRuns fan-out can select runs from
74+
// Defense-in-depth: the open-predicate findRuns fan-out can select runs from
7575
// either DB, but the status flip below is a single control-plane updateMany. A
7676
// ksuid (NEW-resident) run can only reach WAITING_FOR_DEPLOY via a misconfiguration
7777
// (it is a V1/cuid-only status — V2 uses PENDING_VERSION). Surface it loudly rather

apps/webapp/test/cancelDevSessionRunsStoreRouting.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ function recording(client: PrismaClient, opts: { forbidden?: boolean } = {}) {
9090

9191
describe("CancelDevSessionRunsService store routing (hetero)", () => {
9292
heteroPostgresTest(
93-
"Test B: a NEW run (ksuid) resolves on the new store via read-through, by friendlyId and by id",
93+
"a NEW run (ksuid) resolves on the new store via read-through, by friendlyId and by id",
9494
async ({ prisma17, prisma14 }) => {
9595
const id = generateKsuidId();
9696
expect(id.length).toBe(27);
@@ -156,7 +156,7 @@ describe("CancelDevSessionRunsService store routing (hetero)", () => {
156156
);
157157

158158
heteroPostgresTest(
159-
"Test C: an OLD in-retention run (cuid) resolves off the LEGACY replica, never a legacy primary",
159+
"an OLD in-retention run (cuid) resolves off the LEGACY replica, never a legacy primary",
160160
async ({ prisma17, prisma14 }) => {
161161
const id = generateLegacyCuid();
162162
expect(id.length).toBe(25);
@@ -202,7 +202,7 @@ describe("CancelDevSessionRunsService store routing (hetero)", () => {
202202

203203
describe("CancelDevSessionRunsService passthrough (single-DB)", () => {
204204
postgresTest(
205-
"Test A: with no read-through deps, the run is read from the single DB and session reads stay on it",
205+
"with no read-through deps, the run is read from the single DB and session reads stay on it",
206206
async ({ prisma }) => {
207207
const id = generateKsuidId();
208208
const friendlyId = `run_${id}`;

apps/webapp/test/performTaskRunAlertsStoreRouting.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ async function dropTaskRunCrossSeamFks(prisma: PrismaClient) {
216216

217217
describe("PerformTaskRunAlertsService store routing (hetero)", () => {
218218
heteroPostgresTest(
219-
"Test B: env type resolves via the control-plane resolver (distinct DB) while the run resolves on the run-ops store",
219+
"env type resolves via the control-plane resolver (distinct DB) while the run resolves on the run-ops store",
220220
async ({ prisma17, prisma14 }) => {
221221
const id = generateKsuidId();
222222
const friendlyId = `run_${id}`;
@@ -308,7 +308,7 @@ describe("PerformTaskRunAlertsService store routing (hetero)", () => {
308308

309309
describe("PerformTaskRunAlertsService passthrough (single-DB)", () => {
310310
postgresTest(
311-
"Test A: with the default store, run read + alert-channel read both resolve on the single DB",
311+
"with the default store, run read + alert-channel read both resolve on the single DB",
312312
async ({ prisma }) => {
313313
const id = generateKsuidId();
314314
const friendlyId = `run_${id}`;

apps/webapp/test/resolveWaitpointThroughReadThrough.readthrough.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ describe("resolveWaitpointThroughReadThrough (hetero PG14 legacy + dedicated run
8989
const id = generateKsuidId();
9090
expect(id.length).toBe(27);
9191

92-
// [TEST-NEWSEED] The dedicated run-ops DB has no control-plane tables; the waitpoint's
92+
// The dedicated run-ops DB has no control-plane tables; the waitpoint's
9393
// environment/project FKs are synthetic scalar ids.
9494
const environmentId = generateKsuidId();
9595
const projectId = generateKsuidId();

apps/webapp/test/streamLoader.controlPlane.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ async function seedControlPlane(prisma: PrismaClient) {
3535
return { organization, project, environment };
3636
}
3737

38-
// [TEST-NEWSEED] The run lives on the dedicated run-ops client; control-plane FKs are synthetic
38+
// The run lives on the dedicated run-ops client; control-plane FKs are synthetic
3939
// scalar ids pointing at PG14 rows (the dedicated DB has no control-plane tables).
4040
async function seedRunOpsRun(
4141
prisma: RunOpsPrismaClient,

0 commit comments

Comments
 (0)