Skip to content

Commit 22a7e33

Browse files
authored
fix(webapp): render error page full screen and use Enter shortcut (#4121)
Makes the app error page always render full screen — it previously inherited the width/offset of whatever container the error boundary was mounted in (e.g. the centered `max-w-xs` column in the root boundary), so `min-h-screen` alone couldn't fill the viewport. The root container now uses `fixed inset-0 z-50` to break out and cover the full screen regardless of nesting. Also changes the "Go to homepage" shortcut from `Cmd/Ctrl+G` (which collides with the browser's native "Find Again") to `Enter`.
1 parent 8947c07 commit 22a7e33

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
area: webapp
3+
type: fix
4+
---
5+
6+
Error page now always renders full screen, and its "Go to homepage" shortcut changed from Cmd/Ctrl+G to Enter.

apps/webapp/app/components/ErrorDisplay.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,13 @@ type DisplayOptionsProps = {
6060

6161
export function ErrorDisplay({ title, message, button }: DisplayOptionsProps) {
6262
return (
63-
<div className="relative flex min-h-screen flex-col items-center justify-center bg-[#16181C]">
64-
<div className="z-10 mt-[30vh] flex flex-col items-center gap-8">
63+
<div className="fixed inset-0 z-50 flex flex-col items-center justify-center overflow-y-auto bg-[#16181C]">
64+
<div className="z-10 mt-[30vh] flex shrink-0 flex-col items-center gap-8">
6565
<Header1>{title}</Header1>
6666
{message && <Paragraph>{message}</Paragraph>}
6767
<LinkButton
6868
to={button ? button.to : "/"}
69-
shortcut={{ modifiers: ["mod"], key: "g" }}
69+
shortcut={{ key: "enter" }}
7070
variant="primary/medium"
7171
LeadingIcon={HomeIcon}
7272
>

0 commit comments

Comments
 (0)