-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathpostgres_internal_test.go
More file actions
515 lines (450 loc) · 16.3 KB
/
Copy pathpostgres_internal_test.go
File metadata and controls
515 lines (450 loc) · 16.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
package postgres
import (
"database/sql"
"os"
"testing"
"github.com/tinywasm/ddl"
"github.com/tinywasm/fmt"
"github.com/tinywasm/model"
"github.com/tinywasm/storage"
)
type mockInternalModel struct{}
func (m *mockInternalModel) ModelName() string { return "internal_test" }
func (m *mockInternalModel) Schema() []model.Field {
return []model.Field{
{Name: "id", Type: model.Int(), DB: &model.FieldDB{PK: true, AutoInc: true}},
{Name: "name", Type: model.Text(), NotNull: true},
}
}
func (m *mockInternalModel) Pointers() []any { return nil }
func (m *mockInternalModel) EncodeFields(w model.FieldWriter) {}
func (m *mockInternalModel) DecodeFields(r model.FieldReader) {}
func (m *mockInternalModel) IsNil() bool { return m == nil }
type compositePKModel struct{}
func (m *compositePKModel) ModelName() string { return "composite_pk" }
func (m *compositePKModel) Schema() []model.Field {
return []model.Field{
{Name: "id1", Type: model.Int(), DB: &model.FieldDB{PK: true}},
{Name: "id2", Type: model.Int(), DB: &model.FieldDB{PK: true}},
}
}
func (m *compositePKModel) Pointers() []any { return nil }
func (m *compositePKModel) EncodeFields(w model.FieldWriter) {}
func (m *compositePKModel) DecodeFields(r model.FieldReader) {}
func (m *compositePKModel) IsNil() bool { return m == nil }
type cyclicModelA struct{}
func (m *cyclicModelA) ModelName() string { return "cyclic_a" }
func (m *cyclicModelA) Schema() []model.Field {
return []model.Field{{Name: "id", Type: model.Int(), DB: &model.FieldDB{PK: true}}}
}
func (m *cyclicModelA) SchemaExt() []model.FieldExt {
return []model.FieldExt{{Field: model.Field{Name: "b_id"}, Ref: "cyclic_b"}}
}
func (m *cyclicModelA) Pointers() []any { return nil }
func (m *cyclicModelA) EncodeFields(w model.FieldWriter) {}
func (m *cyclicModelA) DecodeFields(r model.FieldReader) {}
func (m *cyclicModelA) IsNil() bool { return m == nil }
type cyclicModelB struct{}
func (m *cyclicModelB) ModelName() string { return "cyclic_b" }
func (m *cyclicModelB) Schema() []model.Field {
return []model.Field{{Name: "id", Type: model.Int(), DB: &model.FieldDB{PK: true}}}
}
func (m *cyclicModelB) SchemaExt() []model.FieldExt {
return []model.FieldExt{{Field: model.Field{Name: "a_id"}, Ref: "cyclic_a"}}
}
func (m *cyclicModelB) Pointers() []any { return nil }
func (m *cyclicModelB) EncodeFields(w model.FieldWriter) {}
func (m *cyclicModelB) DecodeFields(r model.FieldReader) {}
func (m *cyclicModelB) IsNil() bool { return m == nil }
type autoIncNonPKModel struct{}
func (m *autoIncNonPKModel) ModelName() string { return "autoinc_non_pk" }
func (m *autoIncNonPKModel) Schema() []model.Field {
return []model.Field{
{Name: "id", Type: model.Int(), DB: &model.FieldDB{PK: true}},
{Name: "seq", Type: model.Int(), DB: &model.FieldDB{AutoInc: true}},
{Name: "uid", Type: model.Text(), DB: &model.FieldDB{Unique: true}},
}
}
func (m *autoIncNonPKModel) Pointers() []any { return nil }
func (m *autoIncNonPKModel) EncodeFields(w model.FieldWriter) {}
func (m *autoIncNonPKModel) DecodeFields(r model.FieldReader) {}
func (m *autoIncNonPKModel) IsNil() bool { return m == nil }
type allTypesModel struct{}
func (m *allTypesModel) ModelName() string { return "all_types" }
func (m *allTypesModel) Schema() []model.Field {
return []model.Field{
{Name: "f_int", Type: model.Int()},
{Name: "f_float", Type: model.Float()},
{Name: "f_bool", Type: model.Bool()},
{Name: "f_blob", Type: model.Blob()},
}
}
func (m *allTypesModel) Pointers() []any { return nil }
func (m *allTypesModel) EncodeFields(w model.FieldWriter) {}
func (m *allTypesModel) DecodeFields(r model.FieldReader) {}
func (m *allTypesModel) IsNil() bool { return m == nil }
// reservedWordModel mirrors tinywasm/user's real UserModel: a table literally
// named "user" — a Postgres reserved keyword. This is the exact shape that
// produced "pq: syntax error at or near "user" at column 28" before
// quoteIdent existed.
type reservedWordModel struct{}
func (m *reservedWordModel) ModelName() string { return "user" }
func (m *reservedWordModel) Schema() []model.Field {
return []model.Field{
{Name: "id", Type: model.Text(), DB: &model.FieldDB{PK: true}},
{Name: "order", Type: model.Text()}, // also reserved — column position, not just table
}
}
func (m *reservedWordModel) Pointers() []any { return nil }
func (m *reservedWordModel) EncodeFields(w model.FieldWriter) {}
func (m *reservedWordModel) DecodeFields(r model.FieldReader) {}
func (m *reservedWordModel) IsNil() bool { return m == nil }
func TestQuoteIdent(t *testing.T) {
cases := []struct{ in, want string }{
{"", ""},
{"*", "*"},
{"user", `"user"`},
{"id", `"id"`},
{`we"ird`, `"we""ird"`},
{"t.col", `"t"."col"`},
}
for _, c := range cases {
if got := quoteIdent(c.in); got != c.want {
t.Errorf("quoteIdent(%q) = %q, want %q", c.in, got, c.want)
}
}
}
// TestTranslateDDL_ReservedWordTable is the regression net for the "user"
// syntax error: every identifier translateDDL writes for a reserved-word
// table/column must come out quoted, never bare.
func TestTranslateDDL_ReservedWordTable(t *testing.T) {
query, _, err := translateDDL(ddl.Stmt{Op: ddl.OpCreateTable, Table: "user"}, &reservedWordModel{})
if err != nil {
t.Fatalf("translateDDL failed: %v", err)
}
want := `CREATE TABLE IF NOT EXISTS "user" ("id" TEXT PRIMARY KEY, "order" TEXT)`
if query != want {
t.Errorf("got:\n%s\nwant:\n%s", query, want)
}
dropQuery, _, err := translateDDL(ddl.Stmt{Op: ddl.OpDropTable, Table: "user"}, &reservedWordModel{})
if err != nil {
t.Fatalf("translateDDL drop failed: %v", err)
}
if dropQuery != `DROP TABLE IF EXISTS "user"` {
t.Errorf("got %q", dropQuery)
}
}
// TestTranslate_ReservedWordTable covers the DML side (INSERT/SELECT/UPDATE/
// DELETE, plus WHERE/ORDER BY) against the same "user" table and an "order"
// column, so every identifier-writing branch in translate/buildConditions is
// exercised at least once.
func TestTranslate_ReservedWordTable(t *testing.T) {
insert, _, err := translate(storage.Query{
Action: storage.ActionCreate, Table: "user", Columns: []string{"order"}, Values: []any{"x"},
}, &reservedWordModel{})
if err != nil || insert != `INSERT INTO "user" ("order") VALUES ($1)` {
t.Errorf("insert: got %q, err %v", insert, err)
}
sel, _, err := translate(storage.Query{
Action: storage.ActionReadAll, Table: "user", Columns: []string{"order"},
Conditions: []storage.Condition{storage.Eq("order", "x")},
OrderBy: []storage.Order{storage.Asc("order")},
}, &reservedWordModel{})
want := `SELECT "order" FROM "user" WHERE "order" = $1 ORDER BY "order" ASC`
if err != nil || sel != want {
t.Errorf("select: got %q, want %q, err %v", sel, want, err)
}
upd, _, err := translate(storage.Query{
Action: storage.ActionUpdate, Table: "user", Columns: []string{"order"}, Values: []any{"y"},
}, &reservedWordModel{})
if err != nil || upd != `UPDATE "user" SET "order" = $1` {
t.Errorf("update: got %q, err %v", upd, err)
}
del, _, err := translate(storage.Query{Action: storage.ActionDelete, Table: "user"}, &reservedWordModel{})
if err != nil || del != `DELETE FROM "user"` {
t.Errorf("delete: got %q, err %v", del, err)
}
}
type errorQuerier struct{}
func (e errorQuerier) Query(query string, args ...any) (storage.Rows, error) {
return nil, fmt.Err("mock query error")
}
func TestInternal_Coverage(t *testing.T) {
// Test helper functions in translate.go
if onDeleteSQL("restrict") != "RESTRICT" {
t.Error("expected RESTRICT")
}
if onDeleteSQL("set_null") != "SET NULL" {
t.Error("expected SET NULL")
}
if onDeleteSQL("no_action") != "NO ACTION" {
t.Error("expected NO ACTION")
}
if onDeleteSQL("cascade") != "CASCADE" {
t.Error("expected CASCADE")
}
// Test compile errors and invalid inputs
invalidQuery := storage.Query{Action: storage.Action(999)}
_, _, err := translate(invalidQuery, &mockInternalModel{})
if err == nil {
t.Error("expected error on invalid DML action")
}
invalidStmt := ddl.Stmt{Op: ddl.Op(999)}
_, _, err = translateDDL(invalidStmt, &mockInternalModel{})
if err == nil {
t.Error("expected error on invalid DDL op")
}
// DDL: OpAddColumn error
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpAddColumn}, &mockInternalModel{})
if err == nil {
t.Error("expected error on OpAddColumn with nil column")
}
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpAddColumn, Column: &model.Field{Name: "bio", Type: model.Text()}}, &mockInternalModel{})
if err == nil {
t.Error("expected error on OpAddColumn with empty Table")
}
// DDL: OpRenameColumn error
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpRenameColumn}, &mockInternalModel{})
if err == nil {
t.Error("expected error on OpRenameColumn with nil column")
}
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpRenameColumn, Column: &model.Field{Name: "bio", Type: model.Text()}, OldName: "old"}, &mockInternalModel{})
if err == nil {
t.Error("expected error on OpRenameColumn with empty Table")
}
// DDL: OpDropColumn error
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpDropColumn}, &mockInternalModel{})
if err == nil {
t.Error("expected error on OpDropColumn with empty column name")
}
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpDropColumn, ColumnName: "bio"}, &mockInternalModel{})
if err == nil {
t.Error("expected error on OpDropColumn with empty Table")
}
// Test public exports Translate & TranslateDDL
_, _, _ = Translate(storage.Query{Action: storage.ActionCreate, Table: "t"}, &mockInternalModel{})
_, _, _ = TranslateDDL(ddl.Stmt{Op: ddl.OpDropTable, Table: "t"}, &mockInternalModel{})
// Test compile error inside adapter Compile
adapterNilDB := &PostgresAdapter{}
_, err = adapterNilDB.Compile(invalidQuery, &mockInternalModel{})
if err == nil {
t.Error("expected Compile to propagate error from translate")
}
// Test composite PK in translateDDL
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpCreateTable, Table: "composite_pk"}, &compositePKModel{})
if err != nil {
t.Errorf("expected composite PK translation to succeed, got: %v", err)
}
// Test autoIncNonPKModel in translateDDL
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpCreateTable, Table: "autoinc_non_pk"}, &autoIncNonPKModel{})
if err != nil {
t.Errorf("expected autoIncNonPKModel translation to succeed, got: %v", err)
}
// Test allTypesModel in translateDDL
_, _, err = translateDDL(ddl.Stmt{Op: ddl.OpCreateTable, Table: "all_types"}, &allTypesModel{})
if err != nil {
t.Errorf("expected allTypesModel translation to succeed, got: %v", err)
}
// Test topological sort error in ExportDDL
comp := NewCompiler()
_, err = comp.ExportDDL([]model.Model{&cyclicModelA{}, &cyclicModelB{}})
if err == nil {
t.Error("expected ExportDDL to fail on cyclic dependencies")
}
// Test error paths in tableColumns, tables, and columns functions
eq := errorQuerier{}
_, err = tableColumns(eq, "t")
if err == nil {
t.Error("expected tableColumns to fail with query error")
}
_, err = tables(eq)
if err == nil {
t.Error("expected tables to fail with query error")
}
_, err = columns(eq, "t")
if err == nil {
t.Error("expected columns to fail with query error")
}
// Test IN conditions corner cases
sb := buildConditionsTest()
var args []any
argIndex := 1
err = buildConditions(sb, []storage.Condition{
storage.In("id", 123), // non-slice
}, &args, &argIndex)
if err == nil {
t.Error("expected error for non-slice IN value")
}
err = buildConditions(sb, []storage.Condition{
storage.In("id", []any{}), // empty slice
}, &args, &argIndex)
if err == nil {
t.Error("expected error for empty slice IN value")
}
// Test standard operators and conditional logic
sb = buildConditionsTest()
args = nil
argIndex = 1
err = buildConditions(sb, []storage.Condition{
storage.Eq("name", "Alice"),
storage.Or(storage.Eq("name", "Bob")),
storage.IsNotNull("active"),
}, &args, &argIndex)
if err != nil {
t.Errorf("failed to build conditions: %v", err)
}
// Test Translate with orderBy, limit, and offset
readQuery := storage.Query{
Action: storage.ActionReadAll,
Table: "internal_test",
Columns: []string{"id", "name"},
OrderBy: []storage.Order{
storage.Asc("name"),
storage.Desc("id"),
},
Limit: 10,
Offset: 2,
}
_, _, err = translate(readQuery, &mockInternalModel{})
if err != nil {
t.Errorf("failed to translate ReadAll with order, limit, offset: %v", err)
}
// Connection tests
dsn := os.Getenv("POSTGRES_DSN")
if dsn == "" {
t.Skip("POSTGRES_DSN not set, skipping integration coverage")
}
// Test Open error
_, err = Open("postgres://invalid:password@localhost:5432/nonexistent?sslmode=disable")
if err == nil {
t.Error("expected failure to open invalid dsn connection")
}
conn, err := Open(dsn)
if err != nil {
t.Fatalf("Open failed: %v", err)
}
defer conn.Close()
adapter := conn.(*PostgresAdapter)
// Test BeginTx error with closed connection
rawClose, err := sql.Open("postgres", dsn)
if err == nil {
rawClose.Close()
adapterClosed := AdapterForTest(rawClose)
_, err = adapterClosed.BeginTx()
if err == nil {
t.Error("expected BeginTx to fail on closed raw connection")
}
}
// Clean up table if it exists
_ = adapter.Exec("DROP TABLE IF EXISTS internal_test CASCADE")
// Create table using adapter CompileDDL
createStmt := ddl.Stmt{Op: ddl.OpCreateTable, Table: "internal_test"}
query, _, err := adapter.CompileDDL(createStmt, &mockInternalModel{})
if err != nil {
t.Fatalf("CompileDDL failed: %v", err)
}
if err := adapter.Exec(query); err != nil {
t.Fatalf("Exec failed: %v", err)
}
// Test Introspection (Tables and Columns)
tbls, err := adapter.Tables()
if err != nil {
t.Fatalf("Tables failed: %v", err)
}
found := false
for _, tbl := range tbls {
if tbl == "internal_test" {
found = true
}
}
if !found {
t.Error("expected 'internal_test' table to be found in Tables()")
}
cols, err := adapter.Columns("internal_test")
if err != nil {
t.Fatalf("Columns failed: %v", err)
}
if len(cols) != 2 {
t.Errorf("expected 2 columns, got %d", len(cols))
}
// Test Compile DML
insertQuery := storage.Query{
Action: storage.ActionCreate,
Table: "internal_test",
Columns: []string{"name"},
Values: []any{"hello"},
}
plan, err := adapter.Compile(insertQuery, &mockInternalModel{})
if err != nil {
t.Fatalf("Compile insert failed: %v", err)
}
// Test Exec / Query / QueryRow
if err := adapter.Exec(plan.Query, plan.Args...); err != nil {
t.Fatalf("Exec insert failed: %v", err)
}
var name string
err = adapter.QueryRow("SELECT name FROM internal_test WHERE id = $1", 1).Scan(&name)
if err != nil {
t.Fatalf("QueryRow scan failed: %v", err)
}
if name != "hello" {
t.Errorf("expected 'hello', got %q", name)
}
// errScanner ErrNoRows
err = adapter.QueryRow("SELECT name FROM internal_test WHERE id = $1", 999).Scan(&name)
if err != storage.ErrNoRows {
t.Errorf("expected storage.ErrNoRows, got %v", err)
}
// Test PostgresTx Coverage
txBound, err := adapter.BeginTx()
if err != nil {
t.Fatalf("BeginTx failed: %v", err)
}
defer txBound.Close()
tx := txBound.(*PostgresTx)
// tx compile
_, err = tx.Compile(insertQuery, &mockInternalModel{})
if err != nil {
t.Errorf("tx.Compile failed: %v", err)
}
// tx CompileDDL
_, _, err = tx.CompileDDL(ddl.Stmt{Op: ddl.OpDropTable, Table: "internal_test"}, &mockInternalModel{})
if err != nil {
t.Errorf("tx.CompileDDL failed: %v", err)
}
// tx Exec / Query / QueryRow
err = tx.Exec("INSERT INTO internal_test (name) VALUES ($1)", "tx-test")
if err != nil {
t.Errorf("tx.Exec failed: %v", err)
}
err = tx.QueryRow("SELECT name FROM internal_test WHERE name = $1", "tx-test").Scan(&name)
if err != nil {
t.Errorf("tx.QueryRow failed: %v", err)
}
rows, err := tx.Query("SELECT name FROM internal_test")
if err != nil {
t.Errorf("tx.Query failed: %v", err)
}
rows.Close()
// tx Introspection
_, err = tx.Tables()
if err != nil {
t.Errorf("tx.Tables failed: %v", err)
}
_, err = tx.Columns("internal_test")
if err != nil {
t.Errorf("tx.Columns failed: %v", err)
}
_, err = tx.TableColumns("internal_test")
if err != nil {
t.Errorf("tx.TableColumns failed: %v", err)
}
// tx Rollback
err = tx.Rollback()
if err != nil {
t.Errorf("tx.Rollback failed: %v", err)
}
}
func buildConditionsTest() *fmt.Conv {
return fmt.Convert()
}