Add fell kind to landuse

[rwrx]

Add fell kind to landuse

[nvkelso]

Makes sense to me, thanks for taking care of the remapping!

[nvkelso]

We need to set a sort_rank for the new fell kind, too.

Otherwise LGTM

[nvkelso]

Are there also names for these, if so we need to add collision_rank.

[rwrx]

I am not sure which number for fell should I set. I have looked at bare_rock, desert, grassland, heath, sand, shingle and they does not have set sort_rank. I haven't found a fell with a name. Is there some online tool to do osm query?

[nvkelso]

Looks like a few fell features do have names:

• https://taginfo.openstreetmap.org/tags/natural=fell#combinations

sort_order:

• https://github.com/tilezen/vector-datasource/blob/master/spreadsheets/sort_rank/landuse.csv
• Insert where grass is now, so fell takes 35 and all the rest above starting with grass increment +1 so power_line becomes 275.
• There will be other test failures associated with this change that you'd need to also update, see CircleCI for which ones after you push the changes.

collision_order:

• https://github.com/tilezen/vector-datasource/blob/master/spreadsheets/collision_rank.yaml#L602
• Much simplier to just inset above grass, and build system takes care of auto incrementing everything.
• You may still have associated test failures in Circle that you'll update for after pushing, too.

[nvkelso]

Please also add a test, here's an example feature:

• https://www.openstreetmap.org/way/711062546

I found it using Overpass-Turbo for (in northern Europe in this case):

• way"natural"="fell";

Which should be in this tile:

• 16, 35072, 18481

With tags:

• area: yes
• name: Fulufjellet
• natural: fell
• wikidata: Q34852081

[rwrx]

I have updated sort and collision ranks, but now Circle is complaining that there is no 265 sort rank, because I have incremented it to 266:

dam,LineString;MultiLineString,266

I am not sure how to change this Circle test.

[rwrx]

I have added test, but I am not sure into which file I should have put it in and I am not sure whether it is correctly written.

[nvkelso]

mud, wetland, land and above don't need to increment their numbers, as there is a discontinuity buffer between mud and footway.

[rwrx]

So, should I remove dam, land, wetland and mud? Will they sort properly when they will be removed from this list?