From e7e5ac6b49e6dc28382475e34a5b77ddd4135168 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 11 Jul 2026 21:15:40 +0000 Subject: [PATCH 1/2] Re-sync Tap House Rules to v2 Pull the v2 canonical configs (.clang-format gains the inert Min-DevKit Macros hints; STYLE.md gains the OscTap naming exemption) and bump the drift-check pin to the v2 commit. SampleRateTap uses none of the Min macros, so no code reformat: the source stays byte-for-byte clang-format-clean under v2. Pinned by commit SHA because the v2 tag can't be pushed by this automation; switch to @v2 once the tag exists. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01MFv37taZQPMMcYG1haRcrk --- .clang-format | 9 +++++++++ .github/workflows/style.yml | 5 +++-- STYLE.md | 14 ++++++++++++++ 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.clang-format b/.clang-format index f1cfdc9..aedca32 100644 --- a/.clang-format +++ b/.clang-format @@ -63,3 +63,12 @@ IncludeCategories: # This project: quoted includes - Regex: '^".*"$' Priority: 4 + +# Min-DevKit declarative DSL (Max/Min externals: TapTools, AmbiTap-Max, ...). +# MIN_FUNCTION / MIN_ARGUMENT_FUNCTION expand to a lambda; teach clang-format +# their shape so attribute/message/argument setter bodies format as lambda +# blocks instead of being shredded. Completely inert for repos that don't use +# these macros (the pure-C++ libraries). Requires clang-format >= 15. +Macros: + - 'MIN_FUNCTION=[](const atoms& args, int inlet) -> atoms' + - 'MIN_ARGUMENT_FUNCTION=[](const atom& arg, int index) -> void' diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml index 850d406..d4fca06 100644 --- a/.github/workflows/style.yml +++ b/.github/workflows/style.yml @@ -7,9 +7,10 @@ on: [push, pull_request] jobs: drift: - uses: tap/taphouse/.github/workflows/drift-check.yml@v1 + # TapHouse v2 (pinned by commit SHA until the v2 tag is created). + uses: tap/taphouse/.github/workflows/drift-check.yml@ff71d8146754e5e35374cfe0d191e0983219da3b with: - ref: v1 + ref: ff71d8146754e5e35374cfe0d191e0983219da3b clang-tidy: runs-on: ubuntu-latest diff --git a/STYLE.md b/STYLE.md index fe70fba..ebfcf54 100644 --- a/STYLE.md +++ b/STYLE.md @@ -50,6 +50,20 @@ member/parameter collision, and prefixes would clutter the public signatures that *are* the library's contract. Lean on `const` and small functions for input/local clarity. +**Repo exception — OscTap (drop-in legacy continuation).** OscTap continues +[oscpack](http://www.rossbencina.com/code/oscpack) as a *drop-in +source-compatible* successor: its public API keeps oscpack's original +identifiers — PascalCase types and methods (`ReceivedMessage`, +`OutboundPacketStream`, `BeginBundle()`, `AsFloat()`) and trailing-underscore +data members (`size_`, `value_`). Renaming these to the house `snake_case`/`m_` +scheme would break the source compatibility that is the library's reason to +exist. OscTap therefore adopts the **layout** rules (`.clang-format`) in full +but is **exempt from the naming rules** (`readability-identifier-naming`): it +ships a local `.clang-tidy` that disables that check while keeping mandatory +braces, and its CI runs a format-only style gate instead of the shared +`drift-check.yml`. The exemption is specific to legacy-continuation repos; +greenfield `*Tap` code follows the naming rules above. + ## 2. Layout - **Indent:** 4 spaces, including inside namespaces. From f9540859f24b054ccac5e6f92d27b41e08e2a926 Mon Sep 17 00:00:00 2001 From: Claude Date: Sun, 12 Jul 2026 03:55:53 +0000 Subject: [PATCH 2/2] style: pin drift check to TapHouse @v2 tag The v2 tag now exists; replace the interim commit-SHA pin with @v2. Co-Authored-By: Claude Opus 4.8 Claude-Session: https://claude.ai/code/session_01MFv37taZQPMMcYG1haRcrk --- .github/workflows/style.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/style.yml b/.github/workflows/style.yml index d4fca06..f6a23ec 100644 --- a/.github/workflows/style.yml +++ b/.github/workflows/style.yml @@ -7,10 +7,9 @@ on: [push, pull_request] jobs: drift: - # TapHouse v2 (pinned by commit SHA until the v2 tag is created). - uses: tap/taphouse/.github/workflows/drift-check.yml@ff71d8146754e5e35374cfe0d191e0983219da3b + uses: tap/taphouse/.github/workflows/drift-check.yml@v2 with: - ref: ff71d8146754e5e35374cfe0d191e0983219da3b + ref: v2 clang-tidy: runs-on: ubuntu-latest