Two of these are the same value when they are {@link #equals}, which - * is the whole reason for records here. A float is the case that usually - * needs a comparison written by hand: NaN is not equal to itself and a case - * asserting NaN has to pass, and 0.0 equals -0.0 and a case asserting -0.0 - * has to fail on 0.0, because the sign of zero is exactly the sort of thing - * that survives one binding and not another. A record's generated equality - * compares a double with {@code Double.compare}, which says yes to the - * first pair and no to the second, so it is already the comparison the - * corpus wants. {@link Bytes} is the one that is not, since an array - * compares by identity, and it is written out below. + *
Two of these are the same value when they are {@link Object#equals(Object) + * equal}, which is the whole reason for records here. A float is the case + * that usually needs a comparison written by hand: NaN is not equal to + * itself and a case asserting NaN has to pass, and 0.0 equals -0.0 and a + * case asserting -0.0 has to fail on 0.0, because the sign of zero is + * exactly the sort of thing that survives one binding and not another. A + * record's generated equality compares a double with + * {@code Double.compare}, which says yes to the first pair and no to the + * second, so it is already the comparison the corpus wants. {@link Bytes} + * is the one that is not, since an array compares by identity, and it is + * written out below. */ public sealed interface Cell { diff --git a/zudb-corpus/src/test/java/dev/zudb/corpus/RunnerTest.java b/zudb-corpus/src/test/java/dev/zudb/corpus/RunnerTest.java index 606c402..4efd478 100644 --- a/zudb-corpus/src/test/java/dev/zudb/corpus/RunnerTest.java +++ b/zudb-corpus/src/test/java/dev/zudb/corpus/RunnerTest.java @@ -225,13 +225,18 @@ record Wrong(String what, String body, String want) {} * A case the engine has not caught up to is unsupported and not a * failure, which is what lets the corpus be the contract and the engine * catch up to it. The two classes that say so are 42 and 0A. + * + *
The statement has to be one the engine really has not reached, and + * a test like this is a canary by construction: the day CREATE lands, + * this stops testing what it says it tests and has to pick another + * spelling. It was SELECT before, which the engine now parses. */ @Test void aCaseAheadOfTheEngineIsUnsupportedAndNotAFailure() { Runner.Ran got = only(""" - name: one doc: d - query: SELECT 1 + query: CREATE NODE TABLE person(uid INT64) columns: - n rows: