Commit 4b9eb47
Use ValueError on 'too many columns'; drop stale enum-guard test
Two small fixes tied together:
- `_validate_import_line_or_throw` raised AttributeError on the
too-many-columns branch; `create_user_from_line` uses ValueError for
the same condition. Copilot review flagged the inconsistency in #1811
since callers using `_validate_import_line_or_throw` directly have to
catch a different exception than they would from
`create_user_from_line` for the same malformed input. Use ValueError
throughout for input-shape violations.
- `test_set_values_rejects_invalid_auth_setting` asserted _set_values
raises ValueError on an unknown auth string. That's exactly the
behavior b088d3d removed (server-parse paths must accept unknown
future auth values). b088d3d added the positive test
(`test_from_xml_accepts_unknown_auth_setting` in test_user.py) but
forgot to delete the contradictory one. Drop it.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 5042949 commit 4b9eb47
2 files changed
Lines changed: 1 addition & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
539 | 539 | | |
540 | 540 | | |
541 | 541 | | |
542 | | - | |
| 542 | + | |
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
183 | 183 | | |
184 | 184 | | |
185 | 185 | | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
0 commit comments