BridgeJS: fix code generation for public enums

wfltaylor · wfltaylor · commit 5bc912244ca8 · 2026-04-14T10:01:28.000+10:00
diff --git a/Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift b/Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift
@@ -966,7 +966,7 @@ struct EnumCodegen {
             )
             printer.nextLine()
 
-            printer.write("private init?(bridgeJSRawValue: Int32) {")
+            printer.write("@_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {")
             printer.indent {
                 printer.write("switch bridgeJSRawValue {")
                 for (index, enumCase) in enumDef.cases.enumerated() {
@@ -984,7 +984,7 @@ struct EnumCodegen {
             printer.write("}")
             printer.nextLine()
 
-            printer.write("private var bridgeJSRawValue: Int32 {")
+            printer.write("@_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {")
             printer.indent {
                 printer.write("switch self {")
                 for (index, enumCase) in enumDef.cases.enumerated() {
diff --git a/Tests/BridgeJSGlobalTests/Generated/BridgeJS.swift b/Tests/BridgeJSGlobalTests/Generated/BridgeJS.swift
@@ -21,7 +21,7 @@ extension GlobalNetworking.API.CallMethod: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .get
@@ -36,7 +36,7 @@ extension GlobalNetworking.API.CallMethod: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .get:
             return 0
@@ -70,7 +70,7 @@ extension Internal.SupportedServerMethod: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .get
@@ -81,7 +81,7 @@ extension Internal.SupportedServerMethod: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .get:
             return 0
diff --git a/Tests/BridgeJSRuntimeTests/ExportAPITests.swift b/Tests/BridgeJSRuntimeTests/ExportAPITests.swift
@@ -207,7 +207,7 @@ extension Greeter {
 
 // MARK: - Enum Tests
 
-@JS enum Direction {
+@JS public enum Direction {
     case north
     case south
     case east
diff --git a/Tests/BridgeJSRuntimeTests/Generated/BridgeJS.swift b/Tests/BridgeJSRuntimeTests/Generated/BridgeJS.swift
@@ -3868,7 +3868,7 @@ extension Direction: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .north
@@ -3883,7 +3883,7 @@ extension Direction: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .north:
             return 0
@@ -3911,7 +3911,7 @@ extension Status: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .loading
@@ -3924,7 +3924,7 @@ extension Status: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .loading:
             return 0
@@ -3968,7 +3968,7 @@ extension TSDirection: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .north
@@ -3983,7 +3983,7 @@ extension TSDirection: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .north:
             return 0
@@ -4036,7 +4036,7 @@ extension Networking.API.Method: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .get
@@ -4051,7 +4051,7 @@ extension Networking.API.Method: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .get:
             return 0
@@ -4085,7 +4085,7 @@ extension Internal.SupportedMethod: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .get
@@ -4096,7 +4096,7 @@ extension Internal.SupportedMethod: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .get:
             return 0
@@ -4369,7 +4369,7 @@ extension StaticCalculator: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .scientific
@@ -4380,7 +4380,7 @@ extension StaticCalculator: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .scientific:
             return 0
@@ -4470,7 +4470,7 @@ extension StaticPropertyEnum: _BridgedSwiftCaseEnum {
         return bridgeJSLowerParameter()
     }
 
-    private init?(bridgeJSRawValue: Int32) {
+    @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {
         switch bridgeJSRawValue {
         case 0:
             self = .option1
@@ -4481,7 +4481,7 @@ extension StaticPropertyEnum: _BridgedSwiftCaseEnum {
         }
     }
 
-    private var bridgeJSRawValue: Int32 {
+    @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {
         switch self {
         case .option1:
             return 0
diff --git a/Tests/BridgeJSRuntimeTests/Generated/JavaScript/BridgeJS.json b/Tests/BridgeJSRuntimeTests/Generated/JavaScript/BridgeJS.json
@@ -7235,6 +7235,7 @@
           }
         ],
         "emitStyle" : "const",
+        "explicitAccessControl" : "public",
         "name" : "Direction",
         "staticMethods" : [
 

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ extension GlobalNetworking.API.CallMethod: _BridgedSwiftCaseEnum {`
`21`	`21`	`return bridgeJSLowerParameter()`
`22`	`22`	`}`
`23`	`23`
`24`		`- private init?(bridgeJSRawValue: Int32) {`
	`24`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`25`	`25`	`switch bridgeJSRawValue {`
`26`	`26`	`case 0:`
`27`	`27`	`self = .get`
`@@ -36,7 +36,7 @@ extension GlobalNetworking.API.CallMethod: _BridgedSwiftCaseEnum {`
`36`	`36`	`}`
`37`	`37`	`}`
`38`	`38`
`39`		`- private var bridgeJSRawValue: Int32 {`
	`39`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`40`	`40`	`switch self {`
`41`	`41`	`case .get:`
`42`	`42`	`return 0`
`@@ -70,7 +70,7 @@ extension Internal.SupportedServerMethod: _BridgedSwiftCaseEnum {`
`70`	`70`	`return bridgeJSLowerParameter()`
`71`	`71`	`}`
`72`	`72`
`73`		`- private init?(bridgeJSRawValue: Int32) {`
	`73`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`74`	`74`	`switch bridgeJSRawValue {`
`75`	`75`	`case 0:`
`76`	`76`	`self = .get`
`@@ -81,7 +81,7 @@ extension Internal.SupportedServerMethod: _BridgedSwiftCaseEnum {`
`81`	`81`	`}`
`82`	`82`	`}`
`83`	`83`
`84`		`- private var bridgeJSRawValue: Int32 {`
	`84`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`85`	`85`	`switch self {`
`86`	`86`	`case .get:`
`87`	`87`	`return 0`
Original file line number	Diff line number	Diff line change
`@@ -3868,7 +3868,7 @@ extension Direction: _BridgedSwiftCaseEnum {`
`3868`	`3868`	`return bridgeJSLowerParameter()`
`3869`	`3869`	`}`
`3870`	`3870`
`3871`		`- private init?(bridgeJSRawValue: Int32) {`
	`3871`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`3872`	`3872`	`switch bridgeJSRawValue {`
`3873`	`3873`	`case 0:`
`3874`	`3874`	`self = .north`
`@@ -3883,7 +3883,7 @@ extension Direction: _BridgedSwiftCaseEnum {`
`3883`	`3883`	`}`
`3884`	`3884`	`}`
`3885`	`3885`
`3886`		`- private var bridgeJSRawValue: Int32 {`
	`3886`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`3887`	`3887`	`switch self {`
`3888`	`3888`	`case .north:`
`3889`	`3889`	`return 0`
`@@ -3911,7 +3911,7 @@ extension Status: _BridgedSwiftCaseEnum {`
`3911`	`3911`	`return bridgeJSLowerParameter()`
`3912`	`3912`	`}`
`3913`	`3913`
`3914`		`- private init?(bridgeJSRawValue: Int32) {`
	`3914`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`3915`	`3915`	`switch bridgeJSRawValue {`
`3916`	`3916`	`case 0:`
`3917`	`3917`	`self = .loading`
`@@ -3924,7 +3924,7 @@ extension Status: _BridgedSwiftCaseEnum {`
`3924`	`3924`	`}`
`3925`	`3925`	`}`
`3926`	`3926`
`3927`		`- private var bridgeJSRawValue: Int32 {`
	`3927`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`3928`	`3928`	`switch self {`
`3929`	`3929`	`case .loading:`
`3930`	`3930`	`return 0`
`@@ -3968,7 +3968,7 @@ extension TSDirection: _BridgedSwiftCaseEnum {`
`3968`	`3968`	`return bridgeJSLowerParameter()`
`3969`	`3969`	`}`
`3970`	`3970`
`3971`		`- private init?(bridgeJSRawValue: Int32) {`
	`3971`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`3972`	`3972`	`switch bridgeJSRawValue {`
`3973`	`3973`	`case 0:`
`3974`	`3974`	`self = .north`
`@@ -3983,7 +3983,7 @@ extension TSDirection: _BridgedSwiftCaseEnum {`
`3983`	`3983`	`}`
`3984`	`3984`	`}`
`3985`	`3985`
`3986`		`- private var bridgeJSRawValue: Int32 {`
	`3986`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`3987`	`3987`	`switch self {`
`3988`	`3988`	`case .north:`
`3989`	`3989`	`return 0`
`@@ -4036,7 +4036,7 @@ extension Networking.API.Method: _BridgedSwiftCaseEnum {`
`4036`	`4036`	`return bridgeJSLowerParameter()`
`4037`	`4037`	`}`
`4038`	`4038`
`4039`		`- private init?(bridgeJSRawValue: Int32) {`
	`4039`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`4040`	`4040`	`switch bridgeJSRawValue {`
`4041`	`4041`	`case 0:`
`4042`	`4042`	`self = .get`
`@@ -4051,7 +4051,7 @@ extension Networking.API.Method: _BridgedSwiftCaseEnum {`
`4051`	`4051`	`}`
`4052`	`4052`	`}`
`4053`	`4053`
`4054`		`- private var bridgeJSRawValue: Int32 {`
	`4054`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`4055`	`4055`	`switch self {`
`4056`	`4056`	`case .get:`
`4057`	`4057`	`return 0`
`@@ -4085,7 +4085,7 @@ extension Internal.SupportedMethod: _BridgedSwiftCaseEnum {`
`4085`	`4085`	`return bridgeJSLowerParameter()`
`4086`	`4086`	`}`
`4087`	`4087`
`4088`		`- private init?(bridgeJSRawValue: Int32) {`
	`4088`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`4089`	`4089`	`switch bridgeJSRawValue {`
`4090`	`4090`	`case 0:`
`4091`	`4091`	`self = .get`
`@@ -4096,7 +4096,7 @@ extension Internal.SupportedMethod: _BridgedSwiftCaseEnum {`
`4096`	`4096`	`}`
`4097`	`4097`	`}`
`4098`	`4098`
`4099`		`- private var bridgeJSRawValue: Int32 {`
	`4099`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`4100`	`4100`	`switch self {`
`4101`	`4101`	`case .get:`
`4102`	`4102`	`return 0`
`@@ -4369,7 +4369,7 @@ extension StaticCalculator: _BridgedSwiftCaseEnum {`
`4369`	`4369`	`return bridgeJSLowerParameter()`
`4370`	`4370`	`}`
`4371`	`4371`
`4372`		`- private init?(bridgeJSRawValue: Int32) {`
	`4372`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`4373`	`4373`	`switch bridgeJSRawValue {`
`4374`	`4374`	`case 0:`
`4375`	`4375`	`self = .scientific`
`@@ -4380,7 +4380,7 @@ extension StaticCalculator: _BridgedSwiftCaseEnum {`
`4380`	`4380`	`}`
`4381`	`4381`	`}`
`4382`	`4382`
`4383`		`- private var bridgeJSRawValue: Int32 {`
	`4383`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`4384`	`4384`	`switch self {`
`4385`	`4385`	`case .scientific:`
`4386`	`4386`	`return 0`
`@@ -4470,7 +4470,7 @@ extension StaticPropertyEnum: _BridgedSwiftCaseEnum {`
`4470`	`4470`	`return bridgeJSLowerParameter()`
`4471`	`4471`	`}`
`4472`	`4472`
`4473`		`- private init?(bridgeJSRawValue: Int32) {`
	`4473`	`+ @_spi(BridgeJS) @usableFromInline init?(bridgeJSRawValue: Int32) {`
`4474`	`4474`	`switch bridgeJSRawValue {`
`4475`	`4475`	`case 0:`
`4476`	`4476`	`self = .option1`
`@@ -4481,7 +4481,7 @@ extension StaticPropertyEnum: _BridgedSwiftCaseEnum {`
`4481`	`4481`	`}`
`4482`	`4482`	`}`
`4483`	`4483`
`4484`		`- private var bridgeJSRawValue: Int32 {`
	`4484`	`+ @_spi(BridgeJS) @usableFromInline var bridgeJSRawValue: Int32 {`
`4485`	`4485`	`switch self {`
`4486`	`4486`	`case .option1:`
`4487`	`4487`	`return 0`
Original file line number	Diff line number	Diff line change
`@@ -7235,6 +7235,7 @@`
`7235`	`7235`	`}`
`7236`	`7236`	`],`
`7237`	`7237`	`"emitStyle" : "const",`
	`7238`	`+ "explicitAccessControl" : "public",`
`7238`	`7239`	`"name" : "Direction",`
`7239`	`7240`	`"staticMethods" : [`
`7240`	`7241`