JNIExtract produces code incompatible with .enableUpcomingFeature("InternalImportsByDefault")

[tkrajacic]

Have to investigate further what exactly causes issues.

Just a placeholder for now

[ktoso]

Would love an example since hard to guess-reproduce without one, but maybe can think of something

[tkrajacic]

You can use my fork of the examples.
Just uncomment the line (https://github.com/tkrajacic/swift-android-examples/blob/5ed0e14446143568370ea078fab9d387e8e6bb51/Shared/weather-lib/Package.swift#L12) that enables the feature in Package.swift and you will get lots of errors like this

[38/49] Emitting module WeatherLibrary
/Users/tkrajacic/Developer/Forks/swift-android-examples/Shared/weather-lib/.build/plugins/outputs/weather-lib/WeatherLibrary/destination/JExtractSwiftPlugin/Sources/LocationFetcher+SwiftJava.swift:20:13: error: function cannot be declared public because its parameter uses an internal type
 5 | // Generated by swift-java
 6 | 
 7 | import SwiftJava
   | `- note: type alias 'JNIEnv' imported as 'internal' from 'SwiftJava' here
 8 | import SwiftJavaJNICore
 9 | import SwiftJavaRuntimeSupport
   :
18 | #endif
19 | @_cdecl("Java_com_example_weatherlib_Location__00024init__DD")
20 | public func Java_com_example_weatherlib_Location__00024init__DD(environment: UnsafeMutablePointer<JNIEnv?>!, thisClass: jclass, latitude: jdouble, longitude: jdouble) -> jlong {
   |             |- error: function cannot be declared public because its parameter uses an internal type
   |             `- note: type alias 'JNIEnv' is imported by this file as 'internal' from 'SwiftJava'
21 |   let result$ = UnsafeMutablePointer<Location>.allocate(capacity: 1)
22 |   result$.initialize(to: Location.init(latitude: Double(fromJNI: latitude, in: environment), longitude: Double(fromJNI: longitude, in: environment)))

/Users/tkrajacic/Library/org.swift.swiftpm/swift-sdks/swift-6.3-RELEASE_android.artifactbundle/swift-android/ndk-sysroot/usr/include/jni.h:142:42: note: type declared here
 140 | typedef _JavaVM JavaVM;
 141 | #else
 142 | typedef const struct JNINativeInterface* JNIEnv;
     |                                          `- note: type declared here
 143 | typedef const struct JNIInvokeInterface* JavaVM;
 144 | #endif