v0.2.0 — Fix Claude Code porting issues - #14
Conversation
Closes #7 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: striderZA <striderZA@users.noreply.github.com>
|
Here is my full review of this PR. Review: v0.2.0 — Fix Claude Code porting issuesOverview5 commits, 100 files changed, 8201 additions / 8198 deletions. The PR addresses 5 porting issues (CCGS → OpenCode). The CI workflow changes and most skill-file replacements are correct. However, there are several incomplete replacements and a noisy mixed-purpose commit. Issue 1: Mixed line-ending normalization in commit
|
| File | Lines |
|---|---|
.opencode/agents/game-designer.md |
62, 67, 76 |
.opencode/agents/creative-director.md |
157, 162, 171 |
.opencode/agents/technical-director.md |
60, 65, 74 |
.opencode/agents/producer.md |
60, 65, 74 |
.opencode/agents/art-director.md |
61, 66, 75 |
.opencode/agents/audio-director.md |
61, 66, 75 |
.opencode/agents/narrative-director.md |
61, 66, 75 |
.opencode/agents/level-designer.md |
61, 66, 75 |
.opencode/agents/systems-designer.md |
61, 66, 75 |
.opencode/agents/economy-designer.md |
61, 66, 75 |
.opencode/agents/ux-designer.md |
56, 61, 70 |
.opencode/agents/live-ops-designer.md |
54, 59, 68 |
.opencode/agents/world-builder.md |
61, 66, 75 |
.opencode/agents/writer.md |
65, 67 |
Impact: If AskUserQuestion is not a valid OpenCode tool, these agents will fail at runtime when they try to invoke it.
Recommendation: Replace AskUserQuestion with question in all agent files, or expand the scope of issue #4.
Issue 3: .claude/ still in quick-start.md line 267 🐛
Claimed fix: #5 — Replace .claude/ path references with .opencode/
Reality: The file structure diagram at .opencode/docs/quick-start.md:267 still shows:
.claude/
settings.json
agents/ (was 48 agents)
skills/ (was 68 skills)
hooks/
rules/
This should be .opencode/ with updated structure description.
Recommendation: Update the ASCII directory tree in quick-start.md.
Issue 4: WebSearch still in setup-engine/SKILL.md and godot-specialist.md 🐛
Claimed fix: #7 — Replace WebSearch with webfetch (1 brainstorm skill)
Reality: Only brainstorm/SKILL.md was fixed. Remaining references:
.opencode/skills/setup-engine/SKILL.md— 8 references includingdescriptionfrontmatter,allowed-toolsfrontmatter, and 6 functional uses (lines 121, 419, 429, 452, 574, 578).opencode/agents/godot-specialist.md— 1 reference (line 172)
Impact: setup-engine skill will try to call a non-existent WebSearch tool.
Recommendation: Fix all WebSearch → webfetch references across skills and agents, or at minimum scope the issue accurately.
Issue 5: Claude model names still in coordination-rules.md 🐛
Claimed fix: #6 — Replace Claude model names with OpenCode model IDs (11 skill files)
Reality: .opencode/docs/coordination-rules.md:21-23 still references:
| Haiku | claude-haiku-4-5-20251001 | ...
| Sonnet | claude-sonnet-4-6 | ...
| Opus | claude-opus-4-6 | ...
Recommendation: Replace with OpenCode model IDs, or document that tier-to-model mapping is now done differently.
Issue 6: .opencode/docs/ contains .claude/ references in other files mentioned in changed file list
The following docs in .opencode/docs/ were listed as changed files but still have issues:
quick-start.mdline 267 —.claude/not replaced (Issue 3 above)quick-start.mdL20 mentions "Opus", L29 mentions "Sonnet/Haiku" — Claude model tier naming
Positive notes
- CI workflow fixes (
opencode-review.yml,opencode.yml): Addingpersist-credentials: trueand explicittoken: ${{ secrets.GITHUB_TOKEN }}is correct. Without this, GITHUB_TOKEN is not available to subsequent steps. - 39 skill files had
AskUserQuestion→questioncorrectly replaced. - Agent tool references (Write/Edit → write/edit) correctly updated across all 46 agent files.
- 11 skill files had Claude model names correctly replaced.
Summary
| Severity | Count | Description |
|---|---|---|
| 🚨 High | 1 | Mixed line-ending + semantic change in one commit |
| 🐛 Medium | 4 | Incomplete replacements (AskUserQuestion in 14 agents, .claude/ in quick-start, WebSearch in 2 files, Claude models in coordination-rules) |
| ✅ Good | 4 | CI fix, skill tool renames, agent tool casing, most model renames |
Verdict: NEEDS REVISION — address the 4 incomplete replacements and split the noisy commit before merging.
Review: v0.2.0 — Fix Claude Code porting issues100 files changed · 8204 insertions · 8201 deletions · 6 commits Issues Fixed by Later Commits
Issues Still Open🔴 1. Noisy commit
|
PR Review: v0.2.0 — Fix Claude Code porting issuesCommit
Remaining Issues (verified from source)1.
|
| Area | Status |
|---|---|
AskUserQuestion → question |
✅ Fixed across all files |
WebSearch → webfetch |
✅ Removed everywhere |
| Agent tool casing (Write/Edit → write/edit) | ✅ 46 agent files correct |
| CI workflow GITHUB_TOKEN fix | ✅ Correct |
WebFetch casing in setup-engine |
🐛 2 remaining |
.claude/ → .opencode/ paths |
🐛 2 files |
| Claude model tier names → OpenCode IDs | 🐛 2 docs |
CLAUDE.md refs → AGENTS.md |
🐛 setup-engine/SKILL.md (12 refs) |
Noisy commit 75a49bc |
🚨 line-ending normalization mixed with semantic change |
NEEDS REVISION — 5 minor but real issues remain. The easiest path: file follow-up issues for the doc/skill references and WebFetch casing, and note the commit history concern in a review comment.
|
Addressed all review items: Issue 1 (Noisy commit): Accepted. The CRLF→LF normalization was unintentional from subagent file writes. Added Issue 2 (AskUserQuestion in 14 agents): Fixed in commit Issue 3 (.claude/ in quick-start.md): Fixed — updated the file structure diagram to show Issue 4 (WebSearch remaining): Fixed — Issue 5 (Claude models in coordination-rules.md): Fixed — tier table updated with OpenCode model IDs. |
Review: v0.2.0 — Fix Claude Code porting issues100 files changed · 8237 additions · 8234 deletions · 9 commits What's Fixed ✅
Still Open 🐛1.
2.
3.
4. 5. Claude model tier labels in
6.
7. Noisy commit Verdict: APPROVED WITH FOLLOW-UP ISSUESThe functionally critical issues (runtime failures from |
|
Here's my review of PR v0.2.0: Review: v0.2.0 — Fix Claude Code porting issuesWhat's Correct ✅
What Still Needs Fixing 🐛
Things the Automated Reviewer Got Wrong 🚫The bot's second review claimed 5+ issues were still open, but most are already fixed:
VerdictNEEDS MINOR REVISION — two small fixes (camelCase |





Summary
Fixes 5 porting issues from the CCGS→OpenCode migration:
Changes
Verification