From eb8a43a4e17d47bf3d2804fff813c88473469f93 Mon Sep 17 00:00:00 2001 From: Guneet Gill Date: Thu, 9 Apr 2026 18:51:29 -0700 Subject: [PATCH 1/4] fixed linting issues --- .../include/stdlib/ndarray/base/iteration_order.h | 2 +- .../@stdlib/ndarray/base/iteration-order/src/main.c | 2 +- .../@stdlib/ndarray/base/unary-accumulate/src/dispatch.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h b/lib/node_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h index 884c2d3425d3..6c2ad43e3021 100644 --- a/lib/node_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h +++ b/lib/node_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h @@ -31,7 +31,7 @@ extern "C" { /** * Determines array iteration order, given a stride array. */ -int8_t stdlib_ndarray_iteration_order( int64_t ndims, int64_t *strides ); +int8_t stdlib_ndarray_iteration_order( int64_t ndims, const int64_t *strides ); #ifdef __cplusplus } diff --git a/lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c b/lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c index c165b73482f8..423cedad1ef4 100644 --- a/lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c +++ b/lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c @@ -43,7 +43,7 @@ * int8_t o = stdlib_ndarray_iteration_order( ndims, strides ); * // returns 1 */ -int8_t stdlib_ndarray_iteration_order( int64_t ndims, int64_t *strides ) { +int8_t stdlib_ndarray_iteration_order( int64_t ndims, const int64_t *strides ) { int64_t cnt; int64_t i; diff --git a/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c b/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c index e0ec04c456d9..eb6fb4c06f31 100644 --- a/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c +++ b/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c @@ -232,7 +232,7 @@ int8_t stdlib_ndarray_unary_accumulate_dispatch( const struct ndarrayUnaryAccumu int64_t ndims; int64_t mab1; int64_t mib1; - int64_t *s1; + const int64_t *s1; int64_t len; int64_t bp1; int8_t io1; From 9c3d4dc4fdc97830ad0084d7d57f03e7199f576b Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 9 Apr 2026 23:02:06 -0700 Subject: [PATCH 2/4] Apply suggestions from code review Co-authored-by: Athan Signed-off-by: Athan --- .../include/stdlib/ndarray/base/iteration_order.h | 2 +- .../@stdlib/ndarray/base/iteration-order/src/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/node_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h b/lib/node_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h index 6c2ad43e3021..884c2d3425d3 100644 --- a/lib/node_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h +++ b/lib/node_modules/@stdlib/ndarray/base/iteration-order/include/stdlib/ndarray/base/iteration_order.h @@ -31,7 +31,7 @@ extern "C" { /** * Determines array iteration order, given a stride array. */ -int8_t stdlib_ndarray_iteration_order( int64_t ndims, const int64_t *strides ); +int8_t stdlib_ndarray_iteration_order( int64_t ndims, int64_t *strides ); #ifdef __cplusplus } diff --git a/lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c b/lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c index 423cedad1ef4..c165b73482f8 100644 --- a/lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c +++ b/lib/node_modules/@stdlib/ndarray/base/iteration-order/src/main.c @@ -43,7 +43,7 @@ * int8_t o = stdlib_ndarray_iteration_order( ndims, strides ); * // returns 1 */ -int8_t stdlib_ndarray_iteration_order( int64_t ndims, const int64_t *strides ) { +int8_t stdlib_ndarray_iteration_order( int64_t ndims, int64_t *strides ) { int64_t cnt; int64_t i; From 2ee68aee905ca2523ac2b2be7aca1a29e8d17126 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 9 Apr 2026 23:03:41 -0700 Subject: [PATCH 3/4] style: reorder variables Signed-off-by: Athan --- .../@stdlib/ndarray/base/unary-accumulate/src/dispatch.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c b/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c index eb6fb4c06f31..88e6bf2369bc 100644 --- a/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c +++ b/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c @@ -232,7 +232,15 @@ int8_t stdlib_ndarray_unary_accumulate_dispatch( const struct ndarrayUnaryAccumu int64_t ndims; int64_t mab1; int64_t mib1; + const int64_t *sh1; + struct ndarray *x1; + struct ndarray *x2; + struct ndarray *x3; const int64_t *s1; + int8_t status; + int64_t ndims; + int64_t mab1; + int64_t mib1; int64_t len; int64_t bp1; int8_t io1; From 8ba489cb119444ab5c25e931769e54f76caa89d8 Mon Sep 17 00:00:00 2001 From: Athan Date: Thu, 9 Apr 2026 23:04:34 -0700 Subject: [PATCH 4/4] fix: remove duplicate variables Signed-off-by: Athan --- .../@stdlib/ndarray/base/unary-accumulate/src/dispatch.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c b/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c index 88e6bf2369bc..83330f55d817 100644 --- a/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c +++ b/lib/node_modules/@stdlib/ndarray/base/unary-accumulate/src/dispatch.c @@ -224,14 +224,6 @@ static int8_t stdlib_ndarray_unary_accumulate_1d_flatten( const ndarrayUnaryAccu * } */ int8_t stdlib_ndarray_unary_accumulate_dispatch( const struct ndarrayUnaryAccumulateDispatchObject *obj, struct ndarray *arrays[], void *fcn ) { - const int64_t *sh1; - struct ndarray *x1; - struct ndarray *x2; - struct ndarray *x3; - int8_t status; - int64_t ndims; - int64_t mab1; - int64_t mib1; const int64_t *sh1; struct ndarray *x1; struct ndarray *x2;