From fd32a833ee3100d41a319c563a123ddb26d13512 Mon Sep 17 00:00:00 2001 From: Jan Obernberger Date: Mon, 1 Jun 2026 13:42:30 +0200 Subject: [PATCH 1/2] fix(secretsmanager): remove RequiresReplace for secretsmanager description --- stackit/internal/services/secretsmanager/user/resource.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/stackit/internal/services/secretsmanager/user/resource.go b/stackit/internal/services/secretsmanager/user/resource.go index 31777fafe..32268b56a 100644 --- a/stackit/internal/services/secretsmanager/user/resource.go +++ b/stackit/internal/services/secretsmanager/user/resource.go @@ -142,9 +142,6 @@ func (r *userResource) Schema(_ context.Context, _ resource.SchemaRequest, resp "description": schema.StringAttribute{ Description: descriptions["description"], Required: true, - PlanModifiers: []planmodifier.String{ - stringplanmodifier.RequiresReplace(), - }, }, "write_enabled": schema.BoolAttribute{ Description: descriptions["write_enabled"], @@ -415,7 +412,8 @@ func toUpdatePayload(model *Model) (*secretsmanager.UpdateUserPayload, error) { return nil, fmt.Errorf("nil model") } return &secretsmanager.UpdateUserPayload{ - Write: conversion.BoolValueToPointer(model.WriteEnabled), + Description: conversion.StringValueToPointer(model.Description), + Write: conversion.BoolValueToPointer(model.WriteEnabled), }, nil } From 299bb11c5b810275b078a1d86fa5045a7ae48836 Mon Sep 17 00:00:00 2001 From: Jan Obernberger Date: Wed, 3 Jun 2026 15:48:26 +0200 Subject: [PATCH 2/2] fix(secretsmanager): add user description change to acc test, add user description to unit test --- .../services/secretsmanager/secretsmanager_acc_test.go | 1 + .../internal/services/secretsmanager/user/resource_test.go | 7 +++++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/stackit/internal/services/secretsmanager/secretsmanager_acc_test.go b/stackit/internal/services/secretsmanager/secretsmanager_acc_test.go index 0583be16a..9a69655aa 100644 --- a/stackit/internal/services/secretsmanager/secretsmanager_acc_test.go +++ b/stackit/internal/services/secretsmanager/secretsmanager_acc_test.go @@ -62,6 +62,7 @@ func configVarsMaxUpdated() config.Variables { tempConfig["write_enabled"] = config.BoolVariable(false) tempConfig["use_kms_key"] = config.BoolVariable(false) tempConfig["acl2"] = config.StringVariable("10.100.2.0/24") + tempConfig["user_description"] = config.StringVariable("tf-acc-" + acctest.RandStringFromCharSet(8, acctest.CharSetAlpha)) return tempConfig } diff --git a/stackit/internal/services/secretsmanager/user/resource_test.go b/stackit/internal/services/secretsmanager/user/resource_test.go index 4471e6a04..38c2df602 100644 --- a/stackit/internal/services/secretsmanager/user/resource_test.go +++ b/stackit/internal/services/secretsmanager/user/resource_test.go @@ -234,17 +234,20 @@ func TestToUpdatePayload(t *testing.T) { "default_values", &Model{}, &secretsmanager.UpdateUserPayload{ - Write: nil, + Description: nil, + Write: nil, }, true, }, { "simple_values", &Model{ + Description: types.StringValue(""), WriteEnabled: types.BoolValue(false), }, &secretsmanager.UpdateUserPayload{ - Write: new(false), + Description: new(""), + Write: new(false), }, true, },