Skip to content

Commit b19e40e

Browse files
committed
chore(logs): align acl type with create command
1 parent 344ee78 commit b19e40e

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

internal/cmd/logs/instance/update/update.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ type inputModel struct {
3535
InstanceID string
3636
DisplayName *string
3737
RetentionDays *int32
38-
ACL *[]string
38+
ACL []string
3939
Description *string
4040
}
4141

@@ -121,7 +121,7 @@ func parseInput(p *print.Printer, cmd *cobra.Command, inputArgs []string) (*inpu
121121

122122
displayName := flags.FlagToStringPointer(p, cmd, displayNameFlag)
123123
retentionDays := flags.FlagToInt32Pointer(p, cmd, retentionDaysFlag)
124-
acl := flags.FlagToStringSlicePointer(p, cmd, aclFlag)
124+
acl := flags.FlagToStringSliceValue(p, cmd, aclFlag)
125125
description := flags.FlagToStringPointer(p, cmd, descriptionFlag)
126126

127127
if displayName == nil && retentionDays == nil && acl == nil && description == nil {
@@ -146,7 +146,7 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *logs.APICli
146146

147147
req = req.UpdateLogsInstancePayload(logs.UpdateLogsInstancePayload{
148148
DisplayName: model.DisplayName,
149-
Acl: utils.PtrValue(model.ACL),
149+
Acl: model.ACL,
150150
RetentionDays: model.RetentionDays,
151151
Description: model.Description,
152152
})

internal/cmd/logs/instance/update/update_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ func fixtureInputModel(mods ...func(model *inputModel)) *inputModel {
6565
},
6666
InstanceID: testInstanceId,
6767
DisplayName: utils.Ptr("name"),
68-
ACL: utils.Ptr([]string{"0.0.0.0/0"}),
68+
ACL: []string{"0.0.0.0/0"},
6969
RetentionDays: utils.Ptr(int32(60)),
7070
Description: utils.Ptr("Example"),
7171
}
@@ -159,7 +159,7 @@ func TestParseInput(t *testing.T) {
159159
},
160160
InstanceID: testInstanceId,
161161
DisplayName: utils.Ptr("display-name"),
162-
ACL: utils.Ptr([]string{"0.0.0.0/24"}),
162+
ACL: []string{"0.0.0.0/24"},
163163
RetentionDays: utils.Ptr(int32(60)),
164164
Description: utils.Ptr("description"),
165165
},

0 commit comments

Comments
 (0)