chore(opensearch): remove stale opensearchclient interface and fix swapped region and instanceid args

relates to STACKITTCLI-372

Author: SerseusWasTaken

internal/pkg/services/opensearch/utils/utils.go

@@ -62,21 +62,16 @@ func LoadPlanId(planName, version string, offerings *opensearch.ListOfferingsRes
 	}
 }
 
-type OpenSearchClient interface {
-	GetInstance(ctx context.Context, projectId, region, instanceId string) opensearch.ApiGetInstanceRequest
-	GetCredentials(ctx context.Context, projectId, region, instanceId, credentialsId string) opensearch.ApiGetCredentialsRequest
-}
-
-func GetInstanceName(ctx context.Context, apiClient OpenSearchClient, projectId, region, instanceId string) (string, error) {
+func GetInstanceName(ctx context.Context, apiClient opensearch.DefaultAPI, projectId, region, instanceId string) (string, error) {
 	resp, err := apiClient.GetInstance(ctx, projectId, region, instanceId).Execute()
 	if err != nil {
 		return "", fmt.Errorf("get OpenSearch instance: %w", err)
 	}
 	return resp.Name, nil
 }
 
-func GetCredentialsUsername(ctx context.Context, apiClient OpenSearchClient, projectId, region, instanceId, credentialsId string) (string, error) {
-	resp, err := apiClient.GetCredentials(ctx, projectId, instanceId, region, credentialsId).Execute()
+func GetCredentialsUsername(ctx context.Context, apiClient opensearch.DefaultAPI, projectId, region, instanceId, credentialsId string) (string, error) {
+	resp, err := apiClient.GetCredentials(ctx, projectId, region, instanceId, credentialsId).Execute()
 	if err != nil {
 		return "", fmt.Errorf("get OpenSearch credentials: %w", err)
 	}

internal/pkg/services/opensearch/utils/utils_test.go

@@ -13,12 +13,12 @@ import (
 
 var (
 	testProjectId     = uuid.NewString()
-	testRegion        = "eu01"
 	testInstanceId    = uuid.NewString()
 	testCredentialsId = uuid.NewString()
 )
 
 const (
+	testRegion              = "eu01"
 	testInstanceName        = "instance"
 	testCredentialsUsername = "username"
 )