From 592335f3633fa96bb857a558deb54edc567708eb Mon Sep 17 00:00:00 2001
From: Lars Francke <jujutsu@lars-francke.de>
Date: Tue, 21 Jul 2026 14:59:17 +0200
Subject: [PATCH] fix(java-devel): Apply Maven retry settings under connector.*
 keys used by Maven 3.9

#1584 added HTTP retry settings (retryHandler.count/interval/intervalMax) under the aether.transport.http.* keys. That prefix is the maven-resolver 2.x / Maven 4 spelling; we build with Maven 3.9.16 (maven-resolver 1.9.27), which only reads aether.connector.http.*, so those settings currently have no effect.

Add the connector.* spelling alongside the transport.* one so the retries actually apply today, mirroring how connectionMaxTtl is already dual-spelled.

CI Maven failures are connection-level (stale keep-alive connections dropped by the network; no server-side 5xx in Nexus/Apache logs). maven-resolver's retry handler retries these IOExceptions, so this makes the intended retry behaviour effective. Key names verified against ConfigurationProperties.java @ maven-resolver-1.9.27.
---
 java-devel/stackable/settings.xml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/java-devel/stackable/settings.xml b/java-devel/stackable/settings.xml
index 4f68e1319..49910d34b 100644
--- a/java-devel/stackable/settings.xml
+++ b/java-devel/stackable/settings.xml
@@ -58,22 +58,34 @@
         <!-- New name: maven-resolver 2.x, as of Maven 4.x -->
         <aether.transport.http.connectionMaxTtl>25</aether.transport.http.connectionMaxTtl>
 
+        <!--
+        As with connectionMaxTtl above, the retry keys were renamed between maven-resolver 1.x
+        (aether.connector.http.*) and 2.x (aether.transport.http.*).
+        At the time of writing we were building with a version of Maven that requires the old ("connector") properties.
+        The "transport" keys are here for Maven 4.
+        Verified against ConfigurationProperties.java @ maven-resolver-1.9.27.
+        It does not hurt to keep both sets in here.
+        -->
+
         <!--
         By default, requests are retried 3 times. We increase the count slightly to hopefully get less failing
         builds in CI.
         -->
+        <aether.connector.http.retryHandler.count>5</aether.connector.http.retryHandler.count>
         <aether.transport.http.retryHandler.count>5</aether.transport.http.retryHandler.count>
 
         <!--
         By default, retries wait for 5000 milliseconds (5 seconds). We increase this to 10000 milliseconds
         (10 seconds) to spam the Nexus instance a little less.
         -->
+        <aether.connector.http.retryHandler.interval>10000</aether.connector.http.retryHandler.interval>
         <aether.transport.http.retryHandler.interval>10000</aether.transport.http.retryHandler.interval>
 
         <!--
         Servers can respond with `Retry-After` headers. By default, the value is capped at 300000 milliseconds (300
         seconds). We reduce this to 60000 (60 seconds) to avoid super long retry intervals.
         -->
+        <aether.connector.http.retryHandler.intervalMax>60000</aether.connector.http.retryHandler.intervalMax>
         <aether.transport.http.retryHandler.intervalMax>60000</aether.transport.http.retryHandler.intervalMax>
 
         <!--