Skip to content

Commit 3048d1f

Browse files
authored
Merge pull request #7 from sqlstack-io/fix/remove-hero-github-cta
fix: remove homepage hero GitHub CTA
2 parents ca2a2e9 + 8eff6d0 commit 3048d1f

3 files changed

Lines changed: 7 additions & 15 deletions

File tree

‎index.html‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,6 @@
5555
<h1 id="headline"><span>Your data stack.</span> <span>Engineered to change.</span></h1>
5656
<p class="lede">Rust-backed SQL and Python tools for data engineers.</p>
5757
<p class="principles">Compile-time checks, tested behaviour and enforceable architecture.</p>
58-
<div class="hero-actions">
59-
<a class="button" href="https://github.com/sqlstack-io/sqlstack">View on GitHub <span aria-hidden="true">↗</span></a>
60-
</div>
6158
</section>
6259

6360
<div id="tools" tabindex="-1" aria-label="SQLStack tools">

‎styles.css‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
--background: #ffffff;
2424
--panel: #ffffff;
2525
--focus: #1768ba;
26-
--button-border: #bdc9da;
27-
--button-hover: #f3f6fa;
2826
--gold-ink: #765600;
2927
--gold-bg: #fff3cb;
3028
--pink-ink: #a52138;
@@ -45,8 +43,6 @@
4543
--background: #0d0f12;
4644
--panel: #171a1f;
4745
--focus: #75b5ff;
48-
--button-border: #626a76;
49-
--button-hover: #171a1f;
5046
--gold-ink: #ffe07a;
5147
--gold-bg: #352b12;
5248
--pink-ink: #ffacba;
@@ -90,9 +86,6 @@ h1 { margin: 0; font-size: clamp(40px, 4.2vw, 64px); line-height: 1; letter-spac
9086
h1 span { display: block; }
9187
.lede { margin: 20px 0 3px; font-size: 22px; line-height: 1.4; }
9288
.principles { margin: 0; color: var(--muted); font-size: 16px; line-height: 1.5; }
93-
.hero-actions { display: flex; justify-content: center; flex-wrap: wrap; gap: 12px; margin-top: 20px; }
94-
.button { display: inline-flex; align-items: center; justify-content: center; gap: 8px; padding: 14px 20px; min-height: 48px; border: 1px solid var(--button-border); border-radius: 2px; color: var(--ink); font-size: 14px; line-height: 20px; text-decoration: none; }
95-
.button:hover { background: var(--button-hover); text-decoration: none; }
9689
.tool-row { display: grid; grid-template-columns: 304px minmax(0, 1fr); gap: 24px; border-top: 1px solid var(--line); padding: 18px 0 16px; }
9790
.category { padding-top: 8px; }
9891
.category .eyebrow { margin: 0 0 8px; color: var(--muted); font-size: 14px; line-height: 20px; text-transform: uppercase; }
@@ -142,8 +135,6 @@ h3 { margin: 0; font-family: "Space Grotesk", sans-serif; font-size: 24.94308px;
142135
h1 { font-size: clamp(34px, 8.5vw, 48px); line-height: 1.07; letter-spacing: -.05em; }
143136
.lede { margin-top: 20px; font-size: 18px; }
144137
.principles { margin-top: 10px; font-size: 15px; }
145-
.hero-actions { gap: 10px; }
146-
.button { padding-inline: 16px; }
147138
.cards { grid-template-columns: minmax(0, 1fr); gap: 16px; }
148139
.category > p:last-child { margin-top: 8px; }
149140
.product { gap: 20px; padding: 22px 18px 18px; }

‎tests/website.spec.mjs‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@ test('approved products, sharing assets and responsive navigation work in both t
4949
await page.goto('/');
5050
await expect(page.getByRole('heading', { level: 3 })).toHaveText(names);
5151
await expect(page.getByRole('link', { name: 'SQLStack on GitHub', exact: true })).toHaveAttribute('href', 'https://github.com/sqlstack-io');
52+
for (const [name, website] of [['SQLBuild', 'https://sqlbuild.com'], ['SQLTide', 'https://sqltide.io/'], ['SQLClean', 'https://sqlclean.io'], ['Fensu', 'https://fensu.io/']]) {
53+
const card = page.getByRole('article', { name, exact: true });
54+
await expect(card.getByRole('link', { name: `${name} website`, exact: true })).toHaveAttribute('href', website);
55+
await expect(card.getByRole('link', { name: `${name} on GitHub`, exact: true })).toHaveAttribute('href', `https://github.com/sqlstack-io/${name.toLowerCase()}`);
56+
}
5257
await expect(page.getByText('Compile-time checks, tested behaviour and enforceable architecture.', { exact: true })).toBeVisible();
5358
await expect(page.locator('footer')).toContainText('Independent tools. Shared foundations. 100% open source.');
5459
const fensuWebsite = page.getByRole('article', { name: 'Fensu', exact: true }).getByRole('link', { name: 'Fensu website', exact: true });
@@ -73,9 +78,8 @@ test('approved products, sharing assets and responsive navigation work in both t
7378
await expect(sqltideWebsite).toBeVisible();
7479
await expect(page.getByRole('button', { name: 'Dark mode', exact: true })).toBeInViewport();
7580
}
76-
await expect(page.locator('.hero').getByRole('link')).toHaveCount(1);
77-
await expect(page.locator('.hero').getByRole('link')).toHaveAccessibleName('View on GitHub');
78-
await expect(page.locator('.hero').getByRole('link')).toHaveAttribute('href', 'https://github.com/sqlstack-io/sqlstack');
81+
await expect(page.locator('.hero').getByRole('link')).toHaveCount(0);
82+
await expect(page.getByRole('link', { name: 'View on GitHub', exact: true })).toHaveCount(0);
7983
await page.getByRole('link', { name: 'Skip to tools', exact: true }).focus();
8084
await page.keyboard.press('Enter');
8185
await expect(page).toHaveURL(/#tools$/);

0 commit comments

Comments
 (0)