Fix Clone() in Query.

[cemahseri]

Fixes: #747

[Copilot]

Pull Request Overview

This PR fixes the Clone() method in the Query class to perform deep cloning instead of shallow cloning, addressing issue #747. The fix ensures that nested objects like Parent queries and Includes are properly cloned rather than sharing references.

• Implements deep cloning for Parent query references
• Adds proper cloning for Includes collection with new Clone() method
• Creates independent copy of Variables dictionary

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
QueryBuilder/Query.cs	Updates Clone() method to deep clone Parent, Includes, and Variables properties
QueryBuilder/Include.cs	Adds new Clone() method to enable deep cloning of Include objects

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[ahmad-moussawi]

@cemahseri the PR is failing to build

[cemahseri]

copilot is high on k2/spice, don't trust it. the pr builds just fine

1>------ Build started: Project: QueryBuilder, Configuration: Release Any CPU ------
1>QueryBuilder -> C:\Windows\System32\querybuilder\QueryBuilder\bin\Release\net8.0\SqlKata.Core.dll
2>------ Build started: Project: SqlKata.Execution, Configuration: Release Any CPU ------
2>SqlKata.Execution -> C:\Windows\System32\querybuilder\SqlKata.Execution\bin\Release\net8.0\SqlKata.Execution.dll
3>------ Build started: Project: QueryBuilder.Tests, Configuration: Release Any CPU ------
3>QueryBuilder.Tests -> C:\Windows\System32\querybuilder\QueryBuilder.Tests\bin\Release\net8.0\QueryBuilder.Tests.dll
========== Build: 3 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

[ahmad-moussawi]

copilot is high on k2/spice, don't trust it. the pr builds just fine

1>------ Build started: Project: QueryBuilder, Configuration: Release Any CPU ------
1>QueryBuilder -> C:\Windows\System32\querybuilder\QueryBuilder\bin\Release\net8.0\SqlKata.Core.dll
2>------ Build started: Project: SqlKata.Execution, Configuration: Release Any CPU ------
2>SqlKata.Execution -> C:\Windows\System32\querybuilder\SqlKata.Execution\bin\Release\net8.0\SqlKata.Execution.dll
3>------ Build started: Project: QueryBuilder.Tests, Configuration: Release Any CPU ------
3>QueryBuilder.Tests -> C:\Windows\System32\querybuilder\QueryBuilder.Tests\bin\Release\net8.0\QueryBuilder.Tests.dll
========== Build: 3 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

I was trying to build it locally but maybe I was missing something, I will try again tonight

[ahmad-moussawi]

There was a recent PR inspired by this one that addresses this issue with a similar one related to the XQuery (coauthored with copilot)
so I will close this one now.

Thanks @cemahseri for the contribution

[cemahseri]

you are welcome!

so the ai did basically what i did, but slightly worse. but hey, it added the unit test!
the problem with current fix is, the parent is still not shallow copied;

querybuilder/QueryBuilder/Query.cs

Line 54 in 5122d43

clone.Parent = Parent;

it means that if i clone a query and make changes to the parent query of the copied query, the original query's parent query will also be changed