Permit fully-qualified refs in concise annotation attribute check

Closes gh-452

Author: wilkinsona

spring-javaformat/spring-javaformat-checkstyle/src/main/java/io/spring/javaformat/checkstyle/check/SpringAnnotationAttributeConciseValueCheck.java

@@ -99,7 +99,7 @@ private void visitValueExpression(DetailAST valueExpression, DetailAST annotatio
 			return;
 		}
 		List<String> expressionComponents = dotSeparatedComponents(valueExpression.getFirstChild());
-		if (expressionComponents == null || expressionComponents.size() <= 2) {
+		if (expressionComponents == null || expressionComponents.size() <= 2 || fullyQualifiedTypeName(expressionComponents)) {
 			return;
 		}
 		String outerTypeName = expressionComponents.get(0);
@@ -136,6 +136,10 @@ private List<String> dotSeparatedComponents(DetailAST ast) {
 		return null;
 	}
 
+	private boolean fullyQualifiedTypeName(List<String> expressionComponents) {
+		return Character.isLowerCase(expressionComponents.get(0).charAt(0));
+	}
+
 	private boolean existingClashingImport(String outer, String inner) {
 		return this.imports.stream().filter((imported) -> imported.clashesWith(outer, inner)).findFirst().isPresent();
 	}

spring-javaformat/spring-javaformat-checkstyle/src/test/resources/check/AnnotationAttributeWithValueThatHasFullyQualifiedReferenceToContainedEnumValue.txt

@@ -0,0 +1 @@
++0 errors

spring-javaformat/spring-javaformat-checkstyle/src/test/resources/source/AnnotationAttributeWithValueThatHasFullyQualifiedReferenceToContainedEnumValue.java

@@ -0,0 +1,20 @@
+/*
+ * Copyright 2017-present the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+@ConditionalOnWebApplicationType(com.example.ConditionalOnWebApplicationType.WebApplicationType.SERVLET)
+public class AnnotationAttributeWithValueThatHasFullyQualifiedReferenceToContainedEnumValue {
+
+}