fix(config): preserve portsAttributes.protocol and requireLocalPort (spec)

The spec's PortAttributes object (containers.dev json_reference /
devContainer.base.schema.json) defines five properties: label, protocol
(http|https), onAutoForward, requireLocalPort, elevateIfNeeded. The Go PortAttrs
struct only had three, so protocol and requireLocalPort were silently dropped on
parse — read-configuration and the devcontainer.metadata label lost them, even
though the CLI just needs to pass them through to the editor.

Add both fields (covering portsAttributes and otherPortsAttributes). imagemeta
already stores portsAttributes as an untyped map, so the metadata path preserves
them automatically. Verified via read-configuration round-trip; locked by
TestPortAttrsSpecFields. No behavior change for configs without these fields, so
parity is unaffected.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: aledbf

internal/config/types.go

@@ -74,11 +74,17 @@ type Build struct {
 	Options    []string          `json:"options,omitempty"`
 }
 
-// PortAttrs represents port attribute configuration.
+// PortAttrs represents port attribute configuration. Fields mirror the spec's
+// PortAttributes object (containers.dev json_reference): label, protocol
+// (http|https), onAutoForward, requireLocalPort, elevateIfNeeded. The CLI does
+// not act on these (port forwarding is the editor's job) but must preserve them
+// through read-configuration and the devcontainer.metadata label.
 type PortAttrs struct {
-	Label           string `json:"label,omitempty"`
-	OnAutoForward   string `json:"onAutoForward,omitempty"`
-	ElevateIfNeeded *bool  `json:"elevateIfNeeded,omitempty"`
+	Label            string `json:"label,omitempty"`
+	Protocol         string `json:"protocol,omitempty"`
+	OnAutoForward    string `json:"onAutoForward,omitempty"`
+	RequireLocalPort *bool  `json:"requireLocalPort,omitempty"`
+	ElevateIfNeeded  *bool  `json:"elevateIfNeeded,omitempty"`
 }
 
 // HostRequirements specifies minimum host resources.

internal/config/types_test.go

@@ -2,6 +2,7 @@ package config
 
 import (
 	"encoding/json"
+	"strings"
 	"testing"
 
 	"github.com/devcontainers/cli/internal/jsonc"
@@ -269,3 +270,50 @@ func TestParseFixture_WithJSONC(t *testing.T) {
 }
 
 func intPtr(i int) *int { return &i }
+
+// TestPortAttrsSpecFields locks all five spec-defined portsAttributes properties
+// (label, protocol, onAutoForward, requireLocalPort, elevateIfNeeded) through a
+// parse → re-marshal round-trip. protocol and requireLocalPort were previously
+// dropped, silently losing them from read-configuration and the metadata label.
+func TestPortAttrsSpecFields(t *testing.T) {
+	const input = `{
+		"image": "ubuntu",
+		"portsAttributes": {
+			"3000": {"label": "app", "protocol": "https", "onAutoForward": "notify", "requireLocalPort": true, "elevateIfNeeded": false}
+		},
+		"otherPortsAttributes": {"onAutoForward": "ignore", "protocol": "http"}
+	}`
+
+	var c DevContainer
+	if err := json.Unmarshal([]byte(input), &c); err != nil {
+		t.Fatal(err)
+	}
+
+	pa, ok := c.PortsAttributes["3000"]
+	if !ok {
+		t.Fatal("portsAttributes[3000] missing")
+	}
+	if pa.Label != "app" || pa.Protocol != "https" || pa.OnAutoForward != "notify" {
+		t.Errorf("scalars = %+v", pa)
+	}
+	if pa.RequireLocalPort == nil || !*pa.RequireLocalPort {
+		t.Errorf("requireLocalPort = %v, want true", pa.RequireLocalPort)
+	}
+	if pa.ElevateIfNeeded == nil || *pa.ElevateIfNeeded {
+		t.Errorf("elevateIfNeeded = %v, want false", pa.ElevateIfNeeded)
+	}
+	if c.OtherPortsAttributes == nil || c.OtherPortsAttributes.Protocol != "http" {
+		t.Errorf("otherPortsAttributes = %+v", c.OtherPortsAttributes)
+	}
+
+	// Re-marshal must preserve protocol and requireLocalPort (the regression).
+	out, err := json.Marshal(c)
+	if err != nil {
+		t.Fatal(err)
+	}
+	for _, want := range []string{`"protocol":"https"`, `"requireLocalPort":true`} {
+		if !strings.Contains(string(out), want) {
+			t.Errorf("re-marshaled config dropped %s: %s", want, out)
+		}
+	}
+}