feat(config/linux): add Beta Flatpak Spotify Path for Spicetify detection#3850
Open
Bossiskeyboard wants to merge 5 commits into
Open
feat(config/linux): add Beta Flatpak Spotify Path for Spicetify detection#3850Bossiskeyboard wants to merge 5 commits into
Bossiskeyboard wants to merge 5 commits into
Conversation
📝 WalkthroughWalkthroughAdds two Flatpak beta directory entries (system and user locations) to the Linux app's Spotify installation candidate list for discovery. ChangesLinux Flatpak Beta Path Support
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/utils/config.go (1)
313-313: ⚡ Quick winAdd trailing slash for consistency.
All other paths in
potentialListend with a trailing slash. Whilefilepath.Joinhandles this correctly, maintaining the pattern improves consistency.📝 Proposed fix
- "/var/lib/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify", + "/var/lib/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/utils/config.go` at line 313, The string in the potentialList slice (the Spotify path entry) lacks a trailing slash while all other entries include one; update the literal "/var/lib/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify" in the potentialList declaration in src/utils/config.go to include a trailing "/" for consistency with the rest of the list and to match how other paths are formatted.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/utils/config.go`:
- Line 313: The Flatpak paths slice in config.go currently includes a user-level
stable path but is missing the corresponding user-level beta path; update the
list of Spotify install paths (the slice/variable that holds Flatpak paths in
src/utils/config.go) to add the user-level beta Flatpak entry
$HOME/.local/share/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify
so user-installed Flatpak beta installs are auto-detected (ensure you add it
alongside the existing user-level stable and system-level beta/stable entries).
---
Nitpick comments:
In `@src/utils/config.go`:
- Line 313: The string in the potentialList slice (the Spotify path entry) lacks
a trailing slash while all other entries include one; update the literal
"/var/lib/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify"
in the potentialList declaration in src/utils/config.go to include a trailing
"/" for consistency with the rest of the list and to match how other paths are
formatted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7072fafd-3d6f-4c0c-b752-0c58d642be24
📒 Files selected for processing (1)
src/utils/config.go
There was a problem hiding this comment.
♻️ Duplicate comments (1)
src/utils/config.go (1)
313-313:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMissing user-level Flatpak beta path.
Line 312 includes a user-level stable Flatpak path, but no corresponding user-level beta path is added. Users who install Spotify Flatpak beta at the user level won't be auto-detected.
➕ Suggested addition
"/var/lib/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/", + "$HOME/.local/share/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/", "$HOME/.local/share/spotify-launcher/install/usr/share/spotify/",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/utils/config.go` at line 313, The Flatpak paths slice in src/utils/config.go includes a user-level stable entry but is missing the equivalent user-level beta path, so add the user-level Flatpak beta install path (the user-home equivalent of the system beta path already present) to the same slice of Flatpak install paths; mirror the pattern used for the existing user-level stable entry so the beta installation under the user account is auto-detected.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@src/utils/config.go`:
- Line 313: The Flatpak paths slice in src/utils/config.go includes a user-level
stable entry but is missing the equivalent user-level beta path, so add the
user-level Flatpak beta install path (the user-home equivalent of the system
beta path already present) to the same slice of Flatpak install paths; mirror
the pattern used for the existing user-level stable entry so the beta
installation under the user account is auto-detected.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7a96b502-7504-4de6-b79d-ebd81672de71
📒 Files selected for processing (1)
src/utils/config.go
There was a problem hiding this comment.
♻️ Duplicate comments (1)
src/utils/config.go (1)
311-311:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMissing user-level beta Flatpak path.
The system-level beta path is added, but the corresponding user-level beta path (
$HOME/.local/share/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/) is missing. Users who install Spotify Flatpak beta at the user level won't be auto-detected.For consistency with the stable channel (which includes both system-level at line 312 and user-level at line 313), the beta channel should also support both installation scopes.
➕ Suggested addition
"/var/lib/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/", "/var/lib/flatpak/app/com.spotify.Client/x86_64/stable/active/files/extra/share/spotify/", "$HOME/.local/share/flatpak/app/com.spotify.Client/x86_64/stable/active/files/extra/share/spotify/", + "$HOME/.local/share/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/", "$HOME/.local/share/spotify-launcher/install/usr/share/spotify/",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/utils/config.go` at line 311, The beta Flatpak system path entry "/var/lib/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/" is present but the corresponding user-level beta path is missing; update the list of Spotify/Flatpak paths (the slice in config.go that contains the beta entry) to also include the user-level beta path "$HOME/.local/share/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/" (mirror how the stable channel includes both system and user paths) so user-scoped Flatpak beta installs are auto-detected.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@src/utils/config.go`:
- Line 311: The beta Flatpak system path entry
"/var/lib/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/"
is present but the corresponding user-level beta path is missing; update the
list of Spotify/Flatpak paths (the slice in config.go that contains the beta
entry) to also include the user-level beta path
"$HOME/.local/share/flatpak/app/com.spotify.Client/x86_64/beta/active/files/extra/share/spotify/"
(mirror how the stable channel includes both system and user paths) so
user-scoped Flatpak beta installs are auto-detected.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9b08395f-586a-4923-bf57-8eca0f868270
📒 Files selected for processing (1)
src/utils/config.go
Bossiskeyboard
changed the title
Bossiskeyboard
changed the title
Contributor
Author
|
that should be it and i hope this helps someone out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit