refactor: directplay and dplobby redirect to dplay.h and dplobby.h, include dplobby.h#83
Merged
Merged
Conversation
TheRedDaemon
requested changes
May 22, 2026
TheRedDaemon
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we forgot dplobby.h. I added it to dependencies from the same source as you took the other ones from.
The only objects left in OpenSHC/DirectPlay/ are helper enums. All the other header-imitating objects are in Ghidra in subdir dplay/ and dplobby/ and excluded from ghidra export into this repo as we get those from the two header files instead.
Also points to proper source for IN_ADDR, which is WinSock.h instead of inaddr.h
Resolves issues in #72