feat(themes): New Theme Selector

ennerperez · ennerperez · commit bb7eef200f43 · 2026-08-06T20:56:44.000-05:00
diff --git a/src/App.axaml.cs b/src/App.axaml.cs
@@ -1,5 +1,6 @@
 using System;
 using System.IO;
+using System.Linq;
 using System.Net.Http;
 using System.Text.Json;
 using System.Threading.Tasks;
@@ -14,6 +15,7 @@
 using Avalonia.Platform;
 using Avalonia.Styling;
 using Avalonia.Threading;
+using SourceGit.Models;
 
 namespace SourceGit
 {
@@ -117,17 +119,21 @@ app.Resources[finalLocaleKey] is not ResourceDictionary targetLocale ||
             app._activeLocale = targetLocale;
         }
 
-        public static void SetTheme(string theme, string themeOverridesFile)
+        public static void SetTheme(ThemeOverrides theme)
         {
             if (Current is not App app)
                 return;
 
-            if (theme.Equals("Light", StringComparison.OrdinalIgnoreCase))
+            string themeOverridesFile = string.Empty;
+
+            if (theme.Name.Equals("Light", StringComparison.OrdinalIgnoreCase))
                 app.RequestedThemeVariant = ThemeVariant.Light;
-            else if (theme.Equals("Dark", StringComparison.OrdinalIgnoreCase))
+            else if (theme.Name.Equals("Dark", StringComparison.OrdinalIgnoreCase))
                 app.RequestedThemeVariant = ThemeVariant.Dark;
-            else
+            else if (theme.Name.Equals("Default", StringComparison.OrdinalIgnoreCase))
                 app.RequestedThemeVariant = ThemeVariant.Default;
+            else
+                themeOverridesFile = theme.FilePath;
 
             if (app._themeOverrides != null)
             {
@@ -243,7 +249,7 @@ public override void Initialize()
 
             var pref = ViewModels.Preferences.Instance;
             SetLocale(pref.Locale);
-            SetTheme(pref.Theme, pref.ThemeOverrides);
+            SetTheme(pref.Themes.FirstOrDefault(m=> m.Name == pref.Theme) ?? new ThemeOverrides("Default"));
             SetFonts(pref.DefaultFontFamily, pref.MonospaceFontFamily);
         }
 
diff --git a/src/Models/ThemeOverrides.cs b/src/Models/ThemeOverrides.cs
@@ -5,9 +5,23 @@ namespace SourceGit.Models
 {
     public class ThemeOverrides
     {
+        public ThemeOverrides()
+        {
+            
+        }
+
+        public ThemeOverrides(string name)
+        {
+            Name = name;
+        }
+        public string Version { get; set; }
+        public string Name { get; set; }
+        public string Author { get; set; }
+        public string Url { get; set; }
         public Dictionary<string, Color> BasicColors { get; set; } = new Dictionary<string, Color>();
         public double GraphPenThickness { get; set; } = 2;
         public double OpacityForNotMergedCommits { get; set; } = 0.5;
         public List<Color> GraphColors { get; set; } = new List<Color>();
+        public string FilePath { get; set; }
     }
 }
diff --git a/src/ViewModels/Preferences.cs b/src/ViewModels/Preferences.cs
@@ -1,11 +1,14 @@
 using System;
 using System.Collections.Generic;
+using System.Collections.ObjectModel;
 using System.IO;
+using System.Linq;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 using System.Threading.Tasks;
 using Avalonia.Collections;
 using CommunityToolkit.Mvvm.ComponentModel;
+using SourceGit.Models;
 
 namespace SourceGit.ViewModels
 {
@@ -41,26 +44,33 @@ public string Locale
             }
         }
 
-        public string Theme
+        [JsonIgnore]
+        public List<ThemeOverrides> Themes
         {
-            get => _theme;
+            get => _themes;
             set
             {
-                if (SetProperty(ref _theme, value) && !_isLoading)
-                    App.SetTheme(_theme, _themeOverrides);
+                SetProperty(ref _themes, value);
             }
         }
 
-        public string ThemeOverrides
+        [JsonIgnore]
+        public ThemeOverrides SelectedTheme
         {
-            get => _themeOverrides;
+            get
+            {
+                return Themes.FirstOrDefault(m => m.Name == Theme) ?? new ThemeOverrides("Default");
+            }
             set
             {
-                if (SetProperty(ref _themeOverrides, value) && !_isLoading)
-                    App.SetTheme(_theme, value);
+                if (SetProperty(ref _selectedTheme, value) && !_isLoading)
+                    App.SetTheme(_selectedTheme);
+                Theme = _selectedTheme.Name;
             }
         }
-
+        
+        public string Theme { get; set; }
+        
         public string DefaultFontFamily
         {
             get => _defaultFontFamily;
@@ -566,10 +576,7 @@ public RepositoryNode FindOrAddNodeByRepositoryPath(string repo, RepositoryNode
             {
                 node = new RepositoryNode()
                 {
-                    Id = normalized,
-                    Name = Path.GetFileName(normalized),
-                    Bookmark = 0,
-                    IsRepository = true,
+                    Id = normalized, Name = Path.GetFileName(normalized), Bookmark = 0, IsRepository = true,
                 };
 
                 AddNode(node, parent, save);
@@ -649,6 +656,25 @@ public void Save()
 
         private static Preferences Load()
         {
+            try
+            {
+                var themesPath = Path.Combine(Native.OS.DataDir, "themes");
+                var themeFiles = Directory.GetFiles(themesPath, "theme.json", SearchOption.AllDirectories);
+                foreach (var file in themeFiles)
+                {
+                    using var stream = File.OpenRead(file);
+                    var theme = JsonSerializer.Deserialize(stream, JsonCodeGen.Default.ThemeOverrides);
+                    if (theme == null)
+                        continue;
+                    theme.FilePath = file;
+                    _themes.Add(theme);
+                }
+            }
+            catch
+            {
+                // ignored
+            }
+
             var path = Path.Combine(Native.OS.DataDir, "preference.json");
             if (!File.Exists(path))
                 return new Preferences();
@@ -791,7 +817,8 @@ private bool RemoveInvalidRepositoriesRecursive(List<RepositoryNode> collection)
         private bool _isLoading = true;
         private bool _isReadonly = true;
         private string _locale = "en_US";
-        private string _theme = "Default";
+        private ThemeOverrides _selectedTheme = new("Default");
+        private static List<ThemeOverrides> _themes = new() { new ThemeOverrides("Default"), new ThemeOverrides("Dark"), new ThemeOverrides("Light") };
         private string _themeOverrides = string.Empty;
         private string _defaultFontFamily = string.Empty;
         private string _monospaceFontFamily = string.Empty;
diff --git a/src/Views/Preferences.axaml b/src/Views/Preferences.axaml
@@ -193,19 +193,31 @@
                        Text="{DynamicResource Text.Preferences.Appearance.Theme}"
                        HorizontalAlignment="Right"
                        Margin="0,0,16,0"/>
-            <ComboBox Grid.Row="0" Grid.Column="1"
-                      MinHeight="28"
-                      Padding="8,0"
-                      HorizontalAlignment="Stretch"
-                      DisplayMemberBinding="{Binding Key, x:DataType=ThemeVariant}"
-                      SelectedItem="{Binding Theme, Mode=TwoWay, Converter={x:Static c:StringConverters.ToTheme}}">
-              <ComboBox.Items>
-                <ThemeVariant>Default</ThemeVariant>
-                <ThemeVariant>Dark</ThemeVariant>
-                <ThemeVariant>Light</ThemeVariant>
-              </ComboBox.Items>
-            </ComboBox>
-
+            <Grid Grid.Row="0" Grid.Column="1">
+              <Grid.ColumnDefinitions>
+                <ColumnDefinition Width="*" />
+                <ColumnDefinition Width="28" /> 
+                <ColumnDefinition Width="28" />
+              </Grid.ColumnDefinitions>
+              <ComboBox Grid.Column="0" Grid.Row="0" MinHeight="28"
+                        HorizontalContentAlignment="Stretch" HorizontalAlignment="Stretch"
+                        Padding="8,0"
+                        ItemsSource="{Binding Themes, Mode=OneWay}"
+                        SelectedItem="{Binding SelectedTheme, Mode=TwoWay}">
+                <ComboBox.ItemTemplate>
+                  <DataTemplate x:DataType="{x:Type m:ThemeOverrides}">
+                    <TextBlock Text="{Binding Name, Mode=OneWay}"/>
+                  </DataTemplate>
+                </ComboBox.ItemTemplate>
+              </ComboBox>
+              <Button Grid.Column="1" Grid.Row="0" Classes="icon_button" Width="28" Height="28" Click="OpenThemeRepository">
+                <Path Width="14" Height="14" Data="{StaticResource Icons.Remotes}" Fill="{DynamicResource Brush.FG1}"/>
+              </Button>
+              <Button Grid.Column="2" Grid.Row="0" Classes="icon_button" Width="28" Height="28" Click="OpenThemeFolder">
+                <Path Width="14" Height="14" Data="{StaticResource Icons.Folder.Open}" Fill="{DynamicResource Brush.FG1}"/>
+              </Button>
+            </Grid>
+            
             <TextBlock Grid.Row="1" Grid.Column="0"
                        Text="{DynamicResource Text.Preferences.Appearance.DefaultFont}"
                        HorizontalAlignment="Right"
@@ -270,27 +282,6 @@
                              Value="{Binding EditorTabWidth, Mode=TwoWay}"/>
             </Grid>
 
-            <TextBlock Grid.Row="5" Grid.Column="0"
-                       Text="{DynamicResource Text.Preferences.Appearance.ThemeOverrides}"
-                       HorizontalAlignment="Right"
-                       Margin="0,0,16,0"/>
-            <TextBox Grid.Row="5" Grid.Column="1"
-                     Height="28"
-                     CornerRadius="3"
-                     Text="{Binding ThemeOverrides, Mode=TwoWay}">
-              <TextBox.InnerRightContent>
-                <StackPanel Orientation="Horizontal">
-                  <Button Classes="icon_button" Width="28" Height="28" Click="SelectThemeOverrideFile">
-                    <Path Width="16" Height="16" Data="{StaticResource Icons.Folder.Open}" Margin="0,2,0,0" Fill="{DynamicResource Brush.FG1}"/>
-                  </Button>
-
-                  <Button Classes="icon_button" Width="28" Height="28" Click="OpenThemeRepository">
-                    <Path Width="14" Height="14" Data="{StaticResource Icons.Remotes}" Fill="{DynamicResource Brush.FG1}"/>
-                  </Button>
-                </StackPanel>
-              </TextBox.InnerRightContent>
-            </TextBox>
-
             <CheckBox Grid.Row="6" Grid.Column="1"
                       Height="32"
                       Content="{DynamicResource Text.Preferences.Appearance.UseFixedTabWidth}"
diff --git a/src/Views/Preferences.axaml.cs b/src/Views/Preferences.axaml.cs
@@ -1,7 +1,7 @@
 using System;
 using System.Collections.Generic;
+using System.IO;
 using System.Threading.Tasks;
-
 using Avalonia;
 using Avalonia.Controls;
 using Avalonia.Interactivity;
@@ -226,42 +226,32 @@ protected override async void OnClosing(WindowClosingEventArgs e)
             preferences.Save();
         }
 
-        private async void SelectThemeOverrideFile(object _, RoutedEventArgs e)
+        private void OpenThemeRepository(object _, RoutedEventArgs e)
         {
-            var options = new FilePickerOpenOptions()
-            {
-                FileTypeFilter = [new FilePickerFileType("Theme Overrides File") { Patterns = ["*.json"] }],
-                AllowMultiple = false,
-            };
+            Native.OS.OpenBrowser($"https://github.com/sourcegit-scm/sourcegit-theme");
+            e.Handled = true;
+        }
 
+        private async void OpenThemeFolder(object _, RoutedEventArgs e)
+        {
+            var themesPath = Path.Combine(Native.OS.DataDir, "themes");
             try
             {
-                var selected = await StorageProvider.OpenFilePickerAsync(options);
-                if (selected is { Count: 1 })
-                    ViewModels.Preferences.Instance.ThemeOverrides = selected[0].Path.LocalPath;
+                if (!Directory.Exists(themesPath)) Directory.CreateDirectory(themesPath);
+                Native.OS.OpenInFileManager(themesPath);
             }
-            catch (Exception ex)
+            catch
             {
-                await new Alert().ShowAsync(this, $"Failed to select theme override file: {ex.Message}", true);
+                // Ignore
             }
 
             e.Handled = true;
         }
 
-        private void OpenThemeRepository(object _, RoutedEventArgs e)
-        {
-            Native.OS.OpenBrowser($"https://github.com/sourcegit-scm/sourcegit-theme");
-            e.Handled = true;
-        }
-
         private async void SelectGitExecutable(object _, RoutedEventArgs e)
         {
             var pattern = OperatingSystem.IsWindows() ? "git.exe" : "git";
-            var options = new FilePickerOpenOptions()
-            {
-                FileTypeFilter = [new FilePickerFileType("Git Executable") { Patterns = [pattern] }],
-                AllowMultiple = false,
-            };
+            var options = new FilePickerOpenOptions() { FileTypeFilter = [new FilePickerFileType("Git Executable") { Patterns = [pattern] }], AllowMultiple = false, };
 
             try
             {
@@ -309,11 +299,7 @@ private async void SelectGPGExecutable(object _, RoutedEventArgs e)
             else
                 patterns.Add(GPGFormat.Program);
 
-            var options = new FilePickerOpenOptions()
-            {
-                FileTypeFilter = [new FilePickerFileType("GPG Program") { Patterns = patterns }],
-                AllowMultiple = false,
-            };
+            var options = new FilePickerOpenOptions() { FileTypeFilter = [new FilePickerFileType("GPG Program") { Patterns = patterns }], AllowMultiple = false, };
 
             try
             {
@@ -339,11 +325,7 @@ private async void SelectShellOrTerminal(object _, RoutedEventArgs e)
             var options = new FilePickerOpenOptions() { AllowMultiple = false };
             if (shell.Type != "custom")
             {
-                options = new FilePickerOpenOptions()
-                {
-                    FileTypeFilter = [new FilePickerFileType(shell.Name) { Patterns = [shell.Exec] }],
-                    AllowMultiple = false,
-                };
+                options = new FilePickerOpenOptions() { FileTypeFilter = [new FilePickerFileType(shell.Name) { Patterns = [shell.Exec] }], AllowMultiple = false, };
             }
 
             try
@@ -371,11 +353,7 @@ private async void SelectExternalMergeTool(object _, RoutedEventArgs e)
             }
 
             var tool = Models.ExternalMerger.Supported[type];
-            var options = new FilePickerOpenOptions()
-            {
-                FileTypeFilter = [new FilePickerFileType(tool.Name) { Patterns = tool.GetPatternsToFindExecFile() }],
-                AllowMultiple = false,
-            };
+            var options = new FilePickerOpenOptions() { FileTypeFilter = [new FilePickerFileType(tool.Name) { Patterns = tool.GetPatternsToFindExecFile() }], AllowMultiple = false, };
 
             try
             {
@@ -449,11 +427,7 @@ private void OnAddCustomAction(object sender, RoutedEventArgs e)
 
         private async void SelectExecutableForCustomAction(object sender, RoutedEventArgs e)
         {
-            var options = new FilePickerOpenOptions()
-            {
-                AllowMultiple = false,
-                FileTypeFilter = [new("Executable file(script)") { Patterns = ["*"] }]
-            };
+            var options = new FilePickerOpenOptions() { AllowMultiple = false, FileTypeFilter = [new("Executable file(script)") { Patterns = ["*"] }] };
 
             try
             {

Original file line number	Diff line number	Diff line change
`@@ -5,9 +5,23 @@ namespace SourceGit.Models`
`5`	`5`	`{`
`6`	`6`	`public class ThemeOverrides`
`7`	`7`	`{`
	`8`	`+ public ThemeOverrides()`
	`9`	`+ {`
	`10`	`+`
	`11`	`+ }`
	`12`	`+`
	`13`	`+ public ThemeOverrides(string name)`
	`14`	`+ {`
	`15`	`+ Name = name;`
	`16`	`+ }`
	`17`	`+ public string Version { get; set; }`
	`18`	`+ public string Name { get; set; }`
	`19`	`+ public string Author { get; set; }`
	`20`	`+ public string Url { get; set; }`
`8`	`21`	`public Dictionary<string, Color> BasicColors { get; set; } = new Dictionary<string, Color>();`
`9`	`22`	`public double GraphPenThickness { get; set; } = 2;`
`10`	`23`	`public double OpacityForNotMergedCommits { get; set; } = 0.5;`
`11`	`24`	`public List<Color> GraphColors { get; set; } = new List<Color>();`
	`25`	`+ public string FilePath { get; set; }`
`12`	`26`	`}`
`13`	`27`	`}`