fix: add explicit empty permissions to deploy-railway.yml#1132
Merged
fix: add explicit empty permissions to deploy-railway.yml#1132
Conversation
Add permissions: {} at the workflow level to explicitly deny all GitHub
token permissions, following the principle of least privilege. This
workflow only needs RAILWAY_TOKEN and has no use for GitHub token access.
Fixes the CodeQL actions/missing-workflow-permissions alert #27.
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdded explicit empty Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
permissions: {}at the workflow level indeploy-railway.ymlto explicitly deny all GitHub token permissions. This follows the principle of least privilege since the workflow only needsRAILWAY_TOKENand has no use for GitHub token access.Problem
The
deploy-railway.ymlworkflow was flagged by CodeQL (actions/missing-workflow-permissions- Alert #27) because it runs without declaring explicit GitHub token permissions. Without an explicitpermissions:block, the job inherits the repository's or organization's default token permissions, which may include broad scopes likecontents: writeandpull-requests: write.Solution
Added
permissions: {}at the workflow level to explicitly deny all GitHub token permissions, reducing the attack surface if the workflow were ever compromised.References
Fixes #929
Linear Issue: SOU-929
Summary by CodeRabbit