Skip to content

Remind user that cre_settings changes might involve re-proposing job-specs#2129

Merged
george-dorin merged 7 commits into
mainfrom
ci-action-settings-override
Jun 9, 2026
Merged

Remind user that cre_settings changes might involve re-proposing job-specs#2129
george-dorin merged 7 commits into
mainfrom
ci-action-settings-override

Conversation

@yashnevatia

Copy link
Copy Markdown
Contributor

Requires

Supports

Copilot AI review requested due to automatic review settings June 5, 2026 11:36
@yashnevatia yashnevatia requested a review from a team as a code owner June 5, 2026 11:36
@yashnevatia yashnevatia marked this pull request as draft June 5, 2026 11:36
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

CRE settings touched

This PR changes files under pkg/settings/.

If the settings schema changed (new/renamed/removed fields or different defaults), before merge:

  1. Check chainlink-deployments for existing overrides on the affected fields (e.g. domains/cre/*/settings/*.toml).
  2. Whenever this change goes live,
  • Update any deployment TOMLs that still reference changed fields.
  • Plan to re-propose jobs with the updated settings TOMLs.

Test-only changes under pkg/settings/ can ignore this.

Comment thread .github/workflows/cre-settings-schema-reminder.yml Fixed
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-common

View full report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts CRE default settings for Aptos chain writes and adds an automated GitHub Actions reminder to flag PRs that touch CRE settings schema files.

Changes:

  • Increase the default Aptos ChainWrite.ReportSizeLimit from 5kb to 6kb.
  • Add a PR-commenting workflow that triggers when files under pkg/settings/cresettings/** change to remind authors to check downstream deployment overrides.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
pkg/settings/cresettings/settings.go Updates the Aptos chain write report size default in the CRE settings schema.
.github/workflows/cre-settings-schema-reminder.yml Adds a PR reminder workflow to highlight potential schema/default-impacting changes under pkg/settings/cresettings/**.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 214 to 216
Aptos: aptosChainWrite{
ReportSizeLimit: Size(5 * config.KByte),
ReportSizeLimit: Size(6 * config.KByte),
GasLimit: PerChainSelector(Uint64(2_000_000), map[string]uint64{}),
Comment thread .github/workflows/cre-settings-schema-reminder.yml
Comment thread .github/workflows/cre-settings-schema-reminder.yml Outdated
Comment thread .github/workflows/cre-settings-schema-reminder.yml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

CRE settings touched

This PR changes files under pkg/settings/cresettings/.
If the settings schema changed (new/renamed/removed fields or different defaults), before merge:

  1. Check chainlink-deployments for existing overrides on the affected fields (e.g. domains/cre/*/settings/*.toml).
  2. Whenever this change goes live,
  • Update any deployment TOMLs that still reference changed fields.
  • Plan to re-propose jobs with the updated settings TOMLs.

Test-only changes under pkg/settings/ can ignore this.

…ontractkit/chainlink-common into ci-action-settings-override
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

CRE settings touched

This PR changes files under pkg/settings/cresettings/.
If the settings schema changed (new/renamed/removed fields or different defaults), before merge:

  1. Check chainlink-deployments for existing overrides on the affected fields (e.g. domains/cre/*/settings/*.toml).
  2. Whenever this change goes live,
  • Update any deployment TOMLs that still reference changed fields.
  • Plan to re-propose jobs with the updated settings TOMLs.

@yashnevatia yashnevatia changed the title Test CI Remind user that cre_settings changes might involve re-proposing job-specs Jun 5, 2026
Comment thread .github/workflows/cre-settings-schema-reminder.yml
@yashnevatia yashnevatia closed this Jun 5, 2026
@yashnevatia yashnevatia reopened this Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

CRE settings field deprecated

This PR adds // Deprecated in pkg/settings/cresettings/settings.go.

When making the corresponding capabilities change (where this settings field is consumed), keep the change backward compatible — the new code should still respect the old field.

Rollout:

  1. Ship the capability change that reads both old and new fields.
  2. After the release is live, propose job specs in chainlink-deployments using the new schema (check domains/cre/*/settings/*.toml for existing overrides on the deprecated field).
  3. In a subsequent release, remove the old field from the capability code.

1 similar comment
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

CRE settings field deprecated

This PR adds // Deprecated in pkg/settings/cresettings/settings.go.

When making the corresponding capabilities change (where this settings field is consumed), keep the change backward compatible — the new code should still respect the old field.

Rollout:

  1. Ship the capability change that reads both old and new fields.
  2. After the release is live, propose job specs in chainlink-deployments using the new schema (check domains/cre/*/settings/*.toml for existing overrides on the deprecated field).
  3. In a subsequent release, remove the old field from the capability code.

Comment thread .github/workflows/cre-settings-schema-reminder.yml Outdated
Co-authored-by: Jordan Krage <jmank88@gmail.com>
Comment thread pkg/settings/cresettings/settings.go Outdated
@yashnevatia yashnevatia marked this pull request as ready for review June 8, 2026 13:51
@george-dorin george-dorin added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit ad25dc2 Jun 9, 2026
33 checks passed
@george-dorin george-dorin deleted the ci-action-settings-override branch June 9, 2026 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants