fix(resource): fix resource view disappearing on ats by TheodoreSpeaks · Pull Request #4103 · simstudioai/sim

TheodoreSpeaks · 2026-04-11T00:39:47Z

Summary

Atting a resource, then sending the message would cause the resource to disappear from the right temporarily. Also the symbol for the icon didn't show up until the chat streaming began.

Changed icon rendering to be persisted earlier and cleared resource context to prevent removing resource.

Type of Change

Testing

Validated resources no longer disappear.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

vercel · 2026-04-11T00:39:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 11, 2026 0:39am

cursor · 2026-04-11T00:39:55Z

PR Summary

Medium Risk
Updates client-side chat caching and context-reset behavior, which could affect message/resource UI state during sends but is limited in scope and isolated to the frontend.

Overview
Fixes a UI regression where attached resources briefly disappeared (and mention icons lagged) when sending a message.

useChat.sendMessage now includes selected contexts in the optimistic React Query cache update for the pending user message and avoids persisting the transient streaming-file resource into cached chat history. UserInput also resets its previous-context tracking ref on submit to prevent context-removal side effects when clearing contexts.

^{Reviewed by Cursor Bugbot for commit 03c7b94. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-04-11T00:53:05Z

Greptile Summary

This PR fixes two related symptoms in the @-mention resource flow: the resource panel disappearing briefly after a message is sent, and the mention-chip icon not rendering until streaming began. Both were caused by the same root bug — clearContexts() in handleSubmit triggered the selectedContexts effect, which compared the cleared list against prevSelectedContextsRef.current (still holding the submitted contexts), detected them as "removed", and called onContextRemove → removeResource for each one. The fix presets prevSelectedContextsRef.current = [] synchronously before clearContexts(), so the effect sees no delta and skips the spurious remove calls.

Confidence Score: 5/5

Safe to merge — targeted, minimal fix that closes the spurious removeResource call path without introducing new state invariants.

Single-line insertion that correctly exploits the existing ref-before-effect pattern. All edge cases behave correctly.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/home/components/user-input/user-input.tsx	Core fix: prevSelectedContextsRef.current = [] is now reset before clearContexts() in handleSubmit, preventing the selectedContexts effect from firing spurious onContextRemove calls when a message is submitted.
apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts	No functional changes detected; resource/icon lifecycle via addResource, effectiveActiveResourceId, and ensureWorkflowInRegistry is unchanged.

Sequence Diagram

sequenceDiagram
    participant U as User
    participant UI as UserInput (handleSubmit)
    participant CTX as useContextManagement
    participant EFFECT as selectedContexts effect
    participant HOME as home.tsx (handleContextRemove)
    participant CHAT as use-chat.ts (removeResource)

    U->>UI: Press Enter / click Send
    UI->>CTX: clearContexts()
    Note over UI,CTX: BUG (before fix): prevSelectedContextsRef still=[workflowCtx]
    CTX-->>EFFECT: selectedContexts becomes []
    EFFECT->>EFFECT: prev=[workflowCtx], curr=[], removed=[workflowCtx]
    EFFECT->>HOME: onContextRemove(workflowCtx)
    HOME->>CHAT: removeResource('workflow', id)
    CHAT-->>UI: panel collapses / icon gone

    Note over UI,CTX: FIX: prevSelectedContextsRef.current=[] BEFORE clearContexts()
    UI->>UI: prevSelectedContextsRef.current = []
    UI->>CTX: clearContexts()
    CTX-->>EFFECT: selectedContexts becomes []
    EFFECT->>EFFECT: prev=[], curr=[], removed=[] — nothing to do
    Note over UI,CHAT: Resource stays in panel, icon stays visible

_{Reviews (1): Last reviewed commit: "fix(resource): fix resource view disappe..." | Re-trigger Greptile}

…yping, file write/patch/append tools, timing issues (#4090) * fix build error * improvement(mothership): new agent loop (#3920) * feat(transport): replace shared chat transport with mothership-stream module * improvement(contracts): regenerate contracts from go * feat(tools): add tool catalog codegen from go tool contracts * feat(tools): add tool-executor dispatch framework for sim side tool routing * feat(orchestrator): rewrite tool dispatch with catalog-driven executor and simplified resume loop * feat(orchestrator): checkpoint resume flow * refactor(copilot): consolidate orchestrator into request/ layer * refactor(mothership): reorganize lib/copilot into structured subdirectories * refactor(mothership): canonical transcript layer, dead code cleanup, type consolidation * refactor(mothership): rebase onto latest staging * refactor(mothership): rename request continue to lifecycle * feat(trace): add initial version of request traces * improvement(stream): batch stream from redis * fix(resume): fix the resume checkpoint * fix(resume): fix resume client tool * fix(subagents): subagent resume should join on existing subagent text block * improvement(reconnect): harden reconnect logic * fix(superagent): fix superagent integration tools * improvement(stream): improve stream perf * Rebase with origin dev * fix(tests): fix failing test * fix(build): fix type errors * fix(build): fix build errors * fix(build): fix type errors * feat(mothership): add cli execution * fix(mothership): fix function execute tests * Force redeploy * feat(motheship): add docx support * feat(mothership): append * Add deps * improvement(mothership): docs * File types * Add client retry logic * Fix stream reconnect * Eager tool streaming * Fix client side tools * Security * Fix shell var injection * Remove auto injected tasks * Fix 10mb tool response limit * Fix trailing leak * Remove dead tools * file/folder tools * Folder tools * Hide function code inline * Dont show internal tool result reads * Fix spacing * Auth vfs * Empty folders should show in vfs * Fix run workflow * change to node runtime * revert back to bun runtime * Fix * Appends * Remove debug logs * Patch * Fix patch tool * Temp * Checkpoint * File writes * Fix * Remove tool truncation limits * Bad hook * replace react markdown with streamdown * Checkpoitn * fix code block * fix stream persistence * temp * Fix file tools * tool joining * cleanup subagent + streaming issues * streamed text change * Tool display intetns * Fix dev * Fix tests * Fix dev * Speed up dev ci * Add req id * Fix persistence * Tool call names * fix payload accesses * Fix name * fix snapshot crash bug * fix * Fix * remove worker code * Clickable resources * Options ordering * Folder vfs * Restore and mass delete tools * Fix * lint * Update request tracing and skills and handlers * Fix editable * fix type error * Html code * fix(chat): make inline code inherit parent font size in markdown headers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * improved autolayout * durable stream for files * one more fix * POSSIBLE BREAKAGE: SCROLLING * Fixes * Fixes * Lint fix * fix(resource): fix resource view disappearing on ats (#4103) Co-authored-by: Theodore Li <theo@sim.ai> * Fixes * feat(mothership): add execution logs as a resource type Adds `log` as a first-class mothership resource type so copilot can open and display workflow execution logs as tabs alongside workflows, tables, files, and knowledge bases. - Add `log` to MothershipResourceType, all Zod enums, and VALID_RESOURCE_TYPES - Register log in RESOURCE_REGISTRY (Library icon) and RESOURCE_INVALIDATORS - Add EmbeddedLog and EmbeddedLogActions components in resource-content - Export WorkflowOutputSection from log-details for reuse in EmbeddedLog - Add log resolution branch in open_resource handler via new getLogById service - Include log id in get_workflow_logs response and extract resources from output - Exclude log from manual add-resource dropdown (enters via copilot tools only) - Regenerate copilot contracts after adding log to open_resource Go enum * Fix perf and message queueing * Fix abort * fix(ui): dont delete resource on clearing from context, set resource closed on new task (#4113) Co-authored-by: Theodore Li <theo@sim.ai> * improvement(mothership): structure sim side typing * address comments * reactive text editor tweaks * Fix file read and tool call name persistence bug * Fix code stream + create file opening resource * fix use chat race + headless trace issues * Fix type issue * Fix mothership block req lifecycle * Fix build * Move copy reqid * Fix * fix(ui): fix resource tag transition from home to task (#4132) Co-authored-by: Theodore Li <theo@sim.ai> * Fix persistence --------- Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai> Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Theodore Li <theo@sim.ai> Co-authored-by: Theodore Li <theodoreqili@gmail.com>

* fix build error * improvement(mothership): new agent loop (#3920) * feat(transport): replace shared chat transport with mothership-stream module * improvement(contracts): regenerate contracts from go * feat(tools): add tool catalog codegen from go tool contracts * feat(tools): add tool-executor dispatch framework for sim side tool routing * feat(orchestrator): rewrite tool dispatch with catalog-driven executor and simplified resume loop * feat(orchestrator): checkpoint resume flow * refactor(copilot): consolidate orchestrator into request/ layer * refactor(mothership): reorganize lib/copilot into structured subdirectories * refactor(mothership): canonical transcript layer, dead code cleanup, type consolidation * refactor(mothership): rebase onto latest staging * refactor(mothership): rename request continue to lifecycle * feat(trace): add initial version of request traces * improvement(stream): batch stream from redis * fix(resume): fix the resume checkpoint * fix(resume): fix resume client tool * fix(subagents): subagent resume should join on existing subagent text block * improvement(reconnect): harden reconnect logic * fix(superagent): fix superagent integration tools * improvement(stream): improve stream perf * Rebase with origin dev * fix(tests): fix failing test * fix(build): fix type errors * fix(build): fix build errors * fix(build): fix type errors * feat(mothership): add cli execution * fix(mothership): fix function execute tests * Force redeploy * feat(motheship): add docx support * feat(mothership): append * Add deps * improvement(mothership): docs * File types * Add client retry logic * Fix stream reconnect * Eager tool streaming * Fix client side tools * Security * Fix shell var injection * Remove auto injected tasks * Fix 10mb tool response limit * Fix trailing leak * Remove dead tools * file/folder tools * Folder tools * Hide function code inline * Dont show internal tool result reads * Fix spacing * Auth vfs * Empty folders should show in vfs * Fix run workflow * change to node runtime * revert back to bun runtime * Fix * Appends * Remove debug logs * Patch * Fix patch tool * Temp * Checkpoint * File writes * Fix * Remove tool truncation limits * Bad hook * replace react markdown with streamdown * Checkpoitn * fix code block * fix stream persistence * temp * Fix file tools * tool joining * cleanup subagent + streaming issues * streamed text change * Tool display intetns * Fix dev * Fix tests * Fix dev * Speed up dev ci * Add req id * Fix persistence * Tool call names * fix payload accesses * Fix name * fix snapshot crash bug * fix * Fix * remove worker code * Clickable resources * Options ordering * Folder vfs * Restore and mass delete tools * Fix * lint * Update request tracing and skills and handlers * Fix editable * fix type error * Html code * fix(chat): make inline code inherit parent font size in markdown headers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * improved autolayout * durable stream for files * one more fix * POSSIBLE BREAKAGE: SCROLLING * Fixes * Fixes * Lint fix * fix(resource): fix resource view disappearing on ats (#4103) Co-authored-by: Theodore Li <theo@sim.ai> * Fixes * feat(mothership): add execution logs as a resource type Adds `log` as a first-class mothership resource type so copilot can open and display workflow execution logs as tabs alongside workflows, tables, files, and knowledge bases. - Add `log` to MothershipResourceType, all Zod enums, and VALID_RESOURCE_TYPES - Register log in RESOURCE_REGISTRY (Library icon) and RESOURCE_INVALIDATORS - Add EmbeddedLog and EmbeddedLogActions components in resource-content - Export WorkflowOutputSection from log-details for reuse in EmbeddedLog - Add log resolution branch in open_resource handler via new getLogById service - Include log id in get_workflow_logs response and extract resources from output - Exclude log from manual add-resource dropdown (enters via copilot tools only) - Regenerate copilot contracts after adding log to open_resource Go enum * Fix perf and message queueing * Fix abort * fix(ui): dont delete resource on clearing from context, set resource closed on new task (#4113) Co-authored-by: Theodore Li <theo@sim.ai> * improvement(mothership): structure sim side typing * address comments * reactive text editor tweaks * Fix file read and tool call name persistence bug * Fix code stream + create file opening resource * fix use chat race + headless trace issues * Fix type issue * Fix mothership block req lifecycle * Fix build * Move copy reqid * Fix * fix(ui): fix resource tag transition from home to task (#4132) Co-authored-by: Theodore Li <theo@sim.ai> * Fix persistence * Clean code, fix bugs * Fix --------- Co-authored-by: Vikhyath Mondreti <vikhyath@simstudio.ai> Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Theodore Li <theo@sim.ai> Co-authored-by: Theodore Li <theodoreqili@gmail.com>

fix(resource): fix resource view disappearing on ats

03c7b94

TheodoreSpeaks merged commit 5f7b98d into dev Apr 11, 2026
14 checks passed

TheodoreSpeaks deleted the fix/resource-at branch April 11, 2026 00:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(resource): fix resource view disappearing on ats#4103

fix(resource): fix resource view disappearing on ats#4103
TheodoreSpeaks merged 1 commit intodevfrom
fix/resource-at

TheodoreSpeaks commented Apr 11, 2026

Uh oh!

vercel bot commented Apr 11, 2026

Uh oh!

cursor bot commented Apr 11, 2026 •

edited

Loading

Uh oh!

greptile-apps bot commented Apr 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

TheodoreSpeaks commented Apr 11, 2026

Summary

Type of Change

Testing

Checklist

Screenshots/Videos

Uh oh!

vercel bot commented Apr 11, 2026

Uh oh!

cursor bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-apps bot commented Apr 11, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Sequence Diagram

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cursor bot commented Apr 11, 2026 •

edited

Loading