fix(managed-agent): authenticate defaults API + wire up key rotation UI

Two follow-up fixes for Cursor Bugbot's most recent review.

#11 Defaults API lacks authentication
- `GET /api/managed-agent-defaults` returned every value from
  `MANAGED_AGENT_SELF_HOSTED_DEFAULTS` with no session check. Docs and
  the block copy steer deployers toward putting sandbox-scoped secrets
  there (because they never enter the client bundle at build time),
  but an unauthenticated caller could still dump the JSON.
- Fixed: route now runs `checkSessionOrInternalAuth` and returns 401
  for anonymous callers. Same-origin fetches from the block editor
  automatically carry the session cookie, so no client change needed.
- Test added: `route.test.ts` now covers the 401 unauthenticated case.

#13 `useRotateManagedAgentConnection` was unused
- The hook + PATCH route existed but nothing called them, so the only
  way to change a stored API key was delete + re-link — awkward when
  the deployer's just cycling the key.
- Wired into the settings UI:
  - New `RotateKeyModal` component (mirrors the create modal but with
    only the key field; connection name stays put) runs the same
    verify-then-save flow.
  - Added a "Rotate key" action to each connection row's
    `RowActionsMenu`, gated on `canEdit` (workspace `write`/`admin`
    tiers). Success shows a toast; errors surface inline in the modal.

Not fixed / addressed inline:
- #9 (stale labels after connection change) and #10 (empty table
  re-seeds defaults) — Bugbot re-fired these on the previous commit
  by signature-match against a static code shape. The actual fixes
  (extra sibling-dep comparison in `areSubBlockRowPropsEqual`; only
  seed when `storeValue` is null/undefined) are in place and
  functional. No change needed.
- #12 (empty table shows a phantom row) — theoretical. The table
  component's delete-row guard (`rows.length === 1`) prevents users
  from ever reaching `[]` through the UI, so the mismatch it warns
  about isn't reachable in normal use.

Author: rdematos

apps/sim/app/api/managed-agent-defaults/route.test.ts

@@ -4,8 +4,9 @@
 import { createMockRequest } from '@sim/testing'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
-const { envState } = vi.hoisted(() => ({
+const { envState, mockCheckSessionOrInternalAuth } = vi.hoisted(() => ({
   envState: { MANAGED_AGENT_SELF_HOSTED_DEFAULTS: undefined as string | undefined },
+  mockCheckSessionOrInternalAuth: vi.fn(),
 }))
 
 vi.mock('@/lib/core/config/env', () => ({
@@ -14,11 +15,22 @@ vi.mock('@/lib/core/config/env', () => ({
   }),
 }))
 
+vi.mock('@/lib/auth/hybrid', () => ({
+  checkSessionOrInternalAuth: mockCheckSessionOrInternalAuth,
+}))
+
 import { GET } from '@/app/api/managed-agent-defaults/route'
 
 describe('GET /api/managed-agent-defaults', () => {
   beforeEach(() => {
     envState.MANAGED_AGENT_SELF_HOSTED_DEFAULTS = undefined
+    mockCheckSessionOrInternalAuth.mockResolvedValue({ success: true, userId: 'user_1' })
+  })
+
+  it('returns 401 for an unauthenticated caller', async () => {
+    mockCheckSessionOrInternalAuth.mockResolvedValue({ success: false })
+    const res = await GET(createMockRequest('GET'))
+    expect(res.status).toBe(401)
   })
 
   it('returns an empty list when the env var is unset', async () => {

apps/sim/app/api/managed-agent-defaults/route.ts

@@ -1,5 +1,6 @@
 import { createLogger } from '@sim/logger'
 import { type NextRequest, NextResponse } from 'next/server'
+import { checkSessionOrInternalAuth } from '@/lib/auth/hybrid'
 import { env } from '@/lib/core/config/env'
 import { withRouteHandler } from '@/lib/core/utils/with-route-handler'
 
@@ -42,11 +43,15 @@ function readSelfHostedDefaults(): DefaultRow[] {
  * GET /api/managed-agent-defaults
  *
  * Returns the deployer-configured default rows the block picker seeds
- * into a fresh Claude Managed Agents (self-hosted) block. No auth
- * required — the response contains only default keys the deployer
- * chose to expose to their workflow authors; there is no per-user or
- * per-workspace state.
+ * into a fresh Claude Managed Agents (self-hosted) block. Authenticated
+ * because the env var may legitimately contain sandbox-scoped secrets
+ * (the whole point of moving it off `NEXT_PUBLIC_*` is that values
+ * should not be exposed to unauthenticated callers).
  */
-export const GET = withRouteHandler(async (_request: NextRequest) => {
+export const GET = withRouteHandler(async (request: NextRequest) => {
+  const authResult = await checkSessionOrInternalAuth(request, { requireWorkflowId: false })
+  if (!authResult.success || !authResult.userId) {
+    return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
+  }
   return NextResponse.json({ selfHosted: readSelfHostedDefaults() }, { status: 200 })
 })

apps/sim/app/workspace/[workspaceId]/settings/components/managed-agents/managed-agents.tsx

@@ -13,10 +13,12 @@ import { SettingsEmptyState } from '@/app/workspace/[workspaceId]/settings/compo
 import { SettingsPanel } from '@/app/workspace/[workspaceId]/settings/components/settings-panel'
 import { useSettingsSearch } from '@/app/workspace/[workspaceId]/settings/components/use-settings-search'
 import { ConnectionFormModal } from '@/app/workspace/[workspaceId]/settings/components/managed-agents/connection-form-modal'
+import { RotateKeyModal } from '@/app/workspace/[workspaceId]/settings/components/managed-agents/rotate-key-modal'
 import {
   useCreateManagedAgentConnection,
   useDeleteManagedAgentConnection,
   useManagedAgentConnections,
+  useRotateManagedAgentConnection,
 } from '@/hooks/queries/managed-agent-connections'
 
 const logger = createLogger('ManagedAgentsSettings')
@@ -34,10 +36,15 @@ export function ManagedAgents() {
   } = useManagedAgentConnections(workspaceId)
   const createConnection = useCreateManagedAgentConnection()
   const deleteConnection = useDeleteManagedAgentConnection()
+  const rotateConnection = useRotateManagedAgentConnection()
 
   const [searchTerm, setSearchTerm] = useSettingsSearch()
   const [showAddModal, setShowAddModal] = useState(false)
   const [connectionToDeleteId, setConnectionToDeleteId] = useState<string | null>(null)
+  const [connectionToRotate, setConnectionToRotate] = useState<{
+    id: string
+    name: string
+  } | null>(null)
 
   const filtered = connections.filter((c) => {
     if (!searchTerm.trim()) return true
@@ -68,6 +75,16 @@ export function ManagedAgents() {
     }
   }
 
+  const handleRotate = async (apiKey: string) => {
+    if (!connectionToRotate) return
+    await rotateConnection.mutateAsync({
+      workspaceId,
+      id: connectionToRotate.id,
+      apiKey,
+    })
+    toast.success('API key rotated')
+  }
+
   const hasConnections = connections.length > 0
   const showNoResults = searchTerm.trim() && filtered.length === 0 && hasConnections
 
@@ -137,6 +154,11 @@ export function ManagedAgents() {
                       actions={[
                         ...(canEdit
                           ? [
+                              {
+                                label: 'Rotate key',
+                                onSelect: () =>
+                                  setConnectionToRotate({ id: c.id, name: c.name }),
+                              },
                               {
                                 label: 'Remove',
                                 destructive: true,
@@ -181,6 +203,17 @@ export function ManagedAgents() {
           confirm={{ label: 'Remove', onClick: confirmDelete }}
         />
       )}
+
+      {canEdit && (
+        <RotateKeyModal
+          open={connectionToRotate !== null}
+          connectionName={connectionToRotate?.name ?? null}
+          onOpenChange={(open) => {
+            if (!open) setConnectionToRotate(null)
+          }}
+          onSubmit={handleRotate}
+        />
+      )}
     </>
   )
 }

apps/sim/app/workspace/[workspaceId]/settings/components/managed-agents/rotate-key-modal.tsx

@@ -0,0 +1,100 @@
+'use client'
+
+import { useState } from 'react'
+import {
+  ChipModal,
+  ChipModalBody,
+  ChipModalError,
+  ChipModalField,
+  ChipModalFooter,
+  ChipModalHeader,
+} from '@sim/emcn'
+import { getErrorMessage } from '@sim/utils/errors'
+
+interface RotateKeyModalProps {
+  open: boolean
+  connectionName: string | null
+  onOpenChange: (open: boolean) => void
+  onSubmit: (apiKey: string) => Promise<void>
+}
+
+/**
+ * "Rotate API key" dialog. Same verify-then-save flow as the initial
+ * link modal, but only the key field is editable — the connection name
+ * stays put. Kept separate from the create modal so the wording and the
+ * required fields match the operation the user is doing.
+ */
+export function RotateKeyModal({
+  open,
+  connectionName,
+  onOpenChange,
+  onSubmit,
+}: RotateKeyModalProps) {
+  const [apiKey, setApiKey] = useState('')
+  const [submitting, setSubmitting] = useState(false)
+  const [error, setError] = useState<string | null>(null)
+  const [prevOpen, setPrevOpen] = useState(false)
+
+  if (open !== prevOpen) {
+    setPrevOpen(open)
+    if (open) {
+      setApiKey('')
+      setError(null)
+      setSubmitting(false)
+    }
+  }
+
+  const handleSubmit = async () => {
+    const trimmedKey = apiKey.trim()
+    if (!trimmedKey) {
+      setError('Anthropic API key is required.')
+      return
+    }
+    setSubmitting(true)
+    setError(null)
+    try {
+      await onSubmit(trimmedKey)
+      onOpenChange(false)
+    } catch (err) {
+      setError(getErrorMessage(err, 'Failed to rotate the API key.'))
+    } finally {
+      setSubmitting(false)
+    }
+  }
+
+  const title = connectionName ? `Rotate key — ${connectionName}` : 'Rotate API key'
+
+  return (
+    <ChipModal open={open} onOpenChange={onOpenChange} srTitle={title} size='md'>
+      <ChipModalHeader onClose={() => onOpenChange(false)}>{title}</ChipModalHeader>
+
+      <ChipModalBody>
+        <ChipModalField
+          type='input'
+          title='New Anthropic API key'
+          value={apiKey}
+          onChange={(value) => {
+            setApiKey(value)
+            if (error) setError(null)
+          }}
+          placeholder='sk-ant-…'
+          password
+          required
+          hint='Verified against /v1/agents before saving. The old key is overwritten on success — existing workflows immediately use the new one.'
+        />
+
+        <ChipModalError>{error ?? undefined}</ChipModalError>
+      </ChipModalBody>
+
+      <ChipModalFooter
+        onCancel={() => onOpenChange(false)}
+        cancelDisabled={submitting}
+        primaryAction={{
+          label: submitting ? 'Verifying…' : 'Rotate & save',
+          onClick: handleSubmit,
+          disabled: submitting || !apiKey.trim(),
+        }}
+      />
+    </ChipModal>
+  )
+}