Skip to content

Commit f51d0e1

Browse files
committed
fix(data-drains): name the select fields for assistive tech
ChipSelect takes an aria-label that lands on its trigger button, so the four select fields no longer announce as unnamed buttons — the Datadog site plus the create view's source, cadence, and destination type. The visible SettingRow label stays; this only gives the trigger an accessible name, since ChipSelect exposes no id for htmlFor to point at.
1 parent 4848202 commit f51d0e1

2 files changed

Lines changed: 4 additions & 0 deletions

File tree

apps/sim/ee/data-drains/components/data-drain-create.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ export function DataDrainCreate({ organizationId, onBack, onCreated }: DataDrain
127127
</SettingRow>
128128
<SettingRow label='Source'>
129129
<ChipSelect
130+
aria-label='Source'
130131
value={source}
131132
onChange={(v) => setSource(v as (typeof SOURCE_TYPES)[number])}
132133
options={SOURCE_OPTIONS}
@@ -135,6 +136,7 @@ export function DataDrainCreate({ organizationId, onBack, onCreated }: DataDrain
135136
</SettingRow>
136137
<SettingRow label='Cadence'>
137138
<ChipSelect
139+
aria-label='Cadence'
138140
value={cadence}
139141
onChange={(v) => setCadence(v as (typeof CADENCE_TYPES)[number])}
140142
options={CADENCE_OPTIONS}
@@ -148,6 +150,7 @@ export function DataDrainCreate({ organizationId, onBack, onCreated }: DataDrain
148150
<div className='flex flex-col gap-4'>
149151
<SettingRow label='Type'>
150152
<ChipSelect
153+
aria-label='Destination type'
151154
value={destinationType}
152155
onChange={(v) => handleDestinationChange(v as (typeof DESTINATION_TYPES)[number])}
153156
options={DESTINATION_OPTIONS}

apps/sim/ee/data-drains/destinations/registry.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,7 @@ const datadogFormSpec: DestinationFormSpec<DatadogState> = {
277277
<>
278278
<SettingRow label='Site'>
279279
<ChipSelect
280+
aria-label='Site'
280281
value={state.site}
281282
onChange={(v) => setState({ ...state, site: v as DatadogState['site'] })}
282283
options={DATADOG_SITE_OPTIONS}

0 commit comments

Comments
 (0)