fix(rocketlane): allow clearing optional fields on update, require a user reference for time-off and placeholder assignment

Author: waleedlatif1

apps/sim/tools/rocketlane/assign_placeholders.ts

@@ -61,6 +61,9 @@ export const rocketlaneAssignPlaceholdersTool: ToolConfig<
     method: 'POST',
     headers: (params) => rocketlaneHeaders(params.apiKey),
     body: (params) => {
+      if (params.userId == null && !params.userEmailId) {
+        throw new Error('Either a user ID or a user email is required to assign a placeholder')
+      }
       const user: Record<string, unknown> = {}
       if (params.userId != null) user.userId = params.userId
       if (params.userEmailId) user.emailId = params.userEmailId

apps/sim/tools/rocketlane/create_time_off.ts

@@ -118,6 +118,9 @@ export const rocketlaneCreateTimeOffTool: ToolConfig<
     method: 'POST',
     headers: (params) => rocketlaneHeaders(params.apiKey),
     body: (params) => {
+      if (params.userId == null && !params.userEmail) {
+        throw new Error('Either a user ID or a user email is required to create a time-off')
+      }
       const user: Record<string, unknown> = {}
       if (params.userId != null) user.userId = params.userId
       if (params.userEmail) user.emailId = params.userEmail

apps/sim/tools/rocketlane/update_project.ts

@@ -153,9 +153,9 @@ export const rocketlaneUpdateProjectTool: ToolConfig<
     headers: (params) => rocketlaneHeaders(params.apiKey),
     body: (params) => {
       const body: Record<string, unknown> = {}
-      if (params.projectName) body.projectName = params.projectName
-      if (params.startDate) body.startDate = params.startDate
-      if (params.dueDate) body.dueDate = params.dueDate
+      if (params.projectName !== undefined) body.projectName = params.projectName
+      if (params.startDate !== undefined) body.startDate = params.startDate
+      if (params.dueDate !== undefined) body.dueDate = params.dueDate
       if (params.visibility) body.visibility = params.visibility
       const owner: Record<string, unknown> = {}
       if (params.ownerUserId != null) owner.userId = params.ownerUserId
@@ -168,7 +168,8 @@ export const rocketlaneUpdateProjectTool: ToolConfig<
       if (params.projectFee != null) body.projectFee = params.projectFee
       if (params.autoAllocation != null) body.autoAllocation = params.autoAllocation
       if (params.budgetedHours != null) body.budgetedHours = params.budgetedHours
-      if (params.externalReferenceId) body.externalReferenceId = params.externalReferenceId
+      if (params.externalReferenceId !== undefined)
+        body.externalReferenceId = params.externalReferenceId
       return body
     },
   },

apps/sim/tools/rocketlane/update_time_entry.ts

@@ -102,8 +102,8 @@ export const rocketlaneUpdateTimeEntryTool: ToolConfig<
         date: params.date,
         minutes: params.minutes,
       }
-      if (params.activityName) body.activityName = params.activityName
-      if (params.notes) body.notes = params.notes
+      if (params.activityName !== undefined) body.activityName = params.activityName
+      if (params.notes !== undefined) body.notes = params.notes
       if (params.billable != null) body.billable = params.billable
       if (params.categoryId != null) body.category = { categoryId: params.categoryId }
       return body