fix(storage): review round 2 — route chat authz and execution-URL detection through getStorageConfig

- getChatStorageConfig delegates to getStorageConfig('chat') (identical for
  S3/Azure, picks up the GCS general-bucket fallback instead of reading the
  raw chat config and rejecting valid chat files)
- parse route resolves the execution bucket via getStorageConfig('execution')
  for all providers, so GCS execution files in the fallback bucket are still
  recognized as our own objects

Author: waleedlatif1

apps/sim/app/api/files/authorization.test.ts

@@ -27,8 +27,7 @@ vi.mock('@/lib/uploads', () => ({
 }))
 
 vi.mock('@/lib/uploads/config', () => ({
-  BLOB_CHAT_CONFIG: {},
-  S3_CHAT_CONFIG: {},
+  getStorageConfig: vi.fn(() => ({})),
 }))
 
 vi.mock('@/lib/uploads/server/metadata', () => ({

apps/sim/app/api/files/authorization.ts

@@ -6,7 +6,6 @@ import { and, eq, isNull } from 'drizzle-orm'
 import { NextResponse } from 'next/server'
 import { getFileMetadata } from '@/lib/uploads'
 import type { StorageContext } from '@/lib/uploads/config'
-import { BLOB_CHAT_CONFIG, S3_CHAT_CONFIG } from '@/lib/uploads/config'
 import type { StorageConfig } from '@/lib/uploads/core/storage-client'
 import { getFileMetadataByKey } from '@/lib/uploads/server/metadata'
 import { inferContextFromKey } from '@/lib/uploads/utils/file-utils'
@@ -781,30 +780,6 @@ export async function assertToolFileAccess(
  * Get chat storage configuration based on current storage provider
  */
 async function getChatStorageConfig(): Promise<StorageConfig> {
-  const { USE_S3_STORAGE, USE_BLOB_STORAGE, USE_GCS_STORAGE } = await import('@/lib/uploads/config')
-
-  if (USE_BLOB_STORAGE) {
-    return {
-      containerName: BLOB_CHAT_CONFIG.containerName,
-      accountName: BLOB_CHAT_CONFIG.accountName,
-      accountKey: BLOB_CHAT_CONFIG.accountKey,
-      connectionString: BLOB_CHAT_CONFIG.connectionString,
-    }
-  }
-
-  if (USE_S3_STORAGE) {
-    return {
-      bucket: S3_CHAT_CONFIG.bucket,
-      region: S3_CHAT_CONFIG.region,
-    }
-  }
-
-  if (USE_GCS_STORAGE) {
-    const { GCS_CHAT_CONFIG } = await import('@/lib/uploads/config')
-    return {
-      bucket: GCS_CHAT_CONFIG.bucket,
-    }
-  }
-
-  return {}
+  const { getStorageConfig } = await import('@/lib/uploads/config')
+  return getStorageConfig('chat')
 }

apps/sim/app/api/files/parse/route.ts

@@ -489,28 +489,24 @@ async function handleExternalUrl(
   try {
     logger.info('Fetching external URL:', url)
 
-    const {
-      S3_EXECUTION_FILES_CONFIG,
-      BLOB_EXECUTION_FILES_CONFIG,
-      GCS_EXECUTION_FILES_CONFIG,
-      USE_S3_STORAGE,
-      USE_BLOB_STORAGE,
-      USE_GCS_STORAGE,
-    } = await import('@/lib/uploads/config')
+    const { getStorageConfig, USE_S3_STORAGE, USE_BLOB_STORAGE, USE_GCS_STORAGE } = await import(
+      '@/lib/uploads/config'
+    )
+    const executionConfig = getStorageConfig('execution')
 
     let isExecutionFile = false
     try {
       const parsedUrl = new URL(url)
 
-      if (USE_S3_STORAGE && S3_EXECUTION_FILES_CONFIG.bucket) {
-        const bucketInHost = parsedUrl.hostname.startsWith(S3_EXECUTION_FILES_CONFIG.bucket)
-        const bucketInPath = parsedUrl.pathname.startsWith(`/${S3_EXECUTION_FILES_CONFIG.bucket}/`)
+      if (USE_S3_STORAGE && executionConfig.bucket) {
+        const bucketInHost = parsedUrl.hostname.startsWith(executionConfig.bucket)
+        const bucketInPath = parsedUrl.pathname.startsWith(`/${executionConfig.bucket}/`)
         isExecutionFile = bucketInHost || bucketInPath
-      } else if (USE_BLOB_STORAGE && BLOB_EXECUTION_FILES_CONFIG.containerName) {
-        isExecutionFile = url.includes(`/${BLOB_EXECUTION_FILES_CONFIG.containerName}/`)
-      } else if (USE_GCS_STORAGE && GCS_EXECUTION_FILES_CONFIG.bucket) {
-        const bucketInHost = parsedUrl.hostname.startsWith(`${GCS_EXECUTION_FILES_CONFIG.bucket}.`)
-        const bucketInPath = parsedUrl.pathname.startsWith(`/${GCS_EXECUTION_FILES_CONFIG.bucket}/`)
+      } else if (USE_BLOB_STORAGE && executionConfig.containerName) {
+        isExecutionFile = url.includes(`/${executionConfig.containerName}/`)
+      } else if (USE_GCS_STORAGE && executionConfig.bucket) {
+        const bucketInHost = parsedUrl.hostname.startsWith(`${executionConfig.bucket}.`)
+        const bucketInPath = parsedUrl.pathname.startsWith(`/${executionConfig.bucket}/`)
         isExecutionFile = bucketInHost || bucketInPath
       }
     } catch (error) {