fix(emcn): sweep route-scoped toasts during render, not after child effects

The provider cleared route-scoped toasts from a pathname effect. Effects run
child-first, so it also swept toasts the newly rendered route had just raised:
any toast added from a child's mount effect — which is what happens whenever
that child's data is already cached — was appended and filtered out in the same
commit, before it painted.

Move the sweep into render, where it runs before children render, so only
toasts predating the navigation are cleared. Timers and heights were already
reconciled by effects keyed off `toasts`, so this stays a pure state update.

Drops the persistAcrossRoutes workaround the table lock notice needed to dodge
the bug; its tableId-keyed cleanup stays, covering embedded swaps that change
the prop without a route change.

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx

@@ -627,11 +627,6 @@ export function Table({
       const notify = action === 'status' ? toast.info : toast.warning
       blockedToastIdRef.current = notify(title, {
         description: text,
-        // The provider's route-change sweep runs after child effects, so an
-        // announcement fired on a warm-cache navigation would be cleared in the
-        // same commit it was added. These toasts belong to this view, so they
-        // opt out of the sweep and are dismissed on unmount instead.
-        persistAcrossRoutes: true,
         ...(canOpenLockSettings
           ? {
               action: { label: 'Lock settings', onClick: () => setShowLockSettings(true) },
@@ -656,10 +651,9 @@ export function Table({
     showBlockedToast('status')
   }, [tableData, userPermissions.isLoading, showBlockedToast])
 
-  // Counterpart to `persistAcrossRoutes` above: a notice must not outlive the
-  // table it describes. Keyed on `tableId` because switching tables reuses this
-  // component instead of remounting it, and the action would then target the
-  // table the user just moved to.
+  // A notice must not outlive the table it describes — its action targets
+  // whichever table is current. Keyed on `tableId` so an embedded swap that
+  // changes the prop without a route change is covered too.
   useEffect(
     () => () => {
       if (!blockedToastIdRef.current) return

packages/emcn/src/components/toast/toast.tsx

@@ -396,6 +396,29 @@ export function ToastProvider({ children }: { children?: ReactNode }) {
   const [mounted, setMounted] = useState(false)
   const timersRef = useRef(new Map<string, ReturnType<typeof setTimeout>>())
 
+  /**
+   * Clear the previous route's toasts when the route changes. Toasts flagged
+   * `persistAcrossRoutes` — global, ongoing-state notifications like the
+   * connection status — survive; page-scoped ones do not.
+   *
+   * Done during render rather than in an effect. Effects run child-first, so an
+   * effect here would also sweep toasts the newly rendered route just raised: a
+   * toast added from a child's mount effect — which is what happens whenever
+   * that child's data is already cached — would be appended and filtered out in
+   * the same commit, before it ever painted. Adjusting state during render runs
+   * before children render, so only toasts predating the navigation are cleared.
+   *
+   * Stays a pure state update: orphaned timers and measured heights are already
+   * reconciled by the effects below, which key off `toasts`.
+   */
+  const [sweptPathname, setSweptPathname] = useState(pathname)
+  if (pathname !== sweptPathname) {
+    setSweptPathname(pathname)
+    setToasts((prev) =>
+      prev.some((t) => !t.persistAcrossRoutes) ? prev.filter((t) => t.persistAcrossRoutes) : prev
+    )
+  }
+
   useEffect(() => {
     setMounted(true)
   }, [])
@@ -459,27 +482,6 @@ export function ToastProvider({ children }: { children?: ReactNode }) {
     setHeights({})
   }, [])
 
-  /**
-   * Clear only route-scoped toasts. Toasts flagged `persistAcrossRoutes` —
-   * global, ongoing-state notifications like the connection status — survive,
-   * everything else (page-scoped notifications) is cleared on navigation.
-   */
-  const dismissRouteScopedToasts = useCallback(() => {
-    setToasts((prev) => {
-      const kept = prev.filter((t) => t.persistAcrossRoutes)
-      if (kept.length === prev.length) return prev
-      for (const t of prev) {
-        if (t.persistAcrossRoutes) continue
-        const timer = timersRef.current.get(t.id)
-        if (timer) {
-          clearTimeout(timer)
-          timersRef.current.delete(t.id)
-        }
-      }
-      return kept
-    })
-  }, [])
-
   const measureToast = useCallback((id: string, height: number) => {
     setHeights((prev) => (prev[id] === height ? prev : { ...prev, [id]: height }))
   }, [])
@@ -536,11 +538,6 @@ export function ToastProvider({ children }: { children?: ReactNode }) {
     }
   }, [])
 
-  /** On navigation, clear route-scoped toasts so they don't trail the user; `persistAcrossRoutes` toasts survive. */
-  useEffect(() => {
-    dismissRouteScopedToasts()
-  }, [pathname, dismissRouteScopedToasts])
-
   /** Held in a ref (seeded once from the stable `addToast`) so the module-level `toast` binds to the live provider. */
   const toastFn = useRef<ToastFn>(createToastFn(addToast))