improvement desktop

Author: Sg312

apps/desktop/build/generated-icon.icns

@@ -44,6 +44,7 @@ function page(overrides: Partial<Page> = {}): Page {
 
 function handlers(): Handlers {
   return {
+    addToChat: vi.fn(),
     copy: vi.fn(),
     paste: vi.fn(),
     back: vi.fn(),
@@ -73,7 +74,7 @@ describe('buildAgentContextMenuTemplate', () => {
       'Reload',
       'Zoom In',
       'Zoom Out',
-      'Reset Zoom (100%)',
+      'Actual Size (100%)',
     ])
   })
 
@@ -105,6 +106,22 @@ describe('buildAgentContextMenuTemplate', () => {
     expect(labels(readOnly)).not.toContain('Paste')
   })
 
+  it('puts Add to chat first and preserves the exact nonblank selection', () => {
+    const handled = handlers()
+    const template = buildAgentContextMenuTemplate(
+      params({ selectionText: '  selected\ntext  ', linkURL: 'https://example.com/docs' }),
+      page(),
+      handled
+    )
+
+    expect(labels(template)[0]).toBe('Add to chat')
+    item(template, 'Add to chat')?.click?.({} as never, undefined as never, {} as never)
+    expect(handled.addToChat).toHaveBeenCalledWith('  selected\ntext  ')
+    expect(
+      labels(buildAgentContextMenuTemplate(params({ selectionText: ' \n ' }), page(), handlers()))
+    ).not.toContain('Add to chat')
+  })
+
   it('offers link items for http(s) targets only', () => {
     const handled = handlers()
     const template = buildAgentContextMenuTemplate(
@@ -143,7 +160,7 @@ describe('buildAgentContextMenuTemplate', () => {
     // against Chromium's native scale (where this factor would read 110%).
     const twoUp = steppedZoomFactor(steppedZoomFactor(BASE_ZOOM_FACTOR, 1), 1)
     const stepped = buildAgentContextMenuTemplate(params(), page({ zoomFactor: twoUp }), handlers())
-    expect(item(stepped, 'Reset Zoom (121%)')?.enabled).toBe(true)
+    expect(item(stepped, 'Actual Size (121%)')?.enabled).toBe(true)
 
     const atMax = buildAgentContextMenuTemplate(params(), page({ zoomFactor: 3 }), handlers())
     expect(item(atMax, 'Zoom In')?.enabled).toBe(false)
@@ -154,7 +171,7 @@ describe('buildAgentContextMenuTemplate', () => {
 
     // Nothing to reset to at 100%.
     expect(
-      item(buildAgentContextMenuTemplate(params(), page(), handlers()), 'Reset Zoom (100%)')
+      item(buildAgentContextMenuTemplate(params(), page(), handlers()), 'Actual Size (100%)')
         ?.enabled
     ).toBe(false)
   })
@@ -171,7 +188,7 @@ describe('buildAgentContextMenuTemplate', () => {
       handled
     )
 
-    item(template, 'Reset Zoom (133%)')?.click?.({} as never, undefined as never, {} as never)
+    item(template, 'Actual Size (133%)')?.click?.({} as never, undefined as never, {} as never)
 
     expect(handled.setZoomFactor).toHaveBeenCalledWith(configuredDefault)
   })
@@ -202,6 +219,7 @@ describe('attachAgentContextMenu', () => {
     const contents = new WebContentsView().webContents
     vi.mocked(contents.navigationHistory.canGoBack).mockReturnValue(true)
     attachAgentContextMenu(contents, {
+      addToChat: vi.fn(),
       openTab: vi.fn(),
       defaultZoomFactor: () => BASE_ZOOM_FACTOR,
     })

apps/desktop/src/main/browser-agent/cdp.test.ts

@@ -13,6 +13,8 @@
  * terminal's hidden textarea, the roles here act on a real page: `copy` and
  * `paste` go to the frame that was clicked.
  */
+
+import { resolveDesktopZoom } from '@sim/desktop-bridge'
 import type { ContextMenuParams, MenuItemConstructorOptions, WebContents } from 'electron'
 import { clipboard, Menu } from 'electron'
 
@@ -22,9 +24,9 @@ import { clipboard, Menu } from 'electron'
  * Chromium refuses to scale past them, and a rung outside the range would come
  * back clamped and leave the menu offering a step that never lands.
  */
-const ZOOM_STEP_RATIO = 1.1
 const MIN_ZOOM_FACTOR = 0.5
 const MAX_ZOOM_FACTOR = 3
+const ZOOM_FACTOR_BOUNDS = { min: MIN_ZOOM_FACTOR, max: MAX_ZOOM_FACTOR } as const
 
 /**
  * What the panel calls 100%.
@@ -33,14 +35,14 @@ const MAX_ZOOM_FACTOR = 3
  * it renders a rung below Chromium's native scale and treats THAT as its
  * baseline: the menu reads 100% there, and every other rung is reported
  * relative to it. New installs start there; when a user chooses a different
- * default, Reset Zoom returns to that configured percentage. The initial 100%
+ * default, Actual Size returns to that configured percentage. The initial 100%
  * is genuinely rendering at ~91% of native.
  *
  * Defined as one rung below native rather than as a round number so the ladder
  * still lands exactly on Chromium's 1.0 (the crispest rasterization, one step
  * up from the baseline) instead of straddling it.
  */
-export const BASE_ZOOM_FACTOR = 1 / ZOOM_STEP_RATIO
+export const BASE_ZOOM_FACTOR = resolveDesktopZoom(1, 'out', 1, ZOOM_FACTOR_BOUNDS)
 
 /**
  * A Chromium zoom factor as a percentage of {@link BASE_ZOOM_FACTOR} — what the
@@ -60,9 +62,12 @@ export function zoomPercentOf(factor: number): number {
  * the item rather than offer a step that does nothing.
  */
 export function steppedZoomFactor(current: number, direction: 1 | -1): number {
-  const base = Number.isFinite(current) && current > 0 ? current : BASE_ZOOM_FACTOR
-  const next = direction === 1 ? base * ZOOM_STEP_RATIO : base / ZOOM_STEP_RATIO
-  return Math.min(MAX_ZOOM_FACTOR, Math.max(MIN_ZOOM_FACTOR, next))
+  return resolveDesktopZoom(
+    current,
+    direction === 1 ? 'in' : 'out',
+    BASE_ZOOM_FACTOR,
+    ZOOM_FACTOR_BOUNDS
+  )
 }
 
 /** The parts of a right-click the menu acts on. */
@@ -80,6 +85,7 @@ interface AgentPageContext {
 }
 
 interface AgentContextMenuHandlers {
+  addToChat(text: string): void
   copy(): void
   paste(): void
   back(): void
@@ -91,6 +97,8 @@ interface AgentContextMenuHandlers {
 }
 
 export interface AgentContextMenuHost {
+  /** Attaches selected page text to the chat that owns this browser tab. */
+  addToChat(text: string): void
   /** Opens a link from the page in another tab of the same browser. */
   openTab(url: string): void
   /** Returns the device's current default page zoom factor. */
@@ -112,6 +120,14 @@ export function buildAgentContextMenuTemplate(
 ): MenuItemConstructorOptions[] {
   const template: MenuItemConstructorOptions[] = []
   const linkUrl = /^https?:\/\//i.test(params.linkURL) ? params.linkURL : ''
+  const selectionText = params.selectionText
+
+  if (selectionText.trim()) {
+    template.push(
+      { label: 'Add to chat', click: () => handlers.addToChat(selectionText) },
+      { type: 'separator' }
+    )
+  }
 
   if (linkUrl) {
     template.push(
@@ -121,7 +137,7 @@ export function buildAgentContextMenuTemplate(
     )
   }
 
-  if (params.selectionText.trim()) {
+  if (selectionText.trim()) {
     template.push({ label: 'Copy', click: () => handlers.copy() })
   }
   if (params.isEditable && params.editFlags.canPaste) {
@@ -153,7 +169,7 @@ export function buildAgentContextMenuTemplate(
       click: () => handlers.setZoomFactor(zoomOut),
     },
     {
-      label: `Reset Zoom (${zoomPercent}%)`,
+      label: `Actual Size (${zoomPercent}%)`,
       enabled: page.zoomFactor !== page.defaultZoomFactor,
       click: () => handlers.setZoomFactor(page.defaultZoomFactor),
     }
@@ -174,6 +190,7 @@ export function attachAgentContextMenu(contents: WebContents, host: AgentContext
         defaultZoomFactor: host.defaultZoomFactor(),
       },
       {
+        addToChat: (text) => host.addToChat(text),
         copy: () => contents.copy(),
         paste: () => contents.paste(),
         back: () => contents.navigationHistory.goBack(),