fix(zoho-desk): make createSubscription config failures non-retryable

createSubscription threw plain Errors (no status) for missing orgId, event type,
or credentials, and for a Zoho success with no webhook id - so the deploy outbox
mapped them to 500 and retried permanent configuration failures. Attach a 4xx
via statusError (400 for missing config/credentials; 422 for the no-id anomaly,
where a retry risks duplicate webhooks) so they fail the deploy terminally like
the mapped Zoho API 4xx responses. Tests assert the 400 status on the guard paths.

Author: mzxchandra

apps/sim/lib/webhooks/providers/zoho-desk.test.ts

@@ -83,30 +83,32 @@ describe('zohoDeskHandler', () => {
   })
 
   describe('createSubscription', () => {
-    it('throws a clear error when the organization ID is missing', async () => {
-      await expect(
-        zohoDeskHandler.createSubscription?.({
-          webhook: { providerConfig: { eventType: 'Ticket_Add' } },
+    async function captureCreateError(providerConfig: Record<string, unknown>): Promise<unknown> {
+      try {
+        await zohoDeskHandler.createSubscription?.({
+          webhook: { providerConfig },
           workflow: {},
           userId: 'user-1',
           requestId: 'test',
-          // biome-ignore lint/suspicious/noExplicitAny: request is unused on this guard path
+          // biome-ignore lint/suspicious/noExplicitAny: request is unused on these guard paths
           request: {} as any,
         })
-      ).rejects.toThrow(/Organization ID/i)
+      } catch (error) {
+        return error
+      }
+      return undefined
+    }
+
+    it('fails terminally (400) when the organization ID is missing', async () => {
+      const error = await captureCreateError({ eventType: 'Ticket_Add' })
+      expect((error as Error)?.message).toMatch(/Organization ID/i)
+      expect(errorStatus(error)).toBe(400)
     })
 
-    it('throws a clear error when the event type is missing', async () => {
-      await expect(
-        zohoDeskHandler.createSubscription?.({
-          webhook: { providerConfig: { orgId: '700123' } },
-          workflow: {},
-          userId: 'user-1',
-          requestId: 'test',
-          // biome-ignore lint/suspicious/noExplicitAny: request is unused on this guard path
-          request: {} as any,
-        })
-      ).rejects.toThrow(/event type/i)
+    it('fails terminally (400) when the event type is missing', async () => {
+      const error = await captureCreateError({ orgId: '700123' })
+      expect((error as Error)?.message).toMatch(/event type/i)
+      expect(errorStatus(error)).toBe(400)
     })
   })
 

apps/sim/lib/webhooks/providers/zoho-desk.ts

@@ -158,20 +158,30 @@ export const zohoDeskHandler: WebhookProviderHandler = {
     const orgId = typeof config.orgId === 'string' ? config.orgId : undefined
     const eventType = typeof config.eventType === 'string' ? config.eventType : undefined
 
+    // Missing configuration is permanent - carry a 4xx so the deploy outbox fails
+    // terminally (NonRetryableDeploymentError) instead of retrying a create that
+    // can never succeed without the user fixing the trigger config.
     if (!orgId) {
-      throw new Error('Zoho Desk Organization ID is required to create the webhook subscription.')
+      throw statusError(
+        'Zoho Desk Organization ID is required to create the webhook subscription.',
+        400
+      )
     }
     if (!eventType) {
-      throw new Error('A Zoho Desk event type is required to create the webhook subscription.')
+      throw statusError(
+        'A Zoho Desk event type is required to create the webhook subscription.',
+        400
+      )
     }
 
     const owner = credentialId ? await getCredentialOwner(credentialId, requestId) : null
     const accessToken = owner
       ? await refreshAccessTokenIfNeeded(owner.accountId, owner.userId, requestId)
       : null
     if (!accessToken || !owner) {
-      throw new Error(
-        'Zoho Desk account connection required. Please connect your Zoho Desk account in the trigger configuration and try again.'
+      throw statusError(
+        'Zoho Desk account connection required. Please connect your Zoho Desk account in the trigger configuration and try again.',
+        400
       )
     }
 
@@ -230,7 +240,9 @@ export const zohoDeskHandler: WebhookProviderHandler = {
     // Never persist a subscription without its id: the id is the JWT `aud` claim
     // verifyAuth checks, so an empty one would force verification to fail open.
     if (!externalId) {
-      throw new Error('Zoho Desk webhook creation succeeded but returned no webhook id')
+      // Zoho reported success but gave no id: a webhook may have been created and
+      // is unidentifiable, so retrying risks duplicates. Fail terminally (4xx).
+      throw statusError('Zoho Desk webhook creation succeeded but returned no webhook id', 422)
     }
 
     logger.info(`[${requestId}] Created Zoho Desk webhook`, { externalId })