fix(review): simplify generated document attachments

Author: j15z

apps/sim/app/api/files/serve/[...path]/route.ts

@@ -37,7 +37,7 @@ async function compileDocumentIfNeeded(
   raw: boolean,
   ownerKey: string | undefined,
   signal: AbortSignal | undefined
-): Promise<{ buffer: Buffer; contentType: string; unrendered?: boolean }> {
+): Promise<{ buffer: Buffer; contentType: string }> {
   if (raw) return { buffer, contentType: getContentType(filename) }
   return resolveServableDocBytes({
     rawBuffer: buffer,
@@ -67,10 +67,6 @@ const WORKSPACE_REVALIDATE_CACHE_CONTROL = 'private, no-cache, must-revalidate'
  * bumps on every edit — so the browser may cache it indefinitely; re-opens and
  * focus refetches then resolve from cache with no round trip. Unversioned workspace
  * reads stay revalidated because the same storage key is edited in place.
- *
- * Callers pass `versioned && !unrendered`: a render that failed returns the stored
- * bytes as opaque data, and marking that immutable for a year would pin the failure
- * to the URL long after a later compile succeeds on the same version.
  */
 function resolveServeCacheControl(
   versioned: boolean,
@@ -199,19 +195,22 @@ async function handleLocalFile(
     const segment = filename.split('/').pop() || filename
     const displayName = stripStorageKeyPrefix(segment)
     const workspaceId = getWorkspaceIdForCompile(filename)
-    const {
-      buffer: fileBuffer,
-      contentType,
-      unrendered,
-    } = await compileDocumentIfNeeded(rawBuffer, displayName, workspaceId, raw, ownerKey, signal)
+    const { buffer: fileBuffer, contentType } = await compileDocumentIfNeeded(
+      rawBuffer,
+      displayName,
+      workspaceId,
+      raw,
+      ownerKey,
+      signal
+    )
 
     logger.info('Local file served', { userId, filename, size: fileBuffer.length })
 
     return createFileResponse({
       buffer: fileBuffer,
       contentType,
       filename: displayName,
-      cacheControl: resolveServeCacheControl(versioned && !unrendered, contextParam),
+      cacheControl: resolveServeCacheControl(versioned, contextParam),
     })
   } catch (error) {
     logger.error('Error reading local file:', error)
@@ -258,11 +257,14 @@ async function handleCloudProxy(
     const segment = cloudKey.split('/').pop() || 'download'
     const displayName = stripStorageKeyPrefix(segment)
     const workspaceId = getWorkspaceIdForCompile(cloudKey)
-    const {
-      buffer: fileBuffer,
-      contentType,
-      unrendered,
-    } = await compileDocumentIfNeeded(rawBuffer, displayName, workspaceId, raw, ownerKey, signal)
+    const { buffer: fileBuffer, contentType } = await compileDocumentIfNeeded(
+      rawBuffer,
+      displayName,
+      workspaceId,
+      raw,
+      ownerKey,
+      signal
+    )
 
     logger.info('Cloud file served', {
       userId,
@@ -275,7 +277,7 @@ async function handleCloudProxy(
       buffer: fileBuffer,
       contentType,
       filename: displayName,
-      cacheControl: resolveServeCacheControl(versioned && !unrendered, context),
+      cacheControl: resolveServeCacheControl(versioned, context),
     })
   } catch (error) {
     logger.error('Error downloading from cloud storage:', error)

apps/sim/executor/handlers/agent/agent-handler.ts

@@ -783,9 +783,6 @@ export class AgentBlockHandler implements BlockHandler {
         userId: ctx.userId,
         logger,
         maxBytes: INLINE_ATTACHMENT_THRESHOLD_BYTES,
-        // These files are about to become provider attachments, so a document that
-        // is still compiling must fail loudly rather than reach the model empty.
-        throwOnDocNotReady: true,
       })
 
       const missingFile = hydratedFiles.find(

apps/sim/executor/handlers/mothership/mothership-handler.test.ts

@@ -588,56 +588,6 @@ describe('MothershipBlockHandler', () => {
     ])
   })
 
-  it('attaches a generated document under its rendered MIME type, not its generation-source marker', async () => {
-    const fileContent = Buffer.from('%PDF-1.4 ...', 'utf8').toString('base64')
-    mockGenerateId.mockReturnValueOnce('chat-uuid')
-    mockGenerateId.mockReturnValueOnce('message-uuid')
-    mockGenerateId.mockReturnValueOnce('request-uuid')
-    mockReadUserFileContent.mockResolvedValueOnce(fileContent)
-
-    fetchMock.mockResolvedValue(
-      new Response(
-        JSON.stringify({
-          content: 'analyzed',
-          model: 'mothership',
-          conversationId: 'chat-uuid',
-          tokens: {},
-          toolCalls: [],
-        }),
-        {
-          status: 200,
-          headers: { 'Content-Type': 'application/json' },
-        }
-      )
-    )
-
-    await handler.execute(context, block, {
-      prompt: 'Analyze this file',
-      files: [
-        {
-          name: 'report.pdf',
-          key: 'workspace/workspace-1/report.pdf',
-          size: 16,
-          type: 'text/x-python-pdf',
-        },
-      ],
-    })
-
-    const [, options] = fetchMock.mock.calls[0] as [string, RequestInit]
-    const body = JSON.parse(String(options.body))
-    expect(body.fileAttachments).toEqual([
-      {
-        type: 'document',
-        source: {
-          type: 'base64',
-          media_type: 'application/pdf',
-          data: fileContent,
-        },
-        filename: 'report.pdf',
-      },
-    ])
-  })
-
   it('propagates local aborts to the mothership request', async () => {
     const abortController = new AbortController()
     context.abortSignal = abortController.signal

apps/sim/executor/handlers/mothership/mothership-handler.ts

@@ -23,7 +23,6 @@ import type {
   StreamingExecution,
 } from '@/executor/types'
 import { buildAPIUrl, buildAuthHeaders, extractAPIErrorMessage } from '@/executor/utils/http'
-import { inferAttachmentMimeType } from '@/providers/attachments'
 import type { SerializedBlock } from '@/serializer/types'
 
 const logger = createLogger('MothershipBlockHandler')
@@ -310,7 +309,7 @@ async function buildMothershipFileAttachments(
       maxSourceBytes: MAX_MOTHERSHIP_ATTACHMENT_BYTES,
     })
 
-    const content = createFileContentFromBase64(base64, inferAttachmentMimeType(userFile))
+    const content = createFileContentFromBase64(base64, userFile.type)
     if (!content) {
       throw new Error(`File type is not supported for Mothership attachments: ${userFile.name}`)
     }

apps/sim/executor/variables/resolvers/reference-async.server.ts

@@ -81,10 +81,6 @@ async function hydrateExplicitBase64(
     allowLargeValueWorkflowScope: context.executionContext.allowLargeValueWorkflowScope,
     userId: context.executionContext.userId,
     maxBytes: context.executionContext.base64MaxBytes,
-    // An explicit `<file.base64>` reference has no degraded mode — the resolver throws
-    // when content is missing. Opt in so a still-compiling document reports that
-    // instead of the generic size/availability message below.
-    throwOnDocNotReady: true,
   })
   if (!hydrated.base64) {
     throw new Error(