fix(admin): address review findings on recent impersonations

Author: TheodoreSpeaks

apps/sim/app/workspace/[workspaceId]/settings/components/admin/use-recent-impersonations.ts

@@ -1,7 +1,5 @@
 import { useCallback, useState } from 'react'
-
-/** Survives clearUserData via the keysToKeep allowlist in @/stores. */
-export const RECENT_IMPERSONATIONS_STORAGE_KEY = 'recent-impersonations'
+import { RECENT_IMPERSONATIONS_STORAGE_KEY } from '@/stores'
 
 const MAX_RECENT = 5
 
@@ -24,7 +22,11 @@ export function useRecentImpersonations() {
 
   const recordImpersonation = useCallback((email: string) => {
     const next = [email, ...readRecentEmails().filter((e) => e !== email)].slice(0, MAX_RECENT)
-    localStorage.setItem(RECENT_IMPERSONATIONS_STORAGE_KEY, JSON.stringify(next))
+    try {
+      localStorage.setItem(RECENT_IMPERSONATIONS_STORAGE_KEY, JSON.stringify(next))
+    } catch {
+      /* best-effort: recording must never block the impersonation transition */
+    }
     setRecentEmails(next)
   }, [])
 

apps/sim/hooks/queries/admin-users.ts

@@ -91,7 +91,7 @@ async function fetchAdminUsersByEmails(
       const { data, error } = await client.admin.listUsers(
         {
           query: {
-            limit: 5,
+            limit: 20,
             searchField: 'email',
             searchValue: email,
             searchOperator: 'contains',

apps/sim/stores/index.ts

@@ -2,7 +2,6 @@
 
 import { createLogger } from '@sim/logger'
 import { getQueryClient } from '@/app/_shell/providers/get-query-client'
-import { RECENT_IMPERSONATIONS_STORAGE_KEY } from '@/app/workspace/[workspaceId]/settings/components/admin/use-recent-impersonations'
 import { environmentKeys } from '@/hooks/queries/environment'
 import { useExecutionStore } from '@/stores/execution'
 import { useMothershipDraftsStore } from '@/stores/mothership-drafts/store'
@@ -13,6 +12,9 @@ import { useWorkflowStore } from '@/stores/workflows/workflow/store'
 
 const logger = createLogger('Stores')
 
+/** localStorage key for the admin recent-impersonations list; kept through clearUserData. */
+export const RECENT_IMPERSONATIONS_STORAGE_KEY = 'recent-impersonations'
+
 /**
  * Reset all Zustand stores and React Query caches to initial state.
  */