refactor(utils): consolidate duplicated helpers onto @sim/utils (#5509)

* refactor(utils): consolidate duplicated helpers onto @sim/utils

Replaces ~90 hand-rolled reimplementations of error-message extraction,
postgres error-code checks, sleep, Math.random, retry/backoff, object
filtering/omission, noop, string truncation, date/time formatting, email
normalization, and plain-object type guards with the shared @sim/utils
exports. Wires check:utils into CI (test-build.yml) so these patterns
don't regress.

* fix(test): mock @sim/utils/random instead of Math.random in schedule-execute tests

The schedules/execute route previously used Math.random() for jitter delay;
this consolidation PR switched it to randomInt() from @sim/utils/random,
which is backed by crypto.getRandomValues() rather than Math.random(). The
route.test.ts spies on Math.random() no longer had any effect, so jitter
became real random delay instead of the deterministic 0ms the tests expect,
causing intermittent 10s timeouts in CI.

* fix(retry): preserve uncapped Retry-After comparison in tools/index.ts

parseRetryAfter() caps its return value at 30s by default. tools/index.ts
compares the parsed Retry-After against a caller-configured maxDelayMs to
decide whether to skip a retry entirely -- capping before that comparison
silently defeats the skip check whenever maxDelayMs is configured above
30s, since a Retry-After between 30s and maxDelayMs would incorrectly look
"within limits" and get retried instead of skipped (caught by Cursor
Bugbot). Added an optional maxMs param (default unchanged) so tools/index.ts
can request the raw, uncapped value for its own comparison while
backoffWithJitter still clamps the actual sleep duration to maxDelayMs.
Added a regression test covering maxDelayMs > 30s.

* fix(utils): fall back to Intl-resolved abbreviation for unmapped timezones

getTimezoneAbbreviation only covered 9 hardcoded IANA zones and returned
the raw IANA string for everything else, degrading schedule descriptions
for zones like Europe/Berlin or America/Toronto (caught by Greptile). The
deleted local implementation in schedules/utils.ts resolved any valid IANA
timezone generically via Intl.DateTimeFormat's short timeZoneName. Restore
that as a fallback so only genuinely invalid timezone strings return
themselves unchanged.

Author: waleedlatif1

.github/workflows/test-build.yml

@@ -116,6 +116,9 @@ jobs:
       - name: API contract boundary audit
         run: bun run check:api-validation:strict
 
+      - name: Shared utils enforcement audit
+        run: bun run check:utils
+
       - name: Zustand v5 selector audit
         run: bun run check:zustand-v5
 

apps/sim/app/(auth)/login/login-form.tsx

@@ -11,6 +11,7 @@ import {
 } from '@sim/emcn'
 import { createLogger } from '@sim/logger'
 import { getErrorMessage } from '@sim/utils/errors'
+import { normalizeEmail } from '@sim/utils/string'
 import { useRouter, useSearchParams } from 'next/navigation'
 import { requestJson } from '@/lib/api/client/request'
 import { forgetPasswordContract } from '@/lib/api/contracts'
@@ -45,7 +46,7 @@ const validateEmailField = (emailValue: string): string[] => {
     return errors
   }
 
-  const validation = quickValidateEmail(emailValue.trim().toLowerCase())
+  const validation = quickValidateEmail(normalizeEmail(emailValue))
   if (!validation.isValid) {
     errors.push(validation.reason || 'Please enter a valid email address.')
   }
@@ -159,7 +160,7 @@ export default function LoginPage({
 
     const formData = new FormData(e.currentTarget)
     const emailRaw = formData.get('email') as string
-    const email = emailRaw.trim().toLowerCase()
+    const email = normalizeEmail(emailRaw)
 
     const emailValidationErrors = validateEmailField(email)
     setEmailErrors(emailValidationErrors)
@@ -277,7 +278,7 @@ export default function LoginPage({
       return
     }
 
-    const emailValidation = quickValidateEmail(forgotPasswordEmail.trim().toLowerCase())
+    const emailValidation = quickValidateEmail(normalizeEmail(forgotPasswordEmail))
     if (!emailValidation.isValid) {
       setResetStatus({
         type: 'error',

apps/sim/app/(interfaces)/resume/[workflowId]/[executionId]/resume-page-client.tsx

@@ -18,6 +18,7 @@ import {
   TableRow,
   Tooltip,
 } from '@sim/emcn'
+import { formatDateTime } from '@sim/utils/formatting'
 import { useQueryClient } from '@tanstack/react-query'
 import { RefreshCw } from 'lucide-react'
 import { useRouter } from 'next/navigation'
@@ -68,7 +69,7 @@ const STATUS_BADGE_VARIANT: Record<string, 'orange' | 'blue' | 'green' | 'red' |
 function formatDate(value: string | null): string {
   if (!value) return '—'
   try {
-    return new Date(value).toLocaleString()
+    return formatDateTime(new Date(value))
   } catch {
     return value
   }

apps/sim/app/(landing)/changelog/components/changelog-timeline/changelog-timeline.tsx

@@ -4,6 +4,7 @@ import { type ReactNode, useRef, useState } from 'react'
 import { Streamdown } from 'streamdown'
 import 'streamdown/styles.css'
 import { Avatar, AvatarFallback, AvatarImage, Chip, cn } from '@sim/emcn'
+import { formatDate } from '@sim/utils/formatting'
 import type { ChangelogEntry, GitHubRelease } from '@/app/(landing)/changelog/types'
 import { mapReleases, releasesEndpoint } from '@/app/(landing)/changelog/utils'
 
@@ -53,14 +54,6 @@ function isContributorsLabel(children: ReactNode): boolean {
   return /^\s*contributors\s*:?\s*$/i.test(String(children))
 }
 
-function formatDate(value: string): string {
-  return new Date(value).toLocaleDateString('en-US', {
-    year: 'numeric',
-    month: 'short',
-    day: 'numeric',
-  })
-}
-
 export function ChangelogTimeline({ initialEntries }: ChangelogTimelineProps) {
   const [entries, setEntries] = useState<ChangelogEntry[]>(initialEntries)
   const [loading, setLoading] = useState<boolean>(false)
@@ -133,7 +126,9 @@ export function ChangelogTimeline({ initialEntries }: ChangelogTimelineProps) {
                   </div>
                 ) : null}
               </div>
-              <span className='text-[12px] text-[var(--text-muted)]'>{formatDate(entry.date)}</span>
+              <span className='text-[12px] text-[var(--text-muted)]'>
+                {formatDate(new Date(entry.date))}
+              </span>
             </div>
 
             <div aria-hidden='true' className='mt-[9px] mb-3 h-px bg-[var(--border)]' />

apps/sim/app/api/auth/oauth/utils.ts

@@ -2,7 +2,7 @@ import { createSign } from 'crypto'
 import { db } from '@sim/db'
 import { account, credential } from '@sim/db/schema'
 import { createLogger } from '@sim/logger'
-import { toError } from '@sim/utils/errors'
+import { getPostgresErrorCode, toError } from '@sim/utils/errors'
 import { and, desc, eq } from 'drizzle-orm'
 import { withLeaderLock } from '@/lib/concurrency/leader-lock'
 import { coalesceLocally } from '@/lib/concurrency/singleflight'
@@ -281,7 +281,7 @@ export async function safeAccountInsert(
     await db.insert(account).values(data)
     logger.info(`Created new ${context.provider} account for user`, { userId: data.userId })
   } catch (error: any) {
-    if (error?.code === '23505') {
+    if (getPostgresErrorCode(error) === '23505') {
       logger.error(`Duplicate ${context.provider} account detected, credential already exists`, {
         userId: data.userId,
         identifier: context.identifier,

apps/sim/app/api/billing/invoices/route.test.ts

@@ -2,6 +2,7 @@
  * @vitest-environment node
  */
 import { createMockRequest, dbChainMock, dbChainMockFns } from '@sim/testing'
+import { generateShortId } from '@sim/utils/id'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockGetSession, mockGetStripeClient, mockStripeInvoicesList } = vi.hoisted(() => ({
@@ -25,7 +26,7 @@ import { GET } from '@/app/api/billing/invoices/route'
 
 function makeInvoice(overrides: Record<string, unknown> = {}) {
   return {
-    id: `in_${Math.random().toString(36).slice(2)}`,
+    id: `in_${generateShortId()}`,
     number: 'INV-1',
     created: 1700000000,
     total: 1000,

apps/sim/app/api/cron/renew-subscriptions/route.test.ts

@@ -12,6 +12,7 @@ import {
   redisConfigMockFns,
   resetDbChainMock,
 } from '@sim/testing'
+import { sleep } from '@sim/utils/helpers'
 import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockVerifyCronAuth } = vi.hoisted(() => ({
@@ -37,7 +38,7 @@ function createRequest() {
   )
 }
 
-const flushMicrotasks = () => new Promise((resolve) => setTimeout(resolve, 0))
+const flushMicrotasks = () => sleep(0)
 
 describe('Teams subscription renewal route (fire-and-forget)', () => {
   beforeEach(() => {

apps/sim/app/api/files/public/[token]/otp/route.ts

@@ -1,4 +1,5 @@
 import { createLogger } from '@sim/logger'
+import { normalizeEmail } from '@sim/utils/string'
 import type { NextRequest } from 'next/server'
 import { NextResponse } from 'next/server'
 import { renderOTPEmail } from '@/components/emails'
@@ -71,7 +72,7 @@ export const POST = withRouteHandler(
       const { token } = parsed.data.params
       // Normalize once so allow-list matching, OTP storage, and the verify lookup
       // all key off the same value (allow-list entries are stored lowercase).
-      const email = parsed.data.body.email.trim().toLowerCase()
+      const email = normalizeEmail(parsed.data.body.email)
 
       const resolved = await resolveActiveShareByToken(token)
       if (!resolved) {
@@ -133,7 +134,7 @@ export const PUT = withRouteHandler(
       if (!parsed.success) return parsed.response
       const { token } = parsed.data.params
       const { otp } = parsed.data.body
-      const email = parsed.data.body.email.trim().toLowerCase()
+      const email = normalizeEmail(parsed.data.body.email)
 
       const resolved = await resolveActiveShareByToken(token)
       if (!resolved) {

apps/sim/app/api/files/public/[token]/sso/route.ts

@@ -1,4 +1,5 @@
 import { createLogger } from '@sim/logger'
+import { normalizeEmail } from '@sim/utils/string'
 import type { NextRequest } from 'next/server'
 import { NextResponse } from 'next/server'
 import { publicFileSSOContract } from '@/lib/api/contracts/public-shares'
@@ -53,7 +54,7 @@ export const POST = withRouteHandler(
     const parsed = await parseRequest(publicFileSSOContract, request, context)
     if (!parsed.success) return parsed.response
     const { token } = parsed.data.params
-    const email = parsed.data.body.email.trim().toLowerCase()
+    const email = normalizeEmail(parsed.data.body.email)
 
     const resolved = await resolveActiveShareByToken(token)
     if (!resolved) {

apps/sim/app/api/function/execute/route.ts

@@ -1,4 +1,5 @@
 import { createLogger } from '@sim/logger'
+import { getErrorMessage } from '@sim/utils/errors'
 import { type NextRequest, NextResponse } from 'next/server'
 import { functionExecuteContract } from '@/lib/api/contracts'
 import { parseRequest } from '@/lib/api/server'
@@ -1021,7 +1022,7 @@ async function maybeExportSandboxFileToWorkspace(args: {
     return NextResponse.json(
       {
         success: false,
-        error: error instanceof Error ? error.message : 'Failed to export sandbox file',
+        error: getErrorMessage(error, 'Failed to export sandbox file'),
         output: { result: null, stdout: cleanStdout(stdout), executionTime },
       },
       { status: 400 }
@@ -1165,7 +1166,7 @@ async function maybeExportSandboxFilesToWorkspace(args: {
     return NextResponse.json(
       {
         success: false,
-        error: error instanceof Error ? error.message : 'Invalid sandbox output destination',
+        error: getErrorMessage(error, 'Invalid sandbox output destination'),
         output: {
           result: null,
           stdout: cleanStdout(args.stdout),
@@ -1220,7 +1221,7 @@ async function maybeExportSandboxFilesToWorkspace(args: {
     return NextResponse.json(
       {
         success: false,
-        error: error instanceof Error ? error.message : 'Failed to export sandbox files',
+        error: getErrorMessage(error, 'Failed to export sandbox files'),
         output: {
           result: null,
           stdout: cleanStdout(args.stdout),