Commit 95037b3
Ricardo DeMatos
fix(managed-agent): address MR feedback (decrypt escape, cancel, requires_action, public defaults)
Four fixes to PR #5769 review comments.
- `getDecryptedApiKey` throws when stored ciphertext cannot be decrypted
(typically after an `ENCRYPTION_KEY` rotation). Wrapped the call in the
tool's error-handling path so the failure returns the tool's declared
`{success:false, output:{}, error:'...'}` shape with an actionable
message pointing at Settings → Managed Agents → rotate, rather than an
unhandled promise rejection.
- Added the workflow's abort signal to `_context.abortSignal` on the
`directExecution` path in `executeTool`, so any tool that wants to
propagate cancellation can. This is opt-in — existing tools are
unaffected.
- Read the signal in `run_session.server.ts` and thread it into
`createSession`, `sendUserMessage`, `openSessionStream`,
`readSSEEvents`, and `listEventsAfter`. Every long-lived HTTP hop
now cancels cleanly.
- Guard all loop entrances with `signal?.aborted` and translate any
abort-caused exception into a clean `{success:false, error:'aborted'}`
response — no scary stack traces on cancel.
- Server-side / vault-backed MCP tools legitimately hold the session in
`requires_action` with no client-visible events until the tool
finishes. My previous logic returned a terminal error on the first
empty `listEventsAfter` catch-up, failing those workflows before the
agent could complete.
- New policy: `requires_action` idle is NEVER terminal by itself. If
the outer reconnect loop finds no new events, back off (500ms,
doubling to 5s max) and re-poll `listEventsAfter`. Only fail after a
hard `MAX_REQUIRES_ACTION_WAIT_MS` cap (~5 min) — with a clear error
message — or on an explicit `session.status_terminated` /
`session.error`.
- `EventState` gains `requiresActionEnteredAt` (first entry into the
busy stretch) and `currentBackoffMs`; both reset when the session
makes progress (non-empty catch-up). Reconnect ceiling raised to 60
since the loop now sleeps between polls.
- Deleted `NEXT_PUBLIC_MANAGED_AGENT_SELF_HOSTED_DEFAULTS` — any
deployer who accidentally seeded a token into the JSON would leak it
to every browser via the client bundle.
- Replaced with server-only `MANAGED_AGENT_SELF_HOSTED_DEFAULTS` +
`GET /api/managed-agent-defaults` route that returns the parsed
rows. Values never enter the client bundle at build time.
- Extended the `Table` sub-block component with an optional
`fetchDefaultRows` async prop (mirrors the `fetchOptions` pattern
used by comboboxes). The block config points at
`fetchManagedAgentSelfHostedDefaults` in `subblock-options.ts`,
which calls the new API route via `requestJson(contract, ...)`.
- Removed the deleted function's tests; added coverage for the new
API route (`app/api/managed-agent-defaults/route.test.ts` — 7 tests).
- Updated `.env.example` docs to make the safety property explicit.
Verified: 86 tests pass across the 6 managed-agent test files. Pre-existing
tsc errors (integration-tag enum, environments-route type mismatch, etc.)
are unchanged.1 parent 13cfebe commit 95037b3
14 files changed
Lines changed: 385 additions & 153 deletions
File tree
- apps/sim
- app
- api/managed-agent-defaults
- workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block
- components/table
- blocks
- blocks
- lib
- api/contracts
- core/config
- managed-agents
- tools
- managed_agent
- scripts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
Lines changed: 42 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
34 | 43 | | |
35 | 44 | | |
36 | 45 | | |
| |||
221 | 230 | | |
222 | 231 | | |
223 | 232 | | |
| 233 | + | |
224 | 234 | | |
225 | 235 | | |
226 | 236 | | |
| |||
256 | 266 | | |
257 | 267 | | |
258 | 268 | | |
259 | | - | |
260 | | - | |
261 | | - | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
262 | 275 | | |
263 | 276 | | |
264 | | - | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
265 | 282 | | |
266 | | - | |
267 | | - | |
| 283 | + | |
| 284 | + | |
268 | 285 | | |
269 | 286 | | |
270 | 287 | | |
271 | 288 | | |
272 | 289 | | |
273 | 290 | | |
274 | | - | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
275 | 310 | | |
276 | 311 | | |
277 | 312 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
754 | 754 | | |
755 | 755 | | |
756 | 756 | | |
| 757 | + | |
757 | 758 | | |
758 | 759 | | |
759 | 760 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | 8 | | |
10 | 9 | | |
11 | 10 | | |
| |||
20 | 19 | | |
21 | 20 | | |
22 | 21 | | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
| 27 | + | |
92 | 28 | | |
93 | 29 | | |
94 | 30 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | 61 | | |
91 | 62 | | |
92 | 63 | | |
| |||
181 | 152 | | |
182 | 153 | | |
183 | 154 | | |
184 | | - | |
185 | | - | |
186 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
187 | 159 | | |
188 | 160 | | |
189 | 161 | | |
190 | 162 | | |
191 | 163 | | |
192 | | - | |
| 164 | + | |
193 | 165 | | |
194 | 166 | | |
195 | 167 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
288 | 295 | | |
289 | 296 | | |
290 | 297 | | |
| |||
0 commit comments