fix(executor): stop adopting an upstream target's HTTP status as our own

Author: TheodoreSpeaks

apps/sim/executor/utils/errors.test.ts

@@ -45,8 +45,15 @@ describe('getExecutionErrorStatus', () => {
     expect(getExecutionErrorStatus(new Error('boom'))).toBe(500)
   })
 
-  it('reads the legacy duck-typed status field', () => {
-    const error = Object.assign(new Error('rate limited'), { status: 429 })
+  it("never adopts an upstream target's duck-typed status as our own", () => {
+    // `api-handler` copies the remote response's status onto the thrown error.
+    // Adopting it would make a remote 404 the workflow API's 404.
+    const error = Object.assign(new Error('HTTP 404'), { status: 404 })
+    expect(getExecutionErrorStatus(error)).toBe(500)
+  })
+
+  it('still reads a Sim-owned statusCode re-attached from a ToolResponse', () => {
+    const error = Object.assign(new Error('rate limited'), { statusCode: 429 })
     expect(getExecutionErrorStatus(error)).toBe(429)
   })
 

apps/sim/executor/utils/errors.ts

@@ -76,8 +76,14 @@ const MAX_CAUSE_DEPTH = 8
 /**
  * HTTP status carried by a thrown value, walking the `.cause` chain so a status
  * set deep in a tool survives the block-level wrapping that rebuilds the error.
- * Reads `HttpError.statusCode` (the canonical class-based carrier) plus the
- * legacy duck-typed `statusCode`/`status` fields some paths still set.
+ *
+ * Reads only SIM-OWNED carriers: `HttpError.statusCode` (canonical) and the
+ * `statusCode` field `generic-handler` re-attaches from a failed `ToolResponse`.
+ * Deliberately does NOT read the duck-typed `status` field: that carries an
+ * UPSTREAM target's status (`api-handler` copies it off the remote response, and
+ * transformed HTTP tool errors carry it too). Adopting it would turn a remote
+ * 404 into the workflow API's 404, colliding with the statuses that route owns
+ * (404 = workflow not found, 401 = bad API key, 429 = Sim rate limit).
  */
 export function readStatusCode(value: unknown): number | undefined {
   const seen = new Set<unknown>()
@@ -89,9 +95,8 @@ export function readStatusCode(value: unknown): number | undefined {
 
     if (current instanceof HttpError) return current.statusCode
 
-    const candidate = current as unknown as { statusCode?: unknown; status?: unknown }
+    const candidate = current as unknown as { statusCode?: unknown }
     if (typeof candidate.statusCode === 'number') return candidate.statusCode
-    if (typeof candidate.status === 'number') return candidate.status
 
     current = current.cause
   }