Skip to content

Commit 8550471

Browse files
committed
fix(dropbox): mark path_display/path_lower optional everywhere for consistency
Greptile flagged that path_display was left required in list_folder.ts and list_revisions.ts despite being widened to optional in types.ts and most other output schemas in this PR. Fixed those two plus create_folder.ts, restore.ts, upload.ts, and list_shared_links.ts, which had the same gap.
1 parent 1e76782 commit 8550471

6 files changed

Lines changed: 13 additions & 9 deletions

File tree

apps/sim/tools/dropbox/create_folder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,8 @@ export const dropboxCreateFolderTool: ToolConfig<
7474
properties: {
7575
id: { type: 'string', description: 'Unique identifier for the folder' },
7676
name: { type: 'string', description: 'Name of the folder' },
77-
path_display: { type: 'string', description: 'Display path of the folder' },
78-
path_lower: { type: 'string', description: 'Lowercase path of the folder' },
77+
path_display: { type: 'string', description: 'Display path of the folder', optional: true },
78+
path_lower: { type: 'string', description: 'Lowercase path of the folder', optional: true },
7979
},
8080
},
8181
},

apps/sim/tools/dropbox/list_folder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export const dropboxListFolderTool: ToolConfig<DropboxListFolderParams, DropboxL
9898
'.tag': { type: 'string', description: 'Type: file, folder, or deleted' },
9999
id: { type: 'string', description: 'Unique identifier', optional: true },
100100
name: { type: 'string', description: 'Name of the file/folder' },
101-
path_display: { type: 'string', description: 'Display path' },
101+
path_display: { type: 'string', description: 'Display path', optional: true },
102102
size: { type: 'number', description: 'Size in bytes (files only)', optional: true },
103103
},
104104
},

apps/sim/tools/dropbox/list_revisions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export const dropboxListRevisionsTool: ToolConfig<
8282
properties: {
8383
id: { type: 'string', description: 'Unique identifier for this revision' },
8484
name: { type: 'string', description: 'Name of the file' },
85-
path_display: { type: 'string', description: 'Display path' },
85+
path_display: { type: 'string', description: 'Display path', optional: true },
8686
rev: { type: 'string', description: 'Revision identifier, pass to Restore' },
8787
size: { type: 'number', description: 'Size of this revision in bytes' },
8888
server_modified: { type: 'string', description: 'Server modification time' },

apps/sim/tools/dropbox/list_shared_links.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,11 @@ export const dropboxListSharedLinksTool: ToolConfig<
9494
'.tag': { type: 'string', description: 'Type: file or folder' },
9595
url: { type: 'string', description: 'The shared link URL' },
9696
name: { type: 'string', description: 'Name of the shared item' },
97-
path_lower: { type: 'string', description: 'Lowercase path of the shared item' },
97+
path_lower: {
98+
type: 'string',
99+
description: 'Lowercase path of the shared item',
100+
optional: true,
101+
},
98102
expires: { type: 'string', description: 'Expiration date if set' },
99103
},
100104
},

apps/sim/tools/dropbox/restore.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ export const dropboxRestoreTool: ToolConfig<DropboxRestoreParams, DropboxRestore
7171
properties: {
7272
id: { type: 'string', description: 'Unique identifier for the file' },
7373
name: { type: 'string', description: 'Name of the file' },
74-
path_display: { type: 'string', description: 'Display path of the file' },
75-
path_lower: { type: 'string', description: 'Lowercase path of the file' },
74+
path_display: { type: 'string', description: 'Display path of the file', optional: true },
75+
path_lower: { type: 'string', description: 'Lowercase path of the file', optional: true },
7676
size: { type: 'number', description: 'Size of the file in bytes' },
7777
rev: { type: 'string', description: 'Revision identifier of the restored file' },
7878
server_modified: { type: 'string', description: 'Server modification time' },

apps/sim/tools/dropbox/upload.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ export const dropboxUploadTool: ToolConfig<DropboxUploadParams, DropboxUploadRes
101101
properties: {
102102
id: { type: 'string', description: 'Unique identifier for the file' },
103103
name: { type: 'string', description: 'Name of the file' },
104-
path_display: { type: 'string', description: 'Display path of the file' },
105-
path_lower: { type: 'string', description: 'Lowercase path of the file' },
104+
path_display: { type: 'string', description: 'Display path of the file', optional: true },
105+
path_lower: { type: 'string', description: 'Lowercase path of the file', optional: true },
106106
size: { type: 'number', description: 'Size of the file in bytes' },
107107
client_modified: { type: 'string', description: 'Client modification time' },
108108
server_modified: { type: 'string', description: 'Server modification time' },

0 commit comments

Comments
 (0)