fix(quickbooks): clean up consolidated CI

Author: Bill Leoutsakos

apps/docs/content/docs/en/integrations/zoho_desk.mdx

@@ -5,7 +5,7 @@ description: Manage Zoho Desk tickets, comments, threads, and contacts
 
 import { BlockInfoCard } from "@/components/ui/block-info-card"
 
-<BlockInfoCard
+<BlockInfoCard 
   type="zoho_desk"
   color="#FFFFFF"
 />
@@ -512,3 +512,4 @@ Trigger a workflow when a Zoho Desk event occurs (ticket, comment, thread, conta
 | `orgId` | string | Zoho Desk organization ID |
 | `payload` | json | The full resource that changed \(ticket, comment, thread, etc.\). Comment and thread events gain a derived plain-text `contentText` alongside the raw `content` + `contentType`; ticket events gain `descriptionText` alongside `description`. |
 | `prevState` | json | Previous state of the resource \(update events only\) |
+

apps/sim/app/api/tools/quickbooks/documents.test.ts

@@ -6,9 +6,11 @@ import {
   hybridAuthMockFns,
   inputValidationMock,
   inputValidationMockFns,
+  resetEnvMock,
+  setEnv,
 } from '@sim/testing'
 import { NextRequest } from 'next/server'
-import { beforeEach, describe, expect, it, vi } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 import { MAX_FILE_SIZE } from '@/lib/uploads/utils/validation'
 
 const {
@@ -64,6 +66,7 @@ function createAbortableRequest(body: unknown, signal: AbortSignal): NextRequest
 }
 
 beforeEach(() => {
+  setEnv({ QUICKBOOKS_ENV: 'sandbox' })
   vi.clearAllMocks()
   vi.stubGlobal('fetch', mockFetch)
   hybridAuthMockFns.mockCheckInternalAuth.mockResolvedValue({
@@ -100,6 +103,8 @@ beforeEach(() => {
   })
 })
 
+afterEach(resetEnvMock)
+
 describe('QuickBooks document API routes', () => {
   it('authenticates before parsing a PDF request', async () => {
     hybridAuthMockFns.mockCheckInternalAuth.mockResolvedValueOnce({

apps/sim/lib/workflows/blocks/block-outputs.ts

@@ -52,7 +52,7 @@ function isConditionPrimitive(value: unknown): value is ConditionValue {
  * Evaluates an output condition against subBlock values.
  * Returns true if the condition is met and the output should be shown.
  */
-export function evaluateOutputCondition(
+function evaluateOutputCondition(
   condition: OutputCondition,
   subBlocks: Record<string, SubBlockWithValue> | undefined
 ): boolean {
@@ -93,10 +93,6 @@ export function evaluateOutputCondition(
     matches = matches && andMatches
   }
 
-  if (condition.or) {
-    matches = matches || evaluateOutputCondition(condition.or, subBlocks)
-  }
-
   return matches
 }
 

apps/sim/tools/quickbooks/quickbooks.test.ts

@@ -1,9 +1,10 @@
 import { readFileSync } from 'node:fs'
 import { resetEnvMock, setEnv } from '@sim/testing'
-import { afterEach, beforeEach, describe, expect, it } from 'vitest'
-import { evaluateOutputCondition } from '@/lib/workflows/blocks/block-outputs'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { getBlockOutputs } from '@/lib/workflows/blocks/block-outputs'
 import { evaluateSubBlockCondition } from '@/lib/workflows/subblocks/visibility'
 import { QuickBooksBlock } from '@/blocks/blocks/quickbooks'
+import { getBlock } from '@/blocks/registry'
 import {
   quickbooksAddAttachmentTool,
   quickbooksCreateBillPaymentTool,
@@ -1224,25 +1225,28 @@ describe('QuickBooks tool and block boundaries', () => {
       ],
       and: { field: 'readMode', value: 'list' },
     })
-    const listOutputCondition = QuickBooksBlock.outputs.items.condition!
+    vi.mocked(getBlock)
+      .mockReturnValueOnce(QuickBooksBlock)
+      .mockReturnValueOnce(QuickBooksBlock)
+      .mockReturnValueOnce(QuickBooksBlock)
     expect(
-      evaluateOutputCondition(listOutputCondition, {
+      getBlockOutputs('quickbooks', {
         operation: { value: 'quickbooks_read_sales_transactions' },
         readMode: { value: 'by_id' },
       })
-    ).toBe(false)
+    ).not.toHaveProperty('items')
     expect(
-      evaluateOutputCondition(listOutputCondition, {
+      getBlockOutputs('quickbooks', {
         operation: { value: 'quickbooks_read_sales_transactions' },
         readMode: { value: 'list' },
       })
-    ).toBe(true)
+    ).toHaveProperty('items')
     expect(
-      evaluateOutputCondition(listOutputCondition, {
+      getBlockOutputs('quickbooks', {
         operation: { value: 'quickbooks_read_purchasing_transactions' },
         readMode: { value: 'list' },
       })
-    ).toBe(true)
+    ).toHaveProperty('items')
     expect(subBlocks.syncToken.condition).toEqual({
       field: 'operation',
       value: [

packages/workflow-types/src/blocks.ts

@@ -71,7 +71,6 @@ export interface OutputCondition {
       | null
     not?: boolean
   }
-  or?: OutputCondition
 }
 
 export type OutputFieldDefinition =