fix(outlook): allow calendar paging without re-supplying the time window

Cursor Bugbot round: startDateTime/endDateTime were required tool params, so a
paging call carrying only pageToken failed validateToolParameters before the
request was built — even though the url builder short-circuits on pageToken and
ignores both bounds. Relax them to optional and enforce the real invariant
(pageToken OR both bounds) in the url builder, matching
tools/sharepoint/list_sites.ts. Block subblocks stay required, so the normal
editor flow is unchanged.

Also correct the calendar_respond comment: Graph documents exactly two 400
conditions for accept/decline, both on proposedNewTime, which we never send.
A non-empty comment alongside sendResponse=false is valid.

Author: waleedlatif1

apps/sim/tools/outlook/calendar-tools.test.ts

@@ -150,7 +150,19 @@ describe('outlook calendar tools', () => {
     )
   })
 
-  it('omits the comment key when empty so sendResponse=false is accepted by Graph', () => {
+  it('requires both window bounds unless paging with a pageToken', () => {
+    const url = outlookCalendarListEventsTool.request.url as (p: unknown) => string
+    // Paging supplies only the token: the window is already baked into the nextLink.
+    expect(url({ accessToken: 't', pageToken: 'https://graph.microsoft.com/next' })).toBe(
+      'https://graph.microsoft.com/next'
+    )
+    expect(() => url({ accessToken: 't', startDateTime: '2025-06-03T00:00:00Z' })).toThrow(
+      /startDateTime and endDateTime are required/
+    )
+    expect(() => url({ accessToken: 't' })).toThrow(/startDateTime and endDateTime are required/)
+  })
+
+  it('omits the comment key when empty but keeps it alongside sendResponse=false', () => {
     const body = outlookCalendarRespondTool.request.body as (p: unknown) => Record<string, unknown>
     // Empty/whitespace comment with sendResponse off: comment must NOT be present.
     const noComment = body({
@@ -165,6 +177,12 @@ describe('outlook calendar tools', () => {
     const nullComment = body({ eventId: 'e1', responseType: 'decline', sendResponse: false })
     expect('comment' in nullComment).toBe(false)
 
+    // A real comment with sendResponse=false is valid: Graph's documented 400s for
+    // accept/decline are both about proposedNewTime, which we never send.
+    expect(
+      body({ eventId: 'e1', responseType: 'decline', sendResponse: false, comment: 'Conflict' })
+    ).toEqual({ sendResponse: false, comment: 'Conflict' })
+
     // A real comment is included, and sendResponse defaults to true.
     const withComment = body({ eventId: 'e1', responseType: 'accept', comment: 'See you there' })
     expect(withComment).toEqual({ sendResponse: true, comment: 'See you there' })

apps/sim/tools/outlook/calendar_list_events.ts

@@ -45,19 +45,22 @@ export const outlookCalendarListEventsTool: ToolConfig<
       visibility: 'user-only',
       description: 'ID of the calendar to read. Defaults to the mailbox default calendar.',
     },
+    // Not `required`, because a paging call supplies only `pageToken` and the window bounds
+    // are baked into the nextLink. The url builder enforces "pageToken OR both bounds".
+    // Mirrors tools/sharepoint/list_sites.ts.
     startDateTime: {
       type: 'string',
-      required: true,
+      required: false,
       visibility: 'user-or-llm',
       description:
-        'Start of the time window (ISO 8601, e.g. 2025-06-03T00:00:00-08:00). Interpreted as UTC if no offset is given.',
+        'Start of the time window (ISO 8601, e.g. 2025-06-03T00:00:00-08:00). Interpreted as UTC if no offset is given. Required unless paging with pageToken.',
     },
     endDateTime: {
       type: 'string',
-      required: true,
+      required: false,
       visibility: 'user-or-llm',
       description:
-        'End of the time window (ISO 8601, e.g. 2025-06-10T00:00:00-08:00). Interpreted as UTC if no offset is given.',
+        'End of the time window (ISO 8601, e.g. 2025-06-10T00:00:00-08:00). Interpreted as UTC if no offset is given. Required unless paging with pageToken.',
     },
     maxResults: {
       type: 'number',
@@ -88,6 +91,12 @@ export const outlookCalendarListEventsTool: ToolConfig<
         return assertGraphNextPageUrl(params.pageToken.trim())
       }
 
+      if (!params.startDateTime?.trim() || !params.endDateTime?.trim()) {
+        throw new Error(
+          'startDateTime and endDateTime are required to list calendar events (calendarView needs both bounds). Supply pageToken instead to continue a previous page.'
+        )
+      }
+
       const requested = Number(params.maxResults)
       const maxResults = Number.isFinite(requested)
         ? Math.max(1, Math.min(Math.abs(requested), MAX_EVENTS_PER_PAGE))

apps/sim/tools/outlook/calendar_respond.ts

@@ -90,9 +90,11 @@ export const outlookCalendarRespondTool: ToolConfig<
       }
     },
     body: (params) => {
-      // Graph rejects sendResponse=false when a `comment` key is present at all
-      // (even ""): "'SendResponse' must be true when 'Comment' is not null." So
-      // only include comment when it's actually non-empty.
+      // Only send `comment` when it has content — an empty string is meaningless to the
+      // organizer. Graph documents exactly two 400 conditions for accept/decline, both on
+      // `proposedNewTime` (which we never send); `comment` carries no such restriction and
+      // is valid alongside sendResponse=false.
+      // https://learn.microsoft.com/en-us/graph/api/event-decline
       const body: Record<string, unknown> = {
         sendResponse: toBool(params.sendResponse, true),
       }

apps/sim/tools/outlook/types.ts

@@ -710,8 +710,10 @@ export interface OutlookCalendarListEventsParams {
   accessToken: string
   /** Calendar to read. Omit for the mailbox's default calendar. */
   calendarId?: string
-  startDateTime: string
-  endDateTime: string
+  /** Required unless `pageToken` is supplied, which already encodes the window. */
+  startDateTime?: string
+  /** Required unless `pageToken` is supplied, which already encodes the window. */
+  endDateTime?: string
   maxResults?: number
   orderBy?: string
   /** Full `@odata.nextLink` URL from a previous page. */