fix(quickbooks): reject incomplete batch responses

Author: Bill Leoutsakos

apps/sim/tools/quickbooks/batch.ts

@@ -55,12 +55,25 @@ export const quickBooksBatchTool: ToolConfig<QuickBooksBatchParams, QuickBooksBa
     body: (params) => buildQuickBooksBatchBody(params.batch),
   },
 
-  transformResponse: async (response) => {
+  transformResponse: async (response, params) => {
+    if (!params) throw new Error('QuickBooks batch parameters are required')
     const data = await parseQuickBooksJson(response)
+    const requestItems = buildQuickBooksBatchBody(params.batch).BatchItemRequest
+    const batchItems = data.BatchItemResponse
+
+    if (!Array.isArray(batchItems) || batchItems.length === 0) {
+      throw new Error('QuickBooks batch response did not include any item responses')
+    }
+    if (Array.isArray(requestItems) && batchItems.length !== requestItems.length) {
+      throw new Error(
+        `QuickBooks batch response returned ${batchItems.length} of ${requestItems.length} item responses`
+      )
+    }
+
     return {
       success: true,
       output: {
-        batchItems: Array.isArray(data.BatchItemResponse) ? data.BatchItemResponse : [],
+        batchItems,
         time: typeof data.time === 'string' ? data.time : null,
       },
     }

apps/sim/tools/quickbooks/generic_operations.test.ts

@@ -852,7 +852,12 @@ describe('QuickBooks generic operations', () => {
     const result = await quickBooksBatchTool.transformResponse?.(response, {
       accessToken: 'token',
       realmId: '123145',
-      batch: { BatchItemRequest: [] },
+      batch: {
+        BatchItemRequest: [
+          { bId: 'vendor-query', Query: 'SELECT * FROM Vendor' },
+          { bId: 'bad-update', Vendor: { Id: '1', SyncToken: '0' }, operation: 'update' },
+        ],
+      },
     })
 
     expect(result?.output).toEqual({
@@ -863,4 +868,43 @@ describe('QuickBooks generic operations', () => {
       time: '2026-01-20T10:00:00-08:00',
     })
   })
+
+  it('rejects successful QuickBooks batch responses with missing or incomplete items', async () => {
+    const params = {
+      accessToken: 'token',
+      realmId: '123145',
+      batch: {
+        BatchItemRequest: [
+          { bId: 'vendor-query', Query: 'SELECT * FROM Vendor' },
+          { bId: 'bill-query', Query: 'SELECT * FROM Bill' },
+        ],
+      },
+    }
+
+    await expect(
+      quickBooksBatchTool.transformResponse?.(
+        new Response(JSON.stringify({ time: '2026-01-20T10:00:00-08:00' }), { status: 200 }),
+        params
+      )
+    ).rejects.toThrow('QuickBooks batch response did not include any item responses')
+
+    await expect(
+      quickBooksBatchTool.transformResponse?.(
+        new Response(JSON.stringify({ BatchItemResponse: [] }), { status: 200 }),
+        params
+      )
+    ).rejects.toThrow('QuickBooks batch response did not include any item responses')
+
+    await expect(
+      quickBooksBatchTool.transformResponse?.(
+        new Response(
+          JSON.stringify({
+            BatchItemResponse: [{ bId: 'vendor-query', QueryResponse: { Vendor: [{ Id: '1' }] } }],
+          }),
+          { status: 200 }
+        ),
+        params
+      )
+    ).rejects.toThrow('QuickBooks batch response returned 1 of 2 item responses')
+  })
 })