chore(tests): drop defensive resets in non-mutating suites, merge sequential setEnvFlags calls

Author: waleedlatif1

apps/sim/app/api/billing/update-cost/route.test.ts

@@ -147,8 +147,7 @@ const KEYLESS_UPDATE_COST_BODY = {
 describe('POST /api/billing/update-cost — workspaceId attribution', () => {
   beforeEach(() => {
     vi.clearAllMocks()
-    setEnvFlags({ isBillingEnabled: true })
-    setEnvFlags({ isCopilotBillingProtocolRequired: false })
+    setEnvFlags({ isBillingEnabled: true, isCopilotBillingProtocolRequired: false })
     mockCheckInternalApiKey.mockReturnValue({ success: true })
     mockRecordCumulativeUsage.mockResolvedValue({ billed: true, delta: 0.5, total: 0.5 })
     mockCheckAndBillOverageThreshold.mockResolvedValue(undefined)

apps/sim/app/api/schedules/execute/route.test.ts

@@ -289,10 +289,7 @@ describe('Scheduled Workflow Execution API Route', () => {
     dbChainMockFns.orderBy.mockReturnValue({ limit: orderByLimitMock } as never)
     dbChainMockFns.execute.mockResolvedValue([{ acquired: true }] as never)
     requestUtilsMockFns.mockGenerateRequestId.mockReturnValue('test-request-id')
-    setEnvFlags({ isTriggerDevEnabled: false })
-    setEnvFlags({ isHosted: false })
-    setEnvFlags({ isProd: false })
-    setEnvFlags({ isDev: true })
+    setEnvFlags({ isTriggerDevEnabled: false, isHosted: false, isProd: false, isDev: true })
     mockShouldExecuteInline.mockReturnValue(false)
     mockEnqueue.mockReset()
     mockEnqueue.mockResolvedValue('job-id-1')

apps/sim/app/api/speech/token/route.test.ts

@@ -6,7 +6,6 @@ import {
   dbChainMock,
   queueTableRows,
   resetDbChainMock,
-  resetEnvFlagsMock,
   schemaMock,
 } from '@sim/testing'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
@@ -128,8 +127,6 @@ afterAll(() => {
   resetDbChainMock()
 })
 
-afterAll(resetEnvFlagsMock)
-
 describe('POST /api/speech/token — usage attribution', () => {
   it('editor voice: bills the session user and stamps the verified workspace', async () => {
     const res = await POST(createMockRequest('POST', { workspaceId: 'ws-1' }))

apps/sim/blocks/utils.test.ts

@@ -88,9 +88,7 @@ describe('getApiKeyCondition / shouldRequireApiKeyForModel', () => {
 
   beforeEach(() => {
     vi.clearAllMocks()
-    setEnvFlags({ isHosted: false })
-    setEnvFlags({ isAzureConfigured: false })
-    setEnvFlags({ isOllamaConfigured: false })
+    setEnvFlags({ isHosted: false, isAzureConfigured: false, isOllamaConfigured: false })
     mockProviders.value = {
       base: { models: [], isLoading: false },
       ollama: { models: [], isLoading: false },
@@ -265,8 +263,7 @@ describe('getApiKeyCondition / shouldRequireApiKeyForModel', () => {
 
   describe('self-hosted without OLLAMA_URL', () => {
     it('requires API key for any model (Ollama models cannot appear without OLLAMA_URL)', () => {
-      setEnvFlags({ isHosted: false })
-      setEnvFlags({ isOllamaConfigured: false })
+      setEnvFlags({ isHosted: false, isOllamaConfigured: false })
       expect(evaluateCondition('llama3:latest')).toBe(true)
       expect(evaluateCondition('mistral:latest')).toBe(true)
       expect(evaluateCondition('gpt-4o')).toBe(true)

apps/sim/lib/api-key/byok.test.ts

@@ -1,7 +1,7 @@
 /**
  * @vitest-environment node
  */
-import { dbChainMock, dbChainMockFns, resetDbChainMock, resetEnvFlagsMock } from '@sim/testing'
+import { dbChainMock, dbChainMockFns, resetDbChainMock } from '@sim/testing'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockDecryptSecret } = vi.hoisted(() => ({
@@ -52,8 +52,6 @@ const storedKey = (id: string) => ({ id, encryptedApiKey: `encrypted-${id}` })
 
 afterAll(resetDbChainMock)
 
-afterAll(resetEnvFlagsMock)
-
 describe('getBYOKKey', () => {
   beforeEach(() => {
     vi.clearAllMocks()

apps/sim/lib/auth/ban.test.ts

@@ -7,7 +7,6 @@ import {
   dbChainMockFns,
   queueTableRows,
   resetDbChainMock,
-  resetEnvFlagsMock,
   schemaMock,
 } from '@sim/testing'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
@@ -31,8 +30,6 @@ import { getActivelyBannedUserIds, isBanActive, isEmailBlocked } from '@/lib/aut
 
 afterAll(resetDbChainMock)
 
-afterAll(resetEnvFlagsMock)
-
 describe('isBanActive', () => {
   it('returns true for a permanent ban', () => {
     expect(isBanActive({ banned: true, banExpires: null })).toBe(true)

apps/sim/lib/billing/calculations/usage-monitor.test.ts

@@ -54,8 +54,7 @@ describe('checkBillingBlocked', () => {
   beforeEach(() => {
     vi.clearAllMocks()
     resetDbChainMock()
-    setEnvFlags({ isHosted: true })
-    setEnvFlags({ isBillingEnabled: true })
+    setEnvFlags({ isHosted: true, isBillingEnabled: true })
     dbChainMockFns.limit.mockResolvedValue([{ blocked: false, blockedReason: null }])
   })
 
@@ -73,8 +72,7 @@ describe('checkBillingEntityBlocked', () => {
   beforeEach(() => {
     vi.clearAllMocks()
     resetDbChainMock()
-    setEnvFlags({ isHosted: true })
-    setEnvFlags({ isBillingEnabled: true })
+    setEnvFlags({ isHosted: true, isBillingEnabled: true })
     mockIsOrganizationBillingBlocked.mockResolvedValue(false)
     dbChainMockFns.limit.mockResolvedValue([])
   })
@@ -113,8 +111,7 @@ describe('checkOrganizationMemberUsageLimit', () => {
   beforeEach(() => {
     vi.clearAllMocks()
     resetDbChainMock()
-    setEnvFlags({ isHosted: true })
-    setEnvFlags({ isBillingEnabled: true })
+    setEnvFlags({ isHosted: true, isBillingEnabled: true })
     mockGetOrgMemberUsageLimit.mockResolvedValue(2)
     mockGetOrgMemberUsageForBillingPeriod.mockResolvedValue(1)
   })

apps/sim/lib/core/utils/urls.test.ts

@@ -1,8 +1,7 @@
 /**
  * @vitest-environment jsdom
  */
-import { resetEnvFlagsMock } from '@sim/testing'
-import { afterAll, afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockGetEnv } = vi.hoisted(() => ({
   mockGetEnv: vi.fn<(key: string) => string | undefined>(),
@@ -29,8 +28,6 @@ function setLocation(url: string) {
   })
 }
 
-afterAll(resetEnvFlagsMock)
-
 describe('getBrowserOrigin', () => {
   it('returns the page origin in the browser', () => {
     setLocation('https://example.com/some/path')

apps/sim/lib/mcp/service-pool.test.ts

@@ -9,13 +9,7 @@
  */
 import { UnauthorizedError } from '@modelcontextprotocol/sdk/client/auth.js'
 import { StreamableHTTPError } from '@modelcontextprotocol/sdk/client/streamableHttp.js'
-import {
-  dbChainMock,
-  dbChainMockFns,
-  loggerMock,
-  resetDbChainMock,
-  resetEnvFlagsMock,
-} from '@sim/testing'
+import { dbChainMock, dbChainMockFns, loggerMock, resetDbChainMock } from '@sim/testing'
 import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
 
 const {
@@ -115,8 +109,6 @@ vi.mock('@/lib/mcp/storage', () => ({
 
 import { mcpService } from '@/lib/mcp/service'
 
-afterAll(resetEnvFlagsMock)
-
 describe('McpService connection reuse wiring', () => {
   beforeEach(() => {
     vi.clearAllMocks()

apps/sim/providers/index.test.ts

@@ -1,8 +1,7 @@
 /**
  * @vitest-environment node
  */
-import { resetEnvFlagsMock } from '@sim/testing'
-import { afterAll, beforeEach, describe, expect, it, vi } from 'vitest'
+import { beforeEach, describe, expect, it, vi } from 'vitest'
 
 const { mockGetApiKeyWithBYOK, mockExecuteRequest } = vi.hoisted(() => ({
   mockGetApiKeyWithBYOK: vi.fn(),
@@ -63,8 +62,6 @@ function makeAnthropicResponse(): ProviderResponse {
   }
 }
 
-afterAll(resetEnvFlagsMock)
-
 describe('executeProviderRequest — BYOK regression', () => {
   beforeEach(() => {
     vi.clearAllMocks()