improvement(landing): use emcn Loader in scoped loading.tsx, trim auth-client comment

waleedlatif1 · claude · waleedlatif1 · commit 51b5ee94cfd8 · 2026-04-21T12:29:07.000-07:00
Co-Authored-By: Claude Opus 4.7 &lt;noreply@anthropic.com&gt;
diff --git a/apps/sim/app/(landing)/integrations/[slug]/loading.tsx b/apps/sim/app/(landing)/integrations/[slug]/loading.tsx
@@ -1,3 +1,9 @@
+import { Loader } from '@/components/emcn'
+
 export default function IntegrationDetailLoading() {
-  return <div className='min-h-[60vh]' aria-hidden />
+  return (
+    <div className='flex min-h-[60vh] items-center justify-center bg-[var(--landing-bg)]'>
+      <Loader animate className='h-6 w-6 text-[var(--landing-text-muted)]' />
+    </div>
+  )
 }
diff --git a/apps/sim/app/(landing)/models/[provider]/[model]/loading.tsx b/apps/sim/app/(landing)/models/[provider]/[model]/loading.tsx
@@ -1,3 +1,9 @@
+import { Loader } from '@/components/emcn'
+
 export default function ModelDetailLoading() {
-  return <div className='min-h-[60vh]' aria-hidden />
+  return (
+    <div className='flex min-h-[60vh] items-center justify-center bg-[var(--landing-bg)]'>
+      <Loader animate className='h-6 w-6 text-[var(--landing-text-muted)]' />
+    </div>
+  )
 }
diff --git a/apps/sim/app/(landing)/models/[provider]/loading.tsx b/apps/sim/app/(landing)/models/[provider]/loading.tsx
@@ -1,3 +1,9 @@
+import { Loader } from '@/components/emcn'
+
 export default function ModelProviderLoading() {
-  return <div className='min-h-[60vh]' aria-hidden />
+  return (
+    <div className='flex min-h-[60vh] items-center justify-center bg-[var(--landing-bg)]'>
+      <Loader animate className='h-6 w-6 text-[var(--landing-text-muted)]' />
+    </div>
+  )
 }
diff --git a/apps/sim/lib/auth/auth-client.ts b/apps/sim/lib/auth/auth-client.ts
@@ -15,15 +15,6 @@ import { isBillingEnabled, isOrganizationsEnabled } from '@/lib/core/config/feat
 import { getBaseUrl } from '@/lib/core/utils/urls'
 import { SessionContext, type SessionHookResult } from '@/app/_shell/providers/session-provider'
 
-/**
- * On Next.js error-page renders (`<html id="__next_error__">`), scripts from the
- * root layout — including the runtime env script that populates `window.__ENV`
- * — are inserted but not executed by React (see vercel/next.js#63980, #82456).
- * Calling `getBaseUrl()` here at module evaluation would then throw and cascade
- * the error-page render into a blank "Application error" overlay. On the
- * client, auth endpoints are same-origin, so `window.location.origin` is a
- * correct fallback; server-side we still surface a genuine misconfig.
- */
 function getAuthBaseUrl(): string {
   try {
     return getBaseUrl()
