fix(landing): scope X pixel URL dedupe to the tracker instance so same-URL returns to landing still track

Author: waleedlatif1

apps/sim/app/(landing)/x-page-view-tracker.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { useEffect } from 'react'
+import { useEffect, useRef } from 'react'
 import { usePathname, useSearchParams } from 'next/navigation'
 
 declare global {
@@ -11,9 +11,7 @@ declare global {
 
 // next/script dedupes by id and never reloads on remount, so this must be
 // module-scope (not a ref) to survive LandingLayout unmounting/remounting.
-// Keyed by URL (not a boolean) so Strict Mode effect replays and same-URL
-// remounts never re-fire a PageView already counted for that URL.
-let lastTrackedUrl: string | null = null
+let hasTrackedInitialPageView = false
 
 /**
  * The X pixel base code only auto-tracks the first page load; LandingLayout
@@ -26,16 +24,21 @@ export function XPageViewTracker() {
   const searchParams = useSearchParams()
   const query = searchParams.toString()
 
+  // Instance-scoped (not module-scoped) so a Strict Mode replay of this
+  // mount's effect is skipped, while a fresh mount — returning to the landing
+  // layout from the app — starts empty and tracks the view again.
+  const lastTrackedUrlRef = useRef<string | null>(null)
+
   useEffect(() => {
     const url = query ? `${pathname}?${query}` : pathname
+    if (lastTrackedUrlRef.current === url) return
+    lastTrackedUrlRef.current = url
 
-    if (lastTrackedUrl === null) {
-      lastTrackedUrl = url
+    if (!hasTrackedInitialPageView) {
+      hasTrackedInitialPageView = true
       return
     }
-    if (url === lastTrackedUrl) return
 
-    lastTrackedUrl = url
     window.twq?.('config', 'q5xbl')
   }, [pathname, query])