fix(posthog): fix workspace group via URL params, type errors, and clean up comments

Author: waleedlatif1

apps/sim/app/(auth)/signup/signup-form.tsx

@@ -1,11 +1,12 @@
 'use client'
 
-import { Suspense, useMemo, useRef, useState } from 'react'
+import { Suspense, useEffect, useMemo, useRef, useState } from 'react'
 import { Turnstile, type TurnstileInstance } from '@marsidev/react-turnstile'
 import { createLogger } from '@sim/logger'
 import { Eye, EyeOff, Loader2 } from 'lucide-react'
 import Link from 'next/link'
 import { useRouter, useSearchParams } from 'next/navigation'
+import { usePostHog } from 'posthog-js/react'
 import { Input, Label } from '@/components/emcn'
 import { client, useSession } from '@/lib/auth/auth-client'
 import { getEnv, isFalsy, isTruthy } from '@/lib/core/config/env'
@@ -81,7 +82,12 @@ function SignupFormContent({
   const router = useRouter()
   const searchParams = useSearchParams()
   const { refetch: refetchSession } = useSession()
+  const posthog = usePostHog()
   const [isLoading, setIsLoading] = useState(false)
+
+  useEffect(() => {
+    posthog?.capture('signup_page_viewed', {})
+  }, [posthog])
   const [showPassword, setShowPassword] = useState(false)
   const [password, setPassword] = useState('')
   const [passwordErrors, setPasswordErrors] = useState<string[]>([])

apps/sim/app/(home)/landing-analytics.tsx

@@ -3,11 +3,6 @@
 import { useEffect } from 'react'
 import { usePostHog } from 'posthog-js/react'
 
-/**
- * Fires a `landing_page_viewed` PostHog event on mount.
- * Renders nothing — exists only to bridge the server/client boundary
- * so the server-rendered landing page can emit analytics.
- */
 export function LandingAnalytics() {
   const posthog = usePostHog()
 

apps/sim/app/(home)/landing.tsx

@@ -13,6 +13,7 @@ import {
   Templates,
   Testimonials,
 } from '@/app/(home)/components'
+import { LandingAnalytics } from '@/app/(home)/landing-analytics'
 
 /**
  * Landing page root component.
@@ -45,6 +46,7 @@ export default async function Landing() {
       >
         Skip to main content
       </a>
+      <LandingAnalytics />
       <StructuredData />
       <header>
         <Navbar blogPosts={blogPosts} />

apps/sim/app/_shell/providers/session-provider.tsx

@@ -92,11 +92,6 @@ export function SessionProvider({ children }: { children: React.ReactNode }) {
               email_verified: data.user.emailVerified,
               created_at: data.user.createdAt,
             })
-
-            const workspaceId = data.session?.activeOrganizationId
-            if (workspaceId && typeof posthog.group === 'function') {
-              posthog.group('workspace', workspaceId)
-            }
           } else {
             posthog.reset()
           }

apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/route.ts

@@ -352,16 +352,17 @@ export async function DELETE(request: NextRequest, { params }: RouteParams) {
       `[${requestId}] Deleted connector ${connectorId}${deleteDocuments ? ` and ${docCount} documents` : `, kept ${docCount} documents`}`
     )
 
+    const kbWorkspaceId = writeCheck.knowledgeBase.workspaceId ?? ''
     captureServerEvent(
       auth.userId,
       'knowledge_base_connector_removed',
       {
         knowledge_base_id: knowledgeBaseId,
-        workspace_id: writeCheck.knowledgeBase.workspaceId,
+        workspace_id: kbWorkspaceId,
         connector_type: existingConnector[0].connectorType,
         documents_deleted: deleteDocuments ? docCount : 0,
       },
-      { groups: { workspace: writeCheck.knowledgeBase.workspaceId } }
+      kbWorkspaceId ? { groups: { workspace: kbWorkspaceId } } : undefined
     )
 
     recordAudit({

apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/sync/route.ts

@@ -56,15 +56,16 @@ export async function POST(request: NextRequest, { params }: RouteParams) {
 
     logger.info(`[${requestId}] Manual sync triggered for connector ${connectorId}`)
 
+    const kbWorkspaceId = writeCheck.knowledgeBase.workspaceId ?? ''
     captureServerEvent(
       auth.userId,
       'knowledge_base_connector_synced',
       {
         knowledge_base_id: knowledgeBaseId,
-        workspace_id: writeCheck.knowledgeBase.workspaceId,
+        workspace_id: kbWorkspaceId,
         connector_type: connectorRows[0].connectorType,
       },
-      { groups: { workspace: writeCheck.knowledgeBase.workspaceId } }
+      kbWorkspaceId ? { groups: { workspace: kbWorkspaceId } } : undefined
     )
 
     recordAudit({

apps/sim/app/api/knowledge/[id]/connectors/route.ts

@@ -228,17 +228,18 @@ export async function POST(request: NextRequest, { params }: { params: Promise<{
 
     logger.info(`[${requestId}] Created connector ${connectorId} for KB ${knowledgeBaseId}`)
 
+    const kbWorkspaceId = writeCheck.knowledgeBase.workspaceId ?? ''
     captureServerEvent(
       auth.userId,
       'knowledge_base_connector_added',
       {
         knowledge_base_id: knowledgeBaseId,
-        workspace_id: writeCheck.knowledgeBase.workspaceId,
+        workspace_id: kbWorkspaceId,
         connector_type: connectorType,
         sync_interval_minutes: syncIntervalMinutes,
       },
       {
-        groups: { workspace: writeCheck.knowledgeBase.workspaceId },
+        groups: kbWorkspaceId ? { workspace: kbWorkspaceId } : undefined,
         setOnce: { first_connector_added_at: new Date().toISOString() },
       }
     )

apps/sim/app/workspace/[workspaceId]/providers/workspace-scope-sync.tsx

@@ -2,6 +2,7 @@
 
 import { useEffect } from 'react'
 import { useParams } from 'next/navigation'
+import { usePostHog } from 'posthog-js/react'
 import { useWorkflowRegistry } from '@/stores/workflows/registry/store'
 
 /**
@@ -11,6 +12,12 @@ export function WorkspaceScopeSync() {
   const { workspaceId } = useParams<{ workspaceId: string }>()
   const hydrationWorkspaceId = useWorkflowRegistry((state) => state.hydration.workspaceId)
   const switchToWorkspace = useWorkflowRegistry((state) => state.switchToWorkspace)
+  const posthog = usePostHog()
+
+  useEffect(() => {
+    if (!workspaceId) return
+    posthog?.group('workspace', workspaceId)
+  }, [posthog, workspaceId])
 
   useEffect(() => {
     if (!workspaceId || hydrationWorkspaceId === workspaceId) {

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx

@@ -3,6 +3,7 @@
 import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react'
 import { GripVertical } from 'lucide-react'
 import { useParams, useRouter } from 'next/navigation'
+import { usePostHog } from 'posthog-js/react'
 import {
   Button,
   Checkbox,
@@ -177,6 +178,12 @@ export function Table({
   const router = useRouter()
   const workspaceId = propWorkspaceId || (params.workspaceId as string)
   const tableId = propTableId || (params.tableId as string)
+  const posthog = usePostHog()
+
+  useEffect(() => {
+    if (!tableId || !workspaceId) return
+    posthog?.capture('table_opened', { table_id: tableId, workspace_id: workspaceId })
+  }, [tableId, workspaceId, posthog])
 
   const [queryOptions, setQueryOptions] = useState<QueryOptions>({
     filter: null,

apps/sim/lib/posthog/events.ts

@@ -93,7 +93,6 @@ export interface PostHogEventMap {
     workspace_id: string
   }
 
-  /** Fired server-side when a user reverts a workflow canvas to a prior deployment snapshot. */
   workflow_deployment_reverted: {
     workflow_id: string
     workspace_id: string
@@ -105,7 +104,6 @@ export interface PostHogEventMap {
     workspace_id: string
   }
 
-  /** Fired server-side when a workflow is exposed as an A2A agent. */
   a2a_agent_created: {
     agent_id: string
     workflow_id: string
@@ -241,7 +239,6 @@ export interface PostHogEventMap {
     workspace_id: string
   }
 
-  /** Fired server-side when a custom tool is created or updated. */
   custom_tool_saved: {
     tool_id: string
     workspace_id: string
@@ -253,7 +250,6 @@ export interface PostHogEventMap {
     workspace_id: string
   }
 
-  /** Fired server-side when a new BYOK (bring-your-own-key) provider key is added. */
   byok_key_added: {
     workspace_id: string
     provider_id: string