improvement(workflows): final polish on the reference viewer

- drop the vestigial isOpen prop (conditional mount owns visibility)
- unify on the emcn Workflow icon in tree rows
- inline the static className and derive nodes without an annotation
- remove one restating test comment

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/references-modal/components/reference-tree/reference-tree.tsx

@@ -1,7 +1,6 @@
 'use client'
 
-import { cn } from '@sim/emcn'
-import { WorkflowIcon } from '@/components/icons'
+import { Workflow } from '@sim/emcn/icons'
 import type { ReferenceNode } from '@/lib/api/contracts/workflow-references'
 
 const CONFIG = {
@@ -30,12 +29,9 @@ function ReferenceTreeItem({ node, depth, onNavigate }: ReferenceTreeItemProps)
         type='button'
         onClick={() => onNavigate(node.id)}
         style={{ paddingLeft: CONFIG.BASE_INDENT + depth * CONFIG.INDENT_PER_LEVEL }}
-        className={cn(
-          'flex w-full min-w-0 items-center gap-2 rounded-md py-1.5 pr-2 text-left transition-colors',
-          'hover:bg-[var(--surface-hover)]'
-        )}
+        className='flex w-full min-w-0 items-center gap-2 rounded-md py-1.5 pr-2 text-left transition-colors hover:bg-[var(--surface-hover)]'
       >
-        <WorkflowIcon className='size-[14px] shrink-0 text-[var(--text-icon)]' />
+        <Workflow className='size-[14px] shrink-0 text-[var(--text-icon)]' />
         <span className='min-w-0 truncate text-[var(--text-body)] text-sm'>{node.name}</span>
         {node.cycle && (
           <span className='shrink-0 text-[var(--text-muted)] text-caption'>(cycle)</span>

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/references-modal/references-modal.tsx

@@ -3,7 +3,6 @@
 import { useState } from 'react'
 import { ChipModal, ChipModalBody, ChipModalHeader, ChipModalTabs } from '@sim/emcn'
 import { useRouter } from 'next/navigation'
-import type { ReferenceNode } from '@/lib/api/contracts/workflow-references'
 import { ReferenceTree } from '@/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/references-modal/components/reference-tree/reference-tree'
 import { useWorkflowReferences } from '@/hooks/queries/workflow-references'
 
@@ -20,7 +19,6 @@ const EMPTY_MESSAGE: Record<ReferencesTab, string> = {
 }
 
 interface ReferencesModalProps {
-  isOpen: boolean
   onClose: () => void
   workspaceId: string
   workflowId: string
@@ -34,7 +32,6 @@ interface ReferencesModalProps {
  * demand by the owning row, so state initializes fresh per open.
  */
 export function ReferencesModal({
-  isOpen,
   onClose,
   workspaceId,
   workflowId,
@@ -50,10 +47,10 @@ export function ReferencesModal({
     onClose()
   }
 
-  const nodes: ReferenceNode[] = data ? data[activeTab] : []
+  const nodes = data?.[activeTab] ?? []
 
   return (
-    <ChipModal open={isOpen} onOpenChange={(next) => !next && onClose()} srTitle='References'>
+    <ChipModal open onOpenChange={(next) => !next && onClose()} srTitle='References'>
       <ChipModalHeader onClose={onClose}>References · {workflowName}</ChipModalHeader>
       <ChipModalBody>
         <ChipModalTabs

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/workflow-list/components/workflow-item/workflow-item.tsx

@@ -525,7 +525,6 @@ export const WorkflowItem = memo(function WorkflowItem({
 
       {isReferencesOpen && (
         <ReferencesModal
-          isOpen
           onClose={() => setIsReferencesOpen(false)}
           workspaceId={workspaceId}
           workflowId={workflow.id}

apps/sim/lib/workflows/references/operations.test.ts

@@ -125,7 +125,6 @@ describe('resolveWorkflowReferences', () => {
   })
 
   it('resolves references made through custom blocks', () => {
-    // D places custom_block_x, which is bound to source workflow C.
     const blocks: ReferenceBlockRow[] = [
       {
         parentId: 'd',