|
| 1 | +/** |
| 2 | + * @vitest-environment node |
| 3 | + */ |
| 4 | +import { beforeEach, describe, expect, it, vi } from 'vitest' |
| 5 | +import { buildOpenAIMessageContent } from '@/providers/attachments' |
| 6 | +import { |
| 7 | + attachLargeFileRemoteUrls, |
| 8 | + uploadLargeFilesToProvider, |
| 9 | +} from '@/providers/file-attachments.server' |
| 10 | +import type { ProviderRequest } from '@/providers/types' |
| 11 | + |
| 12 | +const { |
| 13 | + mockDownloadServableFileFromStorage, |
| 14 | + mockGeneratePresignedDownloadUrl, |
| 15 | + mockHasCloudStorage, |
| 16 | + mockVerifyFileAccess, |
| 17 | +} = vi.hoisted(() => ({ |
| 18 | + mockDownloadServableFileFromStorage: vi.fn(), |
| 19 | + mockGeneratePresignedDownloadUrl: vi.fn(), |
| 20 | + mockHasCloudStorage: vi.fn(), |
| 21 | + mockVerifyFileAccess: vi.fn(), |
| 22 | +})) |
| 23 | + |
| 24 | +vi.mock('@google/genai', () => ({ |
| 25 | + FileState: { PROCESSING: 'PROCESSING', FAILED: 'FAILED' }, |
| 26 | + GoogleGenAI: class {}, |
| 27 | +})) |
| 28 | + |
| 29 | +vi.mock('@/lib/uploads', () => ({ |
| 30 | + StorageService: { |
| 31 | + hasCloudStorage: mockHasCloudStorage, |
| 32 | + generatePresignedDownloadUrl: mockGeneratePresignedDownloadUrl, |
| 33 | + }, |
| 34 | +})) |
| 35 | + |
| 36 | +vi.mock('@/lib/uploads/utils/file-utils.server', () => ({ |
| 37 | + downloadServableFileFromStorage: mockDownloadServableFileFromStorage, |
| 38 | +})) |
| 39 | + |
| 40 | +vi.mock('@/app/api/files/authorization', () => ({ |
| 41 | + verifyFileAccess: mockVerifyFileAccess, |
| 42 | +})) |
| 43 | + |
| 44 | +/** The exact file from the reported failure: 9,591,617 bytes — over 6 MiB, under 50 MB. */ |
| 45 | +const CSV_BYTES = 9_591_617 |
| 46 | + |
| 47 | +function makeRequest(size: number): ProviderRequest { |
| 48 | + return { |
| 49 | + model: 'gpt-4.1', |
| 50 | + apiKey: 'sk-test', |
| 51 | + userId: 'user-1', |
| 52 | + workflowId: 'workflow-1', |
| 53 | + messages: [ |
| 54 | + { |
| 55 | + role: 'user', |
| 56 | + content: 'what does this say', |
| 57 | + files: [ |
| 58 | + { |
| 59 | + id: 'file-1', |
| 60 | + name: 'data_10mb.csv', |
| 61 | + key: 'workspace/2f1d8c3e-5b6a-4c7d-8e9f-0a1b2c3d4e5f/data_10mb.csv', |
| 62 | + url: '', |
| 63 | + size, |
| 64 | + type: 'text/csv', |
| 65 | + context: 'workspace', |
| 66 | + }, |
| 67 | + ], |
| 68 | + }, |
| 69 | + ], |
| 70 | + } as unknown as ProviderRequest |
| 71 | +} |
| 72 | + |
| 73 | +describe('OpenAI large-file attachment lifecycle', () => { |
| 74 | + beforeEach(() => { |
| 75 | + vi.clearAllMocks() |
| 76 | + mockHasCloudStorage.mockReturnValue(true) |
| 77 | + mockVerifyFileAccess.mockResolvedValue(true) |
| 78 | + mockGeneratePresignedDownloadUrl.mockResolvedValue('https://storage.example.com/signed') |
| 79 | + mockDownloadServableFileFromStorage.mockResolvedValue({ |
| 80 | + buffer: Buffer.alloc(CSV_BYTES, 0x61), |
| 81 | + contentType: 'text/csv', |
| 82 | + }) |
| 83 | + vi.stubGlobal( |
| 84 | + 'fetch', |
| 85 | + vi.fn(async () => new Response(JSON.stringify({ id: 'file-abc' }), { status: 200 })) |
| 86 | + ) |
| 87 | + }) |
| 88 | + |
| 89 | + it('uploads to the Files API and references the file by id instead of inlining it', async () => { |
| 90 | + const request = makeRequest(CSV_BYTES) |
| 91 | + |
| 92 | + await attachLargeFileRemoteUrls(request, 'openai') |
| 93 | + await uploadLargeFilesToProvider(request, 'openai') |
| 94 | + |
| 95 | + const [url, init] = (fetch as unknown as ReturnType<typeof vi.fn>).mock.calls[0] |
| 96 | + expect(url).toBe('https://api.openai.com/v1/files') |
| 97 | + expect(init.method).toBe('POST') |
| 98 | + expect(init.headers.Authorization).toBe('Bearer sk-test') |
| 99 | + |
| 100 | + const form = init.body as FormData |
| 101 | + expect(form.get('purpose')).toBe('user_data') |
| 102 | + expect(form.get('expires_after[anchor]')).toBe('created_at') |
| 103 | + expect(form.get('expires_after[seconds]')).toBe('3600') |
| 104 | + expect((form.get('file') as File).size).toBe(CSV_BYTES) |
| 105 | + |
| 106 | + const file = request.messages?.[0].files?.[0] |
| 107 | + expect(file?.providerFileId).toBe('file-abc') |
| 108 | + |
| 109 | + const content = buildOpenAIMessageContent( |
| 110 | + 'what does this say', |
| 111 | + request.messages?.[0].files, |
| 112 | + 'openai' |
| 113 | + ) |
| 114 | + expect(content).toEqual([ |
| 115 | + { type: 'input_text', text: 'what does this say' }, |
| 116 | + { type: 'input_file', file_id: 'file-abc' }, |
| 117 | + ]) |
| 118 | + }) |
| 119 | + |
| 120 | + it('leaves files at or below the inline cap on the base64 path', async () => { |
| 121 | + const request = makeRequest(5 * 1024 * 1024) |
| 122 | + |
| 123 | + await attachLargeFileRemoteUrls(request, 'openai') |
| 124 | + await uploadLargeFilesToProvider(request, 'openai') |
| 125 | + |
| 126 | + expect(fetch).not.toHaveBeenCalled() |
| 127 | + expect(request.messages?.[0].files?.[0].providerFileId).toBeUndefined() |
| 128 | + expect(request.messages?.[0].files?.[0].remoteUrl).toBeUndefined() |
| 129 | + }) |
| 130 | + |
| 131 | + it('rejects a request whose attachments together exceed the combined ceiling', async () => { |
| 132 | + const request = makeRequest(30 * 1024 * 1024) |
| 133 | + const [first] = request.messages?.[0].files ?? [] |
| 134 | + request.messages?.[0].files?.push({ ...first, id: 'file-2', key: `${first.key}-2` }) |
| 135 | + |
| 136 | + await expect(attachLargeFileRemoteUrls(request, 'openai')).rejects.toThrow( |
| 137 | + /total 60.00MB, which exceeds the 48MB combined attachment limit/ |
| 138 | + ) |
| 139 | + expect(fetch).not.toHaveBeenCalled() |
| 140 | + }) |
| 141 | +}) |
0 commit comments