fix(quickbooks): require explicit API environment

Author: Bill Leoutsakos

apps/sim/.env.example

@@ -112,6 +112,11 @@ API_ENCRYPTION_KEY=your_api_encryption_key # Use `openssl rand -hex 32` to gener
 # TIKTOK_CLIENT_ID=
 # TIKTOK_CLIENT_SECRET=
 
+# QuickBooks Online OAuth (Optional - credentials from the Intuit Developer Portal)
+# QUICKBOOKS_CLIENT_ID=
+# QUICKBOOKS_CLIENT_SECRET=
+# QUICKBOOKS_ENV=sandbox                         # Required when QuickBooks is configured: sandbox or production
+
 # Azure Blob Storage takes precedence over S3 if both are configured
 # AZURE_ACCOUNT_NAME=                             # Azure storage account name
 # AZURE_ACCOUNT_KEY=                              # Azure storage account key

apps/sim/lib/oauth/quickbooks.test.ts

@@ -1,4 +1,5 @@
-import { afterEach, describe, expect, it, vi } from 'vitest'
+import { resetEnvMock, setEnv } from '@sim/testing'
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
 import {
   createQuickBooksAccountId,
   fetchQuickBooksConnectionProfile,
@@ -12,8 +13,13 @@ import { QUICKBOOKS_MAX_USER_INFO_BYTES } from '@/lib/quickbooks/client'
 const TEST_UUID = '01234567-89ab-4def-8abc-0123456789ab'
 const originalFetch = global.fetch
 
+beforeEach(() => {
+  setEnv({ QUICKBOOKS_ENV: 'sandbox' })
+})
+
 afterEach(() => {
   global.fetch = originalFetch
+  resetEnvMock()
 })
 
 describe('QuickBooks account identity', () => {

apps/sim/lib/quickbooks/client.ts

@@ -12,7 +12,12 @@ export const QUICKBOOKS_MAX_USER_INFO_BYTES = 1024 * 1024
 export type QuickBooksEnvironment = 'sandbox' | 'production'
 
 export function getQuickBooksEnvironment(): QuickBooksEnvironment {
-  const value = env.QUICKBOOKS_ENV ?? 'sandbox'
+  const value = env.QUICKBOOKS_ENV
+  if (!value) {
+    throw new Error(
+      'QUICKBOOKS_ENV must be explicitly configured as either "sandbox" or "production"'
+    )
+  }
   if (value !== 'sandbox' && value !== 'production') {
     throw new Error('QUICKBOOKS_ENV must be either "sandbox" or "production"')
   }

apps/sim/tools/quickbooks/quickbooks.test.ts

@@ -41,9 +41,11 @@ describe('QuickBooks request construction', () => {
     )
   })
 
-  it('defaults to sandbox and rejects an invalid environment at the API boundary', () => {
+  it('requires an explicit valid environment at the API boundary', () => {
     setEnv({ QUICKBOOKS_ENV: undefined })
-    expect(getQuickBooksEnvironment()).toBe('sandbox')
+    expect(() => getQuickBooksEnvironment()).toThrow(
+      'QUICKBOOKS_ENV must be explicitly configured as either "sandbox" or "production"'
+    )
 
     setEnv({ QUICKBOOKS_ENV: 'staging' })
     expect(() => getQuickBooksEnvironment()).toThrow(