improvement(external-endpoints): v2 versions with clean signatures + updated docs based on openapi spec #24964
ci.yml
on: pull_request
Detect Version
0s
Migrate Dev DB
/
Apply Database Migrations
Detect Desktop Changes
0s
Matrix: Build AMD64
Matrix: Build ARM64 (GHCR Only)
Test and Build
/
Lint and Test
3m 37s
Test and Build
/
Build App
2m 48s
Check Docs Changes
0s
Matrix: Build Dev ECR
Deploy Trigger.dev (Dev)
0s
Matrix: Create GHCR Manifests
Process Docs
/
Process Documentation Embeddings
Prune Desktop Prereleases
Desktop Release
/
Build, Sign, Notarize
Annotations
15 errors and 12 warnings
|
Test and Build / Build App
Process completed with exit code 1.
|
|
Test and Build / Build App
sim#build: command (/home/runner/_work/sim/sim/apps/sim) /home/runner/.bun/bin/bun run build exited (1)
|
|
Test and Build / Build App
Cannot find name 'hasCloudStorage'.
|
|
Test and Build / Build App
Element implicitly has an 'any' type because expression of type 'ServiceAccountFieldId' can't be used to index type '{ serviceAccountJson?: string | undefined; signingSecret?: string | undefined; botToken?: string | undefined; apiToken?: string | undefined; domain?: string | undefined; clientId?: string | undefined; ... 7 more ...; envKey?: string | undefined; }'.
|
|
lib/uploads/contexts/workspace/track-chat-upload.test.ts > trackChatUpload > retries metadata naming without workspace storage accounting:
apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts#L727
ReferenceError: hasCloudStorage is not defined
❯ Module.trackChatUpload lib/uploads/contexts/workspace/workspace-file-manager.ts:727:17
❯ lib/uploads/contexts/workspace/track-chat-upload.test.ts:217:20
|
|
lib/uploads/contexts/workspace/track-chat-upload.test.ts > trackChatUpload > stamps message_id on the fallback INSERT arm and nulls it when omitted:
apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts#L727
ReferenceError: hasCloudStorage is not defined
❯ Module.trackChatUpload lib/uploads/contexts/workspace/workspace-file-manager.ts:727:17
❯ lib/uploads/contexts/workspace/track-chat-upload.test.ts:182:5
|
|
lib/uploads/contexts/workspace/track-chat-upload.test.ts > trackChatUpload > finalizes a presigned upload without workspace storage accounting:
apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts#L727
ReferenceError: hasCloudStorage is not defined
❯ Module.trackChatUpload lib/uploads/contexts/workspace/workspace-file-manager.ts:727:17
❯ lib/uploads/contexts/workspace/track-chat-upload.test.ts:136:20
|
|
lib/logs/execution/logging-session.test.ts:
apps/sim/lib/uploads/contexts/workspace/workspace-file-manager.ts#L983
TypeError: sql(...).mapWith is not a function
❯ lib/uploads/contexts/workspace/workspace-file-manager.ts:983:82
❯ lib/uploads/contexts/workspace/fetch-external-url.ts:13:1
❯ lib/uploads/contexts/workspace/index.ts:1:1
|
|
lib/billing/storage/tracking.test.ts > workspace storage counter mutations > rejects destination quota before mutating any ledger:
apps/sim/lib/billing/storage/tracking.test.ts#L537
AssertionError: expected [Function] to throw error including 'Storage limit exceeded' but got '[vitest] No "StorageLimitExceededErro…'
- Expected
+ Received
- Storage limit exceeded
+ [vitest] No "StorageLimitExceededError" export is defined on the "@/lib/billing/storage/limits" mock. Did you forget to return it from "vi.mock"?
+ If you need to partially mock a module, you can use "importOriginal" helper inside:
+
❯ lib/billing/storage/tracking.test.ts:537:5
|
|
lib/billing/storage/tracking.test.ts > workspace storage counter mutations > serializes quota admission on the locked payer ledger:
apps/sim/lib/billing/storage/tracking.test.ts#L209
AssertionError: expected [Function] to throw error including 'Storage limit exceeded' but got '[vitest] No "StorageLimitExceededErro…'
- Expected
+ Received
- Storage limit exceeded
+ [vitest] No "StorageLimitExceededError" export is defined on the "@/lib/billing/storage/limits" mock. Did you forget to return it from "vi.mock"?
+ If you need to partially mock a module, you can use "importOriginal" helper inside:
+
❯ lib/billing/storage/tracking.test.ts:209:5
|
|
hooks/queries/tables.test.ts:
apps/sim/lib/api/contracts/v1/tables/index.ts#L46
Error: [vitest] No "tableRowsQueryBaseSchema" export is defined on the "@/lib/api/contracts/tables" mock. Did you forget to return it from "vi.mock"?
If you need to partially mock a module, you can use "importOriginal" helper inside:
vi.mock(import("@/lib/api/contracts/tables"), async (importOriginal) => {
const actual = await importOriginal()
return {
...actual,
// your mocked methods
}
})
❯ lib/api/contracts/v1/tables/index.ts:46:39
❯ lib/api/contracts/v2/tables.ts:37:1
|
|
tools/index.test.ts > executeTool Function > does not charge private provenance against the functional response limit:
apps/sim/tools/index.test.ts#L944
AssertionError: expected false to be true // Object.is equality
- Expected
+ Received
- true
+ false
❯ tools/index.test.ts:944:28
|
|
tools/index.test.ts > executeTool Function > filters cross-scope workflow provenance to literals present in the unchanged result:
apps/sim/tools/index.test.ts#L875
AssertionError: expected { success: false, …(3) } to deeply equal { success: true, duration: 17, …(6) }
- Expected
+ Received
@@ -1,19 +1,17 @@
{
- "childWorkflowId": "child-workflow",
- "childWorkflowName": "Child Workflow",
- "duration": 17,
- "error": undefined,
+ "error": "\"child-workflow\" failed: Child workflow child-workflow returned empty data",
"output": {
- "answer": "The child returned crossed-secret verbatim",
- "publicValue": "unchanged",
+ "error": {
+ "blockId": undefined,
+ "blockName": undefined,
+ "blockType": undefined,
+ "code": "EXECUTION_FAILED",
+ "message": "\"child-workflow\" failed: Child workflow child-workflow returned empty data",
},
- "result": {
- "answer": "The child returned crossed-secret verbatim",
- "publicValue": "unchanged",
},
- "success": true,
+ "success": false,
"timing": {
"duration": 6555,
"endTime": "2026-08-04T05:19:18.007Z",
"startTime": "2026-08-04T05:19:11.452Z",
},
❯ tools/index.test.ts:875:20
|
|
Test and Build / Lint and Test
sim#test: command (/home/runner/_work/sim/sim/apps/sim) /home/runner/.bun/bin/bun run test exited (1)
|
|
Test and Build / Lint and Test
Process completed with exit code 1.
|
|
Test and Build / Build App
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Build App
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Build App
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Build App
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Build App
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Build App
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|
|
Test and Build / Lint and Test
Skipping sticky disk commit due to previous step failures
|
|
Test and Build / Lint and Test
Found 2 failed/cancelled steps in previous workflow steps
|