Enhancements according to best practices

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: tusharjadhav3302

collection/stages/roles/day2ops/tasks/procedures/configure_ipv6_secondary.yml

@@ -58,6 +58,15 @@
   ansible.builtin.set_fact:
     ipv6_interfaces: "{{ ipv6_interfaces_results.results | map(attribute='stdout') | list }}"
 
+- name: Validate discovered IPv6 interfaces are not empty
+  ansible.builtin.assert:
+    that:
+      - ipv6_interfaces | length == ipv6_secondary_networks.networks | length
+      - ipv6_interfaces | select('equalto', '') | list | length == 0
+    fail_msg: |
+      Failed to discover IPv6 interfaces on worker {{ ocp_workers[0] }}.
+      Expected {{ ipv6_secondary_networks.networks | length }} interfaces, got: {{ ipv6_interfaces }}
+
 - name: Display discovered IPv6 interfaces
   ansible.builtin.debug:
     var: ipv6_interfaces
@@ -174,3 +183,12 @@
   loop: "{{ ipv6_secondary_networks.projects }}"
   loop_control:
     loop_var: ipv6_namespace
+
+- name: Cleanup temporary manifest files
+  ansible.builtin.file:
+    path: "{{ item }}"
+    state: absent
+  loop: "{{ ['/tmp/network-macvlan.yml'] + ipv6_secondary_networks.projects | map('regex_replace', '^(.*)$', '/tmp/ipv6-deployment-\\1.yml') | list }}"
+  loop_control:
+    label: "{{ item }}"
+  ignore_errors: true  # noqa: ignore-errors

collection/stages/roles/day2ops/tasks/procedures/verify_ipv6_connectivity.yml

@@ -39,8 +39,18 @@
   ansible.builtin.debug:
     var: ipv6_pod_ips
 
+- name: Validate all pods have IPv6 addresses
+  ansible.builtin.assert:
+    that:
+      - ipv6_pod_ips | length > 0
+      - ipv6_pod_ips.values() | select('equalto', '') | list | length == 0
+    fail_msg: |
+      Not all pods in {{ ipv6_namespace }} received IPv6 addresses.
+      Pod IPs: {{ ipv6_pod_ips }}
+
 - name: Check pod-to-pod IPv6 connectivity in {{ ipv6_namespace }}
   ansible.builtin.shell: |
+    set -o pipefail && \
     oc exec {{ item[0] }} -n {{ ipv6_namespace }} -- /bin/curl -s --connect-timeout 10 http://[{{ item[1] }}]:8080
   environment:
     KUBECONFIG: "{{ kubeconfig }}"

collection/stages/roles/day2ops/tasks/procedures/verify_ipv6_external_reachability.yml

@@ -27,7 +27,8 @@
 
 - name: Verify external IPv6 reachability from worker node to pods in {{ ipv6_namespace }}
   ansible.builtin.shell: |
-    oc debug node/{{ ocp_workers[0] }} -- chroot /host curl -s --connect-timeout 10 http://[{{ item.stdout }}]:8080
+    set -o pipefail && \
+    timeout 120 oc debug node/{{ ocp_workers[0] }} -- chroot /host curl -s --connect-timeout 10 http://[{{ item.stdout }}]:8080
   environment:
     KUBECONFIG: "{{ kubeconfig }}"
   loop: "{{ ext_pod_ipv6_results.results }}"